)]}'
{"id":"opendev%2Fpuppet-log_processor~677104","triplet_id":"opendev%2Fpuppet-log_processor~master~I328bafea3ddae858fd77af043f16c499ddd5a30e","project":"opendev/puppet-log_processor","branch":"master","topic":"swift-logs","hashtags":[],"change_id":"I328bafea3ddae858fd77af043f16c499ddd5a30e","subject":"log-gearman-worker: handle deflate encoded values","status":"MERGED","created":"2019-08-19 02:49:39.000000000","updated":"2019-08-19 15:39:55.000000000","submitted":"2019-08-19 15:39:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677104-1566229195916-3f7c88c0","meta_rev_id":"2019f2a391ab9c9a7c699e9b6468bea661e8a10c","_number":677104,"virtual_id_number":677104,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-08-19 15:39:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":2,"date":"2019-08-19 15:19:32.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2019-08-19 15:15:35.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":1,"date":"2019-08-19 15:19:32.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-19 15:15:35.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2019-08-19 15:19:32.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2019-08-19 15:39:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dcf14096cfb5e2a6a677217d76d4d105ca191962","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-19 02:49:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4c603eab471b0f8008b5209abc92895e9578f605","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-19 02:52:00.000000000","message":"Patch Set 1:\n\nHere\u0027s why I say that RAX is returning deflate code when not requested (there is a file logstash-worker01:/home/ianw/ls-test/test.py where i\u0027ve extracted the bits of the log processor for testing)\n\nhttp://paste.openstack.org/show/759693/\n\n DEBUG:root:Retrieving: https://80761cae90bb201ddf2a-de5ae15935168409da4576fce7897429.ssl.cf2.rackcdn.com/675728/1/check/neutron-tempest-dvr-ha-multinode-full/297ff0b/job-output.txt?level\u003dINFO\n send: \u0027GET /675728/1/check/neutron-tempest-dvr-ha-multinode-full/297ff0b/job-output.txt?level\u003dINFO HTTP/1.1\\r\\nAccept-Encoding: identity\\r\\nHost: 80761cae90bb201ddf2a-de5ae15935168409da4576fce7897429.ssl.cf2.rackcdn.com\\r\\nConnection: close\\r\\nUser-Agent: Python-urllib/2.7\\r\\n\\r\\n\u0027\n reply: \u0027HTTP/1.1 200 OK\\r\\n\u0027\n header: Content-Length: 1667028\n header: Content-Encoding: deflate\n\nlooks to me like we\u0027re not requesting deflate encoding, but getting it anyway...","accounts_in_message":[],"_revision_number":1},{"id":"6d4c4968142de1416639bd68cf699f264c47f5ad","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-19 03:04:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-lint https://zuul.opendev.org/t/openstack/build/59df202247784aed8dfebec2f03b28b9 : SUCCESS in 6m 12s\n- legacy-puppet-syntax-4-centos-7 https://zuul.opendev.org/t/openstack/build/109b225d539a4a6c97e3be109b45d6a3 : SUCCESS in 8m 13s\n- infra-puppet-apply-4-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/829f6608de064bd3bab2e43cf9a8ee08 : SUCCESS in 12m 51s\n- openstackci-beaker-puppet-4 https://zuul.opendev.org/t/openstack/build/eefa8202b0b747879679428223f1eedc : SUCCESS in 14m 39s\n- puppet-beaker-rspec-puppet-4-centos-7-infra https://zuul.opendev.org/t/openstack/build/82a75d1dfe344e68b2c672efe70bde11 : SUCCESS in 11m 34s\n- puppet-beaker-rspec-puppet-4-infra https://zuul.opendev.org/t/openstack/build/184dd8fce6304000888cf7b03a60a604 : SUCCESS in 12m 37s","accounts_in_message":[],"_revision_number":1},{"id":"40be2df3b80dd8f15095e2e5cafe92068849caec","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-19 03:07:19.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b4e40ab3eefa335a357241c9345a9fee015df4db","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-19 03:32:04.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-lint https://zuul.opendev.org/t/openstack/build/8e0ffbc39d7f43b589a57f9740a3e423 : SUCCESS in 8m 05s\n- legacy-puppet-syntax-4-centos-7 https://zuul.opendev.org/t/openstack/build/ef6ac7e647f2470cb6766e2e45bb1e78 : SUCCESS in 10m 37s\n- infra-puppet-apply-4-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/e114be65b28546b494d6ffdb3bdc6466 : SUCCESS in 12m 35s\n- openstackci-beaker-puppet-4 https://zuul.opendev.org/t/openstack/build/7f9b77c9cb4d49948e878e7061739b97 : SUCCESS in 15m 02s\n- puppet-beaker-rspec-puppet-4-centos-7-infra https://zuul.opendev.org/t/openstack/build/f870a1076db64727b17780b12e434038 : SUCCESS in 15m 20s\n- puppet-beaker-rspec-puppet-4-infra https://zuul.opendev.org/t/openstack/build/730b67bc467640baa43a2baab823d7c1 : SUCCESS in 13m 58s","accounts_in_message":[],"_revision_number":2},{"id":"b33a8ec86f9c772774eb3324fa4a2e36f198e934","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-08-19 07:17:59.000000000","message":"Topic changed from deflate to swift-logs","accounts_in_message":[],"_revision_number":2},{"id":"f406d18cd2825a1a3246be809e5b7ac540560b00","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-08-19 15:15:35.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"34489b0ce695b2d8508808369a1f39eec457f182","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2019-08-19 15:19:32.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"606cfb5c06681a49a27a92de96e793aff43bb71c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-19 15:19:44.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e48d525c1b02012ba3357ee467e9c94bf94f4391","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-19 15:39:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"2019f2a391ab9c9a7c699e9b6468bea661e8a10c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-19 15:39:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- legacy-puppet-lint https://zuul.opendev.org/t/openstack/build/4d2c01aea44d4330afd8fdb641472db8 : SUCCESS in 5m 51s\n- legacy-puppet-syntax-4-centos-7 https://zuul.opendev.org/t/openstack/build/3e4081cbb3734cad9de3dbcb0efe62af : SUCCESS in 9m 18s\n- infra-puppet-apply-4-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/d2d94c16fdf24b0dbbafc03e186ba125 : SUCCESS in 13m 04s\n- openstackci-beaker-puppet-4 https://zuul.opendev.org/t/openstack/build/202533d585e14024a5fb10e09103e65a : SUCCESS in 14m 12s\n- puppet-beaker-rspec-puppet-4-centos-7-infra https://zuul.opendev.org/t/openstack/build/ae539a9690544034bdc5c34b7e68e0aa : SUCCESS in 13m 36s\n- puppet-beaker-rspec-puppet-4-infra https://zuul.opendev.org/t/openstack/build/4d584d247d97434c98c4a8024131e036 : SUCCESS in 17m 13s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"bca04e3155c7b7c5318618d79cacb4243461ddc2","revisions":{"a0d85c77ae964bd866a8028804390a5fc0b6a75f":{"kind":"REWORK","_number":1,"created":"2019-08-19 02:49:39.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/677104/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-log_processor","ref":"refs/changes/04/677104/1","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/1"}}},"commit":{"parents":[{"commit":"f985b87197d1d838561cf7abd2526e63b1f69f40","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-log_processor/commit/f985b87197d1d838561cf7abd2526e63b1f69f40"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-08-19 02:23:38.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-08-19 02:49:12.000000000","tz":600},"subject":"log-gearman-worker: handle deflate encoded values","message":"log-gearman-worker: handle deflate encoded values\n\nWe are now logging to swift, and so we have a range of remote\nend-points now.\n\nIt seems that RAX, at least, can send us back deflate encoded data\ndespite it currently not in the Accept-Encoding of the request.  This\nis probably a bug, but we can easily handle deflate anyway.\n\nChange-Id: I328bafea3ddae858fd77af043f16c499ddd5a30e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-log_processor/commit/a0d85c77ae964bd866a8028804390a5fc0b6a75f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-log_processor/commit/a0d85c77ae964bd866a8028804390a5fc0b6a75f"}]},"branch":"refs/heads/master"},"bca04e3155c7b7c5318618d79cacb4243461ddc2":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-08-19 03:07:19.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/04/677104/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-log_processor","ref":"refs/changes/04/677104/2","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-log_processor refs/changes/04/677104/2"}}},"commit":{"parents":[{"commit":"f985b87197d1d838561cf7abd2526e63b1f69f40","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-log_processor/commit/f985b87197d1d838561cf7abd2526e63b1f69f40"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-08-19 02:23:38.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2019-08-19 03:02:32.000000000","tz":600},"subject":"log-gearman-worker: handle deflate encoded values","message":"log-gearman-worker: handle deflate encoded values\n\nWe are now logging to swift and store the objects as deflate encoded\ndata [1].  This means that we get back \"Content-Encoding: deflate\"\ndata when downloading the logs (even despite us not accepting that).\n\nSo put in a path for deflate encoding to the extant code with zlib.\nFor completeness we also update our Accept-Encoding: header to show we\naccept deflate.\n\n[1] https://opendev.org/zuul/zuul-jobs/src/commit/60e75428758c14ab8d4f0827863841313ccdc763/roles/upload-logs-swift/library/zuul_swift_upload.py#L608\n\nChange-Id: I328bafea3ddae858fd77af043f16c499ddd5a30e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-log_processor/commit/bca04e3155c7b7c5318618d79cacb4243461ddc2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-log_processor/commit/bca04e3155c7b7c5318618d79cacb4243461ddc2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
