)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a07a778ca8adb9643add04f736a8dc83c0432cc9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"quickly fall behind as some log files generated in the gate have become"},{"line_number":11,"context_line":"larger. Currently, we download a full log file into memory and then"},{"line_number":12,"context_line":"emit it line-by-line to be received by a logstash listener. When log"},{"line_number":13,"context_line":"files are large (example: 40M) logstash gets bogged down processing"},{"line_number":14,"context_line":"them."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Instead of downloading full files into memory, we can stream the files"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f65232a_2a953de5","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":39},"updated":"2020-10-23 17:56:40.000000000","message":"Should have probably said indexer here","commit_id":"06d3cb4c80863939248fd111b4e63fa0dadd65bc"}],"files/log-gearman-worker.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d2d1c087f4109a390aba02bb91d6ac0e446576a8","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        # encodings."},{"line_number":300,"context_line":"        # https://requests.readthedocs.io/en/master/user/quickstart/#raw-response-content"},{"line_number":301,"context_line":"        for line in file_obj.iter_lines(chunk_size, decode_unicode\u003dTrue):"},{"line_number":302,"context_line":"            yield line"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _open_log_file_url(self, source_url):"},{"line_number":305,"context_line":"        file_obj \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_aaa2ed98","line":302,"updated":"2020-10-23 17:35:09.000000000","message":"Note: I was unsure whether to add a try-except around this to similarly catch and log 404 and other exceptions (like L314).","commit_id":"06d3cb4c80863939248fd111b4e63fa0dadd65bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"be849550304c1d7083c1fd2eb624abde0ae2dfd7","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        # encodings."},{"line_number":300,"context_line":"        # https://requests.readthedocs.io/en/master/user/quickstart/#raw-response-content"},{"line_number":301,"context_line":"        for line in file_obj.iter_lines(chunk_size, decode_unicode\u003dTrue):"},{"line_number":302,"context_line":"            yield line"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _open_log_file_url(self, source_url):"},{"line_number":305,"context_line":"        file_obj \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_2a79bdfb","line":302,"in_reply_to":"3f65232a_aaa2ed98","updated":"2020-10-23 17:46:03.000000000","message":"I should have elaborated more. I was thinking should we just assume if we didn\u0027t hit a HTTPError or other error when we did the first read at L312, that things are likely \"OK\"?\n\nOr we could be more comprehensive and try-except here too.","commit_id":"06d3cb4c80863939248fd111b4e63fa0dadd65bc"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3a2816da829e6d634dd5cb79dc19f48936a65f95","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import requests"},{"line_number":26,"context_line":"import select"},{"line_number":27,"context_line":"import socket"},{"line_number":28,"context_line":"import StringIO"},{"line_number":29,"context_line":"import subprocess"},{"line_number":30,"context_line":"import sys"},{"line_number":31,"context_line":"import threading"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_39d635c7","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":6},"updated":"2020-10-24 07:16:57.000000000","message":"Blarg, this is actually unused. Residue from an earlier local version","commit_id":"29deb29a26860f434da61ea79a7db42ea5aa2a8b"}]}