)]}'
{"files/logs/help/tempest-logs.html":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"14584b308748c966c01f3a7b06eba95176d845a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a6ced46_ce4449b9","updated":"2015-03-25 17:50:59.000000000","message":"Note that jhesketh has some changes to move these help/guide files into devstack-gate proper. Which is a much better home for them considering they are devstack(-gate) specific. Its fine to copy these here in the interim but you will likely want to remove them at some point in the near future.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"}],"files/logs/help/tempest-overview.html":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"14584b308748c966c01f3a7b06eba95176d845a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a6ced46_0e33c163","updated":"2015-03-25 17:50:59.000000000","message":"See comment on tempest-logs.html.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"}],"manifests/logserver.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"14584b308748c966c01f3a7b06eba95176d845a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: openstack_project::static"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstackci::logserver ("},{"line_number":4,"context_line":"  $domain,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_2e34fd48","line":1,"updated":"2015-03-25 17:50:59.000000000","message":"This comment isn\u0027t correct, should be updated for code reader sanity.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"65944fe28241971f96df32420c6b7d5171c089bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: openstack_project::static"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstackci::logserver ("},{"line_number":4,"context_line":"  $domain,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_19f22906","line":1,"in_reply_to":"1a6ced46_2e34fd48","updated":"2015-03-25 18:15:27.000000000","message":"Done","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3aa3766d25a5ec58f43ec0afb10f62b2c64649dd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  if ! defined(Class[\u0027jenkins::jenkinsuser\u0027]) {"},{"line_number":15,"context_line":"    class { \u0027jenkins::jenkinsuser\u0027:"},{"line_number":16,"context_line":"      ssh_key \u003d\u003e $jenkins_ssh_key,"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include apache"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_ff960d3e","line":17,"updated":"2015-03-25 19:00:13.000000000","message":"Because you are using the jenkins module when you instantiate the jenkins::jenkinsuser class. Its mostly about book keeping so that users of this module know what they need to install (and in theory if using a tool like puppet module it will install the dependency for them).","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"14584b308748c966c01f3a7b06eba95176d845a8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  if ! defined(Class[\u0027jenkins::jenkinsuser\u0027]) {"},{"line_number":15,"context_line":"    class { \u0027jenkins::jenkinsuser\u0027:"},{"line_number":16,"context_line":"      ssh_key \u003d\u003e $jenkins_ssh_key,"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include apache"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_4e393940","line":17,"updated":"2015-03-25 17:50:59.000000000","message":"You should add openstack-infra/puppet-jenkins to the dependency list of this module.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"65944fe28241971f96df32420c6b7d5171c089bb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  if ! defined(Class[\u0027jenkins::jenkinsuser\u0027]) {"},{"line_number":15,"context_line":"    class { \u0027jenkins::jenkinsuser\u0027:"},{"line_number":16,"context_line":"      ssh_key \u003d\u003e $jenkins_ssh_key,"},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include apache"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_19986969","line":17,"in_reply_to":"1a6ced46_4e393940","updated":"2015-03-25 18:15:27.000000000","message":"Why\u0027s that?","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"14584b308748c966c01f3a7b06eba95176d845a8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include apache"},{"line_number":21,"context_line":"  include apache::mod::wsgi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  if ! defined(A2mod[\u0027rewrite\u0027]) {"},{"line_number":24,"context_line":"    a2mod { \u0027rewrite\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_6e4195a8","line":21,"updated":"2015-03-25 17:50:59.000000000","message":"And add apache dependency.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"3aa3766d25a5ec58f43ec0afb10f62b2c64649dd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include apache"},{"line_number":21,"context_line":"  include apache::mod::wsgi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  if ! defined(A2mod[\u0027rewrite\u0027]) {"},{"line_number":24,"context_line":"    a2mod { \u0027rewrite\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_1f984969","line":21,"updated":"2015-03-25 19:00:13.000000000","message":"Sorry, you should add the puppetlabs-apache module as a dependency of this module.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"65944fe28241971f96df32420c6b7d5171c089bb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include apache"},{"line_number":21,"context_line":"  include apache::mod::wsgi"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  if ! defined(A2mod[\u0027rewrite\u0027]) {"},{"line_number":24,"context_line":"    a2mod { \u0027rewrite\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_59974148","line":21,"in_reply_to":"1a6ced46_6e4195a8","updated":"2015-03-25 18:15:27.000000000","message":"Doesn\u0027t \"include apache\" already do that?","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"14584b308748c966c01f3a7b06eba95176d845a8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  exec { \u0027install_os-loganalyze\u0027:"},{"line_number":93,"context_line":"    command     \u003d\u003e \u0027python setup.py install\u0027,"},{"line_number":94,"context_line":"    cwd         \u003d\u003e \u0027/opt/os-loganalyze\u0027,"},{"line_number":95,"context_line":"    path        \u003d\u003e \u0027/bin:/usr/bin\u0027,"},{"line_number":96,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_8e3ed126","line":93,"updated":"2015-03-25 17:50:59.000000000","message":"I noticed that this does a setup.py install instead of a pip install. We should probably fix that here and in system-config. Or maybe just fix it here then have system-config use this module.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"65944fe28241971f96df32420c6b7d5171c089bb","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  }"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"  exec { \u0027install_os-loganalyze\u0027:"},{"line_number":93,"context_line":"    command     \u003d\u003e \u0027python setup.py install\u0027,"},{"line_number":94,"context_line":"    cwd         \u003d\u003e \u0027/opt/os-loganalyze\u0027,"},{"line_number":95,"context_line":"    path        \u003d\u003e \u0027/bin:/usr/bin\u0027,"},{"line_number":96,"context_line":"    refreshonly \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_f9d70d49","line":93,"in_reply_to":"1a6ced46_8e3ed126","updated":"2015-03-25 18:15:27.000000000","message":"Done","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"14584b308748c966c01f3a7b06eba95176d845a8","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    mode    \u003d\u003e \u00270755\u0027,"},{"line_number":125,"context_line":"    source  \u003d\u003e \u0027puppet:///modules/openstack_project/logs/help\u0027,"},{"line_number":126,"context_line":"    require \u003d\u003e File[\u0027/srv/static/logs\u0027],"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  file { \u0027/usr/local/sbin/log_archive_maintenance.sh\u0027:"},{"line_number":130,"context_line":"    ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_ae470dbb","line":127,"updated":"2015-03-25 17:50:59.000000000","message":"If you remove the two html files then this file resource isn\u0027t necessary.","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"65944fe28241971f96df32420c6b7d5171c089bb","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    mode    \u003d\u003e \u00270755\u0027,"},{"line_number":125,"context_line":"    source  \u003d\u003e \u0027puppet:///modules/openstack_project/logs/help\u0027,"},{"line_number":126,"context_line":"    require \u003d\u003e File[\u0027/srv/static/logs\u0027],"},{"line_number":127,"context_line":"  }"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"  file { \u0027/usr/local/sbin/log_archive_maintenance.sh\u0027:"},{"line_number":130,"context_line":"    ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6ced46_794a3d27","line":127,"in_reply_to":"1a6ced46_ae470dbb","updated":"2015-03-25 18:15:27.000000000","message":"Done","commit_id":"e4d69af7f0200a3cbb9b0652d415bd41c3931e14"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"298758a129f74cfee8f969f49a5730edb3d34a39","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    template \u003d\u003e \u0027openstackci/logs.vhost.erb\u0027,"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  apache::vhost { \"logs-dev.${domain}\":"},{"line_number":56,"context_line":"    port     \u003d\u003e 80,"},{"line_number":57,"context_line":"    priority \u003d\u003e \u002751\u0027,"},{"line_number":58,"context_line":"    docroot  \u003d\u003e \u0027/srv/static/logs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa963961_26824c95","line":55,"updated":"2015-03-27 18:53:48.000000000","message":"i\u0027m wondering if this should be optional?  other\u0027s might not care to set this up.","commit_id":"a650c7b2b98bb1a8d194e5acd88fc6c8973dd53e"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"d7c73fa069a0abb293c6028ebd8295b809351e48","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    template \u003d\u003e \u0027openstackci/logs.vhost.erb\u0027,"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  apache::vhost { \"logs-dev.${domain}\":"},{"line_number":56,"context_line":"    port     \u003d\u003e 80,"},{"line_number":57,"context_line":"    priority \u003d\u003e \u002751\u0027,"},{"line_number":58,"context_line":"    docroot  \u003d\u003e \u0027/srv/static/logs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa963961_29757cca","line":55,"in_reply_to":"fa963961_26824c95","updated":"2015-03-27 19:18:43.000000000","message":"Are you suggesting define a default domain? If so, which domain should be used?","commit_id":"a650c7b2b98bb1a8d194e5acd88fc6c8973dd53e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"d1bee66c4e2073de13ffc641beffc480f8f07e5d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    template \u003d\u003e \u0027openstackci/logs.vhost.erb\u0027,"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  apache::vhost { \"logs-dev.${domain}\":"},{"line_number":56,"context_line":"    port     \u003d\u003e 80,"},{"line_number":57,"context_line":"    priority \u003d\u003e \u002751\u0027,"},{"line_number":58,"context_line":"    docroot  \u003d\u003e \u0027/srv/static/logs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa963961_a7a093f5","line":55,"in_reply_to":"fa963961_29757cca","updated":"2015-03-27 20:04:24.000000000","message":"My question was was whether others would be interested in creating this dev-log folder?","commit_id":"a650c7b2b98bb1a8d194e5acd88fc6c8973dd53e"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"432057c45b7ad732427d790de4fc44906c6243ec","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    template \u003d\u003e \u0027openstackci/logs.vhost.erb\u0027,"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  apache::vhost { \"logs-dev.${domain}\":"},{"line_number":56,"context_line":"    port     \u003d\u003e 80,"},{"line_number":57,"context_line":"    priority \u003d\u003e \u002751\u0027,"},{"line_number":58,"context_line":"    docroot  \u003d\u003e \u0027/srv/static/logs\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa963961_e28d697c","line":55,"in_reply_to":"fa963961_a7a093f5","updated":"2015-03-27 20:36:02.000000000","message":"Ok I see. Honestly, as far as I can tell it doesn\u0027t break anything having it (my 2 production log servers are just fine with it). Unless there are other reasons to take it out (security, non-trivial resource consumption), I prefer to leave it in, and consider updating in a follow-up patch.","commit_id":"a650c7b2b98bb1a8d194e5acd88fc6c8973dd53e"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"7cdfc69025235832025edf291b84a57da4650fea","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  $swift_default_container \u003d \u0027\u0027,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! defined(Class[\u0027jenkins::jenkinsuser\u0027]) {"},{"line_number":30,"context_line":"    class { \u0027jenkins::jenkinsuser\u0027:"},{"line_number":31,"context_line":"      ssh_key \u003d\u003e $jenkins_ssh_key,"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bab921fb_ffcc65bc","line":29,"updated":"2015-04-25 23:47:27.000000000","message":"Lets use ::jenkins here because we\u0027ll almost certainly end up with an openstackci::jenkins","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"ee6554f7d4b4fb9fa71052bad35e66c8a9ff1401","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  $swift_default_container \u003d \u0027\u0027,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  if ! defined(Class[\u0027jenkins::jenkinsuser\u0027]) {"},{"line_number":30,"context_line":"    class { \u0027jenkins::jenkinsuser\u0027:"},{"line_number":31,"context_line":"      ssh_key \u003d\u003e $jenkins_ssh_key,"},{"line_number":32,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3acd31a7_a87dcab2","line":29,"in_reply_to":"bab921fb_ffcc65bc","updated":"2015-05-04 18:38:35.000000000","message":"Can you do this though?","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"7cdfc69025235832025edf291b84a57da4650fea","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  include apache"},{"line_number":36,"context_line":"  include apache::mod::wsgi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if ! defined(A2mod[\u0027rewrite\u0027]) {"},{"line_number":39,"context_line":"    a2mod { \u0027rewrite\u0027:"},{"line_number":40,"context_line":"      ensure \u003d\u003e present,"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bab921fb_dfc64199","line":38,"updated":"2015-04-25 23:47:27.000000000","message":"Opportuny to switch to openstackinfra-httpd ?","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"ee6554f7d4b4fb9fa71052bad35e66c8a9ff1401","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  include apache"},{"line_number":36,"context_line":"  include apache::mod::wsgi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if ! defined(A2mod[\u0027rewrite\u0027]) {"},{"line_number":39,"context_line":"    a2mod { \u0027rewrite\u0027:"},{"line_number":40,"context_line":"      ensure \u003d\u003e present,"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3acd31a7_e873c2e5","line":38,"in_reply_to":"bab921fb_80e3c5a3","updated":"2015-05-04 18:38:35.000000000","message":"Totally valid.","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"f6fb63282fa7bcfdc485d114ebfbbae16607be3b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  include apache"},{"line_number":36,"context_line":"  include apache::mod::wsgi"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if ! defined(A2mod[\u0027rewrite\u0027]) {"},{"line_number":39,"context_line":"    a2mod { \u0027rewrite\u0027:"},{"line_number":40,"context_line":"      ensure \u003d\u003e present,"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bab921fb_80e3c5a3","line":38,"in_reply_to":"bab921fb_dfc64199","updated":"2015-04-26 18:03:03.000000000","message":"I prefer to do as a follow-on-patch","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"}],"metadata.json":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b14e6ced231500bea5ade7244f3ab3ae3f03ebcb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  \"dependencies\": ["},{"line_number":11,"context_line":"    { \"name\": \"puppetlabs/apache\", \"version_requirement\": \"\u003d 0.0.4\" },"},{"line_number":12,"context_line":"    { \"name\": \"openstackci/vcsrepo\", \"version_requirement\": \"\u003d 0.0.8\" },"},{"line_number":13,"context_line":"    { \"name\": \"openstackinfra/puppet-jenkins\", \"version_requirement\": \"\u003d 0.0.1\" }"},{"line_number":14,"context_line":"  ]"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":6,"id":"baa041b7_7a9d5d58","line":13,"updated":"2015-04-03 19:27:05.000000000","message":"Thank you for adding these.","commit_id":"075d34251c68ed83e489cf8012d737f1ae96550c"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"0e1da43c386528d5284fb9f8b8a749c7d8db108b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  \"dependencies\": ["},{"line_number":11,"context_line":"    { \"name\": \"puppetlabs/apache\", \"version_requirement\": \"\u003d 0.0.4\" },"},{"line_number":12,"context_line":"    { \"name\": \"openstackci/vcsrepo\", \"version_requirement\": \"\u003d 0.0.8\" },"},{"line_number":13,"context_line":"    { \"name\": \"openstackinfra/puppet-jenkins\", \"version_requirement\": \"\u003d 0.0.1\" }"},{"line_number":14,"context_line":"  ]"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":8,"id":"7aaa499b_212ca8aa","line":13,"updated":"2015-04-10 16:39:08.000000000","message":"Just need openstackinfra/jenkins here, the puppet is implied","commit_id":"4d95a2160ecedcc1391f6fd8de356ae87551707f"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"7cdfc69025235832025edf291b84a57da4650fea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  \"dependencies\": ["},{"line_number":11,"context_line":"    { \"name\": \"puppetlabs/apache\", \"version_requirement\": \"\u003d 0.0.4\" },"},{"line_number":12,"context_line":"    { \"name\": \"openstackinfra/vcsrepo\", \"version_requirement\": \"\u003d 0.0.8\" },"},{"line_number":13,"context_line":"    { \"name\": \"openstackinfra/jenkins\", \"version_requirement\": \"\u003d 0.0.1\" }"},{"line_number":14,"context_line":"  ]"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"bab921fb_1fc839a7","line":13,"updated":"2015-04-25 23:47:27.000000000","message":"I don\u0027t think we should specify a version in metadata.json since rolling releases.","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"f6fb63282fa7bcfdc485d114ebfbbae16607be3b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  \"dependencies\": ["},{"line_number":11,"context_line":"    { \"name\": \"puppetlabs/apache\", \"version_requirement\": \"\u003d 0.0.4\" },"},{"line_number":12,"context_line":"    { \"name\": \"openstackinfra/vcsrepo\", \"version_requirement\": \"\u003d 0.0.8\" },"},{"line_number":13,"context_line":"    { \"name\": \"openstackinfra/jenkins\", \"version_requirement\": \"\u003d 0.0.1\" }"},{"line_number":14,"context_line":"  ]"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"bab921fb_60e0b196","line":13,"in_reply_to":"bab921fb_1fc839a7","updated":"2015-04-26 18:03:03.000000000","message":"So what should be set? empty string? \"\"","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"ee6554f7d4b4fb9fa71052bad35e66c8a9ff1401","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  \"dependencies\": ["},{"line_number":11,"context_line":"    { \"name\": \"puppetlabs/apache\", \"version_requirement\": \"\u003d 0.0.4\" },"},{"line_number":12,"context_line":"    { \"name\": \"openstackinfra/vcsrepo\", \"version_requirement\": \"\u003d 0.0.8\" },"},{"line_number":13,"context_line":"    { \"name\": \"openstackinfra/jenkins\", \"version_requirement\": \"\u003d 0.0.1\" }"},{"line_number":14,"context_line":"  ]"},{"line_number":15,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"3acd31a7_2871bae0","line":13,"in_reply_to":"bab921fb_60e0b196","updated":"2015-05-04 18:38:35.000000000","message":"You can just { \"name\": \"thing\" } No version req needed.","commit_id":"2c9abba5e8444f2c8808c30317a24113a1b61ca8"}]}
