)]}'
{"manifests/jenkins_master.pp":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"8c065ab6bfb128b4b49a11cf15540e190058584f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class openstackci::jenkins_master ("},{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027openstack.png\u0027,"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $ssl_key_file            \u003d \u0027\u0027,"},{"line_number":9,"context_line":"  $ssl_chain_file          \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab921fb_822e5e41","line":6,"updated":"2015-04-24 23:46:59.000000000","message":"This log does not exist in this repo.","commit_id":"e1292530c51f94f9709e95f0de2e6216d657f7d6"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"3a1b994a700a5323b44068f5581aa19987a69f2e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class openstackci::jenkins_master ("},{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027openstack.png\u0027,"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $ssl_key_file            \u003d \u0027\u0027,"},{"line_number":9,"context_line":"  $ssl_chain_file          \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7ad32947_47a7b14f","line":6,"in_reply_to":"bab921fb_822e5e41","updated":"2015-04-27 19:59:12.000000000","message":"I removed the default and put a comment about it. Thanks!","commit_id":"e1292530c51f94f9709e95f0de2e6216d657f7d6"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"613460c7ece1664495f1fa2be22d72fd9c630de6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    jenkins_ssh_public_key  \u003d\u003e $jenkins_ssh_public_key,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  jenkins::plugin { \u0027build-timeout\u0027:"},{"line_number":46,"context_line":"    version \u003d\u003e \u00271.14\u0027,"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":"  jenkins::plugin { \u0027copyartifact\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab921fb_a1a94f92","line":45,"updated":"2015-04-25 07:09:05.000000000","message":"for future changes, that list of plugins should be parameterized","commit_id":"e1292530c51f94f9709e95f0de2e6216d657f7d6"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"3a1b994a700a5323b44068f5581aa19987a69f2e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    jenkins_ssh_public_key  \u003d\u003e $jenkins_ssh_public_key,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  jenkins::plugin { \u0027build-timeout\u0027:"},{"line_number":46,"context_line":"    version \u003d\u003e \u00271.14\u0027,"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":"  jenkins::plugin { \u0027copyartifact\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7ad32947_076899f4","line":45,"in_reply_to":"bab921fb_a1a94f92","updated":"2015-04-27 19:59:12.000000000","message":"not sure how to do that properly now...","commit_id":"e1292530c51f94f9709e95f0de2e6216d657f7d6"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"8a6e0e2c37e3e5994c0ec08ae227d82eb86e8a46","unresolved":false,"context_lines":[{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":"  # Set defaults here because they evaluate variables which you cannot"},{"line_number":17,"context_line":"  # do in the class parameter list."},{"line_number":18,"context_line":"  if $ssl_cert_file \u003d\u003d \u0027\u0027 {"},{"line_number":19,"context_line":"    $prv_ssl_cert_file \u003d \"/etc/ssl/certs/${vhost_name}.pem\""},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5ad0253b_db8950cc","line":18,"updated":"2015-04-29 08:27:19.000000000","message":"This seems like a logical time to add logic to fallback to snakeoil.pem if no explicit data is passed in","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"0468616e34acefe7ce306be0e2b25193fdba962f","unresolved":false,"context_lines":[{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":"  # Set defaults here because they evaluate variables which you cannot"},{"line_number":17,"context_line":"  # do in the class parameter list."},{"line_number":18,"context_line":"  if $ssl_cert_file \u003d\u003d \u0027\u0027 {"},{"line_number":19,"context_line":"    $prv_ssl_cert_file \u003d \"/etc/ssl/certs/${vhost_name}.pem\""},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1aca2d91_cab93c7b","line":18,"in_reply_to":"3acd31a7_0e62aaad","updated":"2015-05-07 20:43:24.000000000","message":"Alright, so I removed the prv_ssl variables and used snakeoil in the class parameter like in puppet-gerrit.","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"bbe22b037e69e04dc643c7f5ca9d8c9cfcba0631","unresolved":false,"context_lines":[{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":"  # Set defaults here because they evaluate variables which you cannot"},{"line_number":17,"context_line":"  # do in the class parameter list."},{"line_number":18,"context_line":"  if $ssl_cert_file \u003d\u003d \u0027\u0027 {"},{"line_number":19,"context_line":"    $prv_ssl_cert_file \u003d \"/etc/ssl/certs/${vhost_name}.pem\""},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3acd31a7_d85b58f5","line":18,"in_reply_to":"3acd31a7_3e48465b","updated":"2015-05-01 22:12:18.000000000","message":"Yes, I updated the two to use that and it worked for me.","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"c8d8cc13859a63784e5662833eb8d141088267a5","unresolved":false,"context_lines":[{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":"  # Set defaults here because they evaluate variables which you cannot"},{"line_number":17,"context_line":"  # do in the class parameter list."},{"line_number":18,"context_line":"  if $ssl_cert_file \u003d\u003d \u0027\u0027 {"},{"line_number":19,"context_line":"    $prv_ssl_cert_file \u003d \"/etc/ssl/certs/${vhost_name}.pem\""},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3acd31a7_0e62aaad","line":18,"in_reply_to":"3acd31a7_d85b58f5","updated":"2015-05-01 23:48:58.000000000","message":"Also, since these snakeoil certs are \u0027hardcoded\u0027, they can be used a defaults in the class parameter list.","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"437f87fbee975507eab8d12db1c45c7b0dcdbf14","unresolved":false,"context_lines":[{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":"  # Set defaults here because they evaluate variables which you cannot"},{"line_number":17,"context_line":"  # do in the class parameter list."},{"line_number":18,"context_line":"  if $ssl_cert_file \u003d\u003d \u0027\u0027 {"},{"line_number":19,"context_line":"    $prv_ssl_cert_file \u003d \"/etc/ssl/certs/${vhost_name}.pem\""},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":"  else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3acd31a7_3e48465b","line":18,"in_reply_to":"5ad0253b_db8950cc","updated":"2015-04-29 16:36:18.000000000","message":"Not sure how to do without breaking anything... Just pointing to /etc/ssl/certs/ssl-cert-snakeoil.{pem,key} enough ?","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"bbe22b037e69e04dc643c7f5ca9d8c9cfcba0631","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    jenkins_ssh_public_key  \u003d\u003e $jenkins_ssh_public_key,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  jenkins::plugin { \u0027build-timeout\u0027:"},{"line_number":46,"context_line":"    version \u003d\u003e \u00271.14\u0027,"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":"  jenkins::plugin { \u0027copyartifact\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3acd31a7_18a550b4","line":45,"updated":"2015-05-01 22:12:18.000000000","message":"Note: None of these plugins don\u0027t get installed until after jenkins is restarted. We can add that in a follow-on patch.","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"8a6e0e2c37e3e5994c0ec08ae227d82eb86e8a46","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    version \u003d\u003e \u00271.5.1\u0027,"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  file { \u0027/etc/default/jenkins\u0027:"},{"line_number":105,"context_line":"    ensure \u003d\u003e present,"},{"line_number":106,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":107,"context_line":"    group  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5ad0253b_bb8694b7","line":104,"updated":"2015-04-29 08:27:19.000000000","message":"This file should be pushed into the jenkins module","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"437f87fbee975507eab8d12db1c45c7b0dcdbf14","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    version \u003d\u003e \u00271.5.1\u0027,"},{"line_number":102,"context_line":"  }"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  file { \u0027/etc/default/jenkins\u0027:"},{"line_number":105,"context_line":"    ensure \u003d\u003e present,"},{"line_number":106,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":107,"context_line":"    group  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3acd31a7_1e822a53","line":104,"in_reply_to":"5ad0253b_bb8694b7","updated":"2015-04-29 16:36:18.000000000","message":"Proposed here: https://review.openstack.org/#/c/178749/","commit_id":"9a440dc3d872b78ffeec3384638418434d0afa5f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c0748e6c4ba36c59a6a3b81d1b8a701a002e7f21","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class openstackci::jenkins_master ("},{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027\u0027, # Logo must be present in puppet-jenkins/files"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027/etc/ssl/certs/ssl-cert-snakeoil.pem\u0027,"},{"line_number":8,"context_line":"  $ssl_key_file            \u003d \u0027/etc/ssl/private/ssl-cert-snakeoil.key\u0027,"},{"line_number":9,"context_line":"  $ssl_chain_file          \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aca2d91_25ea2310","line":6,"updated":"2015-05-07 20:51:42.000000000","message":"In Puppet, we don\u0027t use to set \u0027\u0027, but we use undef:\nhttps://docs.puppetlabs.com/puppet/latest/reference/lang_datatypes.html#undef","commit_id":"26451dff11c0945c1c306e512b12fdf55f9dc588"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c0748e6c4ba36c59a6a3b81d1b8a701a002e7f21","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    jenkins_ssh_public_key  \u003d\u003e $jenkins_ssh_public_key,"},{"line_number":29,"context_line":"  }"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  jenkins::plugin { \u0027build-timeout\u0027:"},{"line_number":32,"context_line":"    version \u003d\u003e \u00271.14\u0027,"},{"line_number":33,"context_line":"  }"},{"line_number":34,"context_line":"  jenkins::plugin { \u0027copyartifact\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aca2d91_053ba79d","line":31,"updated":"2015-05-07 20:51:42.000000000","message":"to follow Puppet 4 conventions, you may want to use ::jenkins::plugin { ... }","commit_id":"26451dff11c0945c1c306e512b12fdf55f9dc588"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"5dfec33d309ebe18c58e7207d65dbf16451ed14d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027\u0027, # Logo must be present in puppet-jenkins/files"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027/etc/ssl/certs/ssl-cert-snakeoil.pem\u0027,"},{"line_number":8,"context_line":"  $ssl_key_file            \u003d \u0027/etc/ssl/private/ssl-cert-snakeoil.key\u0027,"},{"line_number":9,"context_line":"  $ssl_chain_file          \u003d \u0027\u0027,"},{"line_number":10,"context_line":"  $ssl_cert_file_contents  \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a016987_b9594090","line":7,"updated":"2015-05-21 23:34:28.000000000","message":"To be consistent with the old system-config, I think you need to check if these are set. See my comment in:\n\nhttps://review.openstack.org/#/c/177373/6/modules/openstack_project/manifests/jenkins.pp","commit_id":"4c8102dcecdec56d1bbac12207a040ad14e28049"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"36d549c1b9cb0994b30395f0e7cf87c1bcccc270","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027\u0027, # Logo must be present in puppet-jenkins/files"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027/etc/ssl/certs/ssl-cert-snakeoil.pem\u0027,"},{"line_number":8,"context_line":"  $ssl_key_file            \u003d \u0027/etc/ssl/private/ssl-cert-snakeoil.key\u0027,"},{"line_number":9,"context_line":"  $ssl_chain_file          \u003d \u0027\u0027,"},{"line_number":10,"context_line":"  $ssl_cert_file_contents  \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3afb71cf_f0f3a99c","line":7,"in_reply_to":"3afb71cf_f01e0962","updated":"2015-06-08 19:00:19.000000000","message":"These values are populated here: https://git.openstack.org/cgit/openstack-infra/system-config/tree/manifests/site.pp#n126\n\nThe defaults are \"XXX\", so it is not an empty string, so they get overridden and will get used below.\n\nAll that said, i\u0027m fine with putting it back, and making this \u0027simplification\u0027 as a separate patch....","commit_id":"4c8102dcecdec56d1bbac12207a040ad14e28049"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"19601d7cc7bc78275152d8987235d6bae81619d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027\u0027, # Logo must be present in puppet-jenkins/files"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027/etc/ssl/certs/ssl-cert-snakeoil.pem\u0027,"},{"line_number":8,"context_line":"  $ssl_key_file            \u003d \u0027/etc/ssl/private/ssl-cert-snakeoil.key\u0027,"},{"line_number":9,"context_line":"  $ssl_chain_file          \u003d \u0027\u0027,"},{"line_number":10,"context_line":"  $ssl_cert_file_contents  \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3afb71cf_f01e0962","line":7,"in_reply_to":"7a016987_b9594090","updated":"2015-06-08 18:43:00.000000000","message":"I think Joshua is right, the \u0027jenkins.openstack.org\u0027 node definition in system-config/manifest/site.pp does not set the ssl_cert_file.\n\nPlease advise what to do since these checks were already proposed previously here: https://review.openstack.org/#/c/175571/3/manifests/jenkins_master.pp\n\nLet me know if we should bring them back...","commit_id":"4c8102dcecdec56d1bbac12207a040ad14e28049"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"9d1b008116241c807d0dd2ba553835570eb0c2ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027\u0027, # Logo must be present in puppet-jenkins/files"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027/etc/ssl/certs/ssl-cert-snakeoil.pem\u0027,"},{"line_number":8,"context_line":"  $ssl_key_file            \u003d \u0027/etc/ssl/private/ssl-cert-snakeoil.key\u0027,"},{"line_number":9,"context_line":"  $ssl_chain_file          \u003d \u0027\u0027,"},{"line_number":10,"context_line":"  $ssl_cert_file_contents  \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a016987_d4bcc1bc","line":7,"in_reply_to":"7a016987_b9594090","updated":"2015-05-22 00:15:46.000000000","message":"These are just providing default values, and simplifies the script.","commit_id":"4c8102dcecdec56d1bbac12207a040ad14e28049"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"43e71c7f9380fea4dfec62826f31bb4ef50942d7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    version \u003d\u003e \u00270.0.3\u0027,"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":"#  TODO(jeblair): release"},{"line_number":56,"context_line":"#  jenkins::plugin { \u0027scp\u0027:"},{"line_number":57,"context_line":"#    version \u003d\u003e \u00271.9\u0027,"},{"line_number":58,"context_line":"#  }"},{"line_number":59,"context_line":"  jenkins::plugin { \u0027jobConfigHistory\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a016987_fe52fe33","line":56,"updated":"2015-05-21 23:20:56.000000000","message":"wish there was a newer version of this in maven-central. Wondering if it would be beneficial to comment that 3rd party will need to manually install this on their Jenkins?","commit_id":"4c8102dcecdec56d1bbac12207a040ad14e28049"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"9d1b008116241c807d0dd2ba553835570eb0c2ee","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    version \u003d\u003e \u00270.0.3\u0027,"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":"#  TODO(jeblair): release"},{"line_number":56,"context_line":"#  jenkins::plugin { \u0027scp\u0027:"},{"line_number":57,"context_line":"#    version \u003d\u003e \u00271.9\u0027,"},{"line_number":58,"context_line":"#  }"},{"line_number":59,"context_line":"  jenkins::plugin { \u0027jobConfigHistory\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"7a016987_54c9f157","line":56,"in_reply_to":"7a016987_fe52fe33","updated":"2015-05-22 00:15:46.000000000","message":"Better yet, install it from http://tarballs.openstack.org/ci/, but that should be in a follow-on patch set.","commit_id":"4c8102dcecdec56d1bbac12207a040ad14e28049"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"a168c0af3b281f4bcb28f7be03344e8f0f239237","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: openstackci::jenkins_master"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstackci::jenkins_master ("},{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":6,"context_line":"  $logo                    \u003d \u0027\u0027, # Logo must be present in puppet-jenkins/files"},{"line_number":7,"context_line":"  $ssl_cert_file           \u003d \u0027/etc/ssl/certs/ssl-cert-snakeoil.pem\u0027,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3afb71cf_ea56d55a","line":4,"updated":"2015-06-10 00:45:29.000000000","message":"Would be nice to set a default here: \"webmaster@${::fqdn}\".","commit_id":"9e618503c55a2375753185e7bca1655be7eb9c46"}],"test/test_jenkinsmaster.sh":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"c3c685672866fd83cf4e5432e6c81818f0948e60","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#! /usr/bin/env bash"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2015 Hewlett-Packard Development Company, L.P."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":4,"id":"1aca2d91_c5aecf97","line":1,"updated":"2015-05-07 21:05:53.000000000","message":"Not sure if we\u0027re ready to include these tests yet....you may want to make it a dependent patch. It would make this patch easily to merge.","commit_id":"26451dff11c0945c1c306e512b12fdf55f9dc588"}]}
