)]}'
{"spec/acceptance/basic_nova_spec.rb":[{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"703037432df64107a466288e45432b6b7c7a7b93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper_acceptance\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027basic nova\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  context \u0027default parameters\u0027 do"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_7e9bae66","line":3,"updated":"2015-05-21 22:46:02.000000000","message":"This seems like a mistake.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b06eeef4f407e87563dc5b0e7da84449d22596b4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    it \u0027should work with no errors\u0027 do"},{"line_number":8,"context_line":"      pp\u003d \u003c\u003c-EOS"},{"line_number":9,"context_line":"        include openstackci::logserver"},{"line_number":10,"context_line":"        class { \u0027::openstackci::logserver\u0027:"},{"line_number":11,"context_line":"           domain \u003d\u003e \u0027foo\u0027,"},{"line_number":12,"context_line":"           jenkins_ssh_key \u003d\u003e \u0027foo\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_5ea7d2a9","line":9,"updated":"2015-05-21 22:43:39.000000000","message":"We should not inline any fixtures particularly since there is expressed desire to run these tests possibly without beaker.\n\nIts generally good test hygiene too.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"124fe41c6bf50099c263817456461ee50e053cf6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    it \u0027should work with no errors\u0027 do"},{"line_number":8,"context_line":"      pp\u003d \u003c\u003c-EOS"},{"line_number":9,"context_line":"        include openstackci::logserver"},{"line_number":10,"context_line":"        class { \u0027::openstackci::logserver\u0027:"},{"line_number":11,"context_line":"           domain \u003d\u003e \u0027foo\u0027,"},{"line_number":12,"context_line":"           jenkins_ssh_key \u003d\u003e \u0027foo\u0027,"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_3e8896c4","line":9,"in_reply_to":"7a016987_5ea7d2a9","updated":"2015-05-21 22:56:12.000000000","message":"I think we should do it this way to start. When we set up the ansible-appy tests we can figure out how to abstract these out then.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":11610,"name":"Timothy R. Chavez","email":"timrchavez@us.ibm.com","username":"timrchavez"},"change_message_id":"703037432df64107a466288e45432b6b7c7a7b93","unresolved":false,"context_lines":[{"line_number":16,"context_line":"           swift_tenant_name \u003d\u003e \u0027\u0027,"},{"line_number":17,"context_line":"           swift_region_name \u003d\u003e \u0027\u0027,"},{"line_number":18,"context_line":"           swift_default_container \u003d\u003e \u0027\u0027,"},{"line_number":19,"context_line":"        }"},{"line_number":20,"context_line":"      EOS"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_7eb28ee6","line":19,"updated":"2015-05-21 22:46:02.000000000","message":"I think the first / boiler plate test should be with no parameters passed to see what the defaults do.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"124fe41c6bf50099c263817456461ee50e053cf6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"           swift_tenant_name \u003d\u003e \u0027\u0027,"},{"line_number":17,"context_line":"           swift_region_name \u003d\u003e \u0027\u0027,"},{"line_number":18,"context_line":"           swift_default_container \u003d\u003e \u0027\u0027,"},{"line_number":19,"context_line":"        }"},{"line_number":20,"context_line":"      EOS"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_1e939afb","line":19,"in_reply_to":"7a016987_7eb28ee6","updated":"2015-05-21 22:56:12.000000000","message":"Fair. Domain is a required parameter however.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"}],"spec/acceptance/basic_spec.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"538936e3ae078142e6dd4753647e45750c25c4cc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"      pp_path \u003d File.join(base_path, \u0027fixtures\u0027, \u0027default.pp\u0027)"},{"line_number":11,"context_line":"      f \u003d File.open(pp_path)"},{"line_number":12,"context_line":"      pp \u003d f.read"},{"line_number":13,"context_line":"      f.close"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      # Run it twice and test for idempotency"},{"line_number":16,"context_line":"      apply_manifest(pp, :catch_failures \u003d\u003e true)"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7a016987_3208342d","line":13,"updated":"2015-05-27 23:18:58.000000000","message":"Could replace these three lines with File.read(pp_path)\n\nhttp://ruby-doc.org/core-2.0.0/IO.html#method-c-read","commit_id":"26bfb8fe6384b2e9e8c004c997e47f41bff03a8d"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"24e75d809415f8076b555da5dcd386bd07d4e0a6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"      base_path \u003d File.dirname(__FILE__)"},{"line_number":10,"context_line":"      pp_path \u003d File.join(base_path, \u0027fixtures\u0027, \u0027default.pp\u0027)"},{"line_number":11,"context_line":"      pp \u003d read(pp_path)"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      # Run it twice and test for idempotency"},{"line_number":14,"context_line":"      apply_manifest(pp, :catch_failures \u003d\u003e true)"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"5afe65bd_f4030675","line":11,"updated":"2015-06-01 17:35:00.000000000","message":"read isn\u0027t being found. I think it should be `File.read()`","commit_id":"aaf32bcbbf2bcbc2cd41f160d742645bc90f9745"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"24e75d809415f8076b555da5dcd386bd07d4e0a6","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    describe port(80) do"},{"line_number":19,"context_line":"      it { is_expected.to be_listening.with(\u0027tcp\u0027) }"},{"line_number":20,"context_line":"    end"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"5afe65bd_b4e6aee6","line":20,"updated":"2015-06-01 17:35:00.000000000","message":"This test is failing for some reason. The suggestion was to remove it to get the job green \u0026 voting, then work on adding more tests.","commit_id":"aaf32bcbbf2bcbc2cd41f160d742645bc90f9745"}],"spec/acceptance/nodesets/nodepool-centos7.yml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b06eeef4f407e87563dc5b0e7da84449d22596b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"HOSTS:"},{"line_number":2,"context_line":"  centos-70-x64:"},{"line_number":3,"context_line":"    roles:"},{"line_number":4,"context_line":"      - master"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a016987_3e7bf629","line":1,"updated":"2015-05-21 22:43:39.000000000","message":"We don\u0027t have a vagrant version of centos7 is that intentional? we do have that for trusty.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"}],"spec/acceptance/nodesets/ubuntu-server-1404-x64.yml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b06eeef4f407e87563dc5b0e7da84449d22596b4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"HOSTS:"},{"line_number":2,"context_line":"  ubuntu-server-1404-x64:"},{"line_number":3,"context_line":"    roles:"},{"line_number":4,"context_line":"      - master"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a016987_3e941641","line":1,"updated":"2015-05-21 22:43:39.000000000","message":"This appaers to be a duplicate of default. Can we reduce to one file (default)?","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"}],"spec/spec_helper_acceptance.rb":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b06eeef4f407e87563dc5b0e7da84449d22596b4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      shell(\u0027rm -fr /etc/puppet/modules/*\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      # install library modules from the forge"},{"line_number":29,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027puppetlabs-apache\u0027, \u0027--version\u0027, \u00270.0.4\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"      # install puppet modules from git, use master, TODO: zuul-cloner this"},{"line_number":32,"context_line":"      shell(\u0027git clone https://git.openstack.org/openstack-infra/puppet-jenkins /etc/puppet/modules/jenkins\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_3ee65615","line":29,"updated":"2015-05-21 22:43:39.000000000","message":"No puppet module installs at all. We stopped doing that because it doesn\u0027t result in enough control of the installed modules and they fail to install in weird ways (basically all the problems we have had with pip :) ). We should git clone all the things.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c2c2ae6fdef60d159a849639ce116cd12f226d23","unresolved":false,"context_lines":[{"line_number":26,"context_line":"      shell(\u0027rm -fr /etc/puppet/modules/*\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      # install library modules from the forge"},{"line_number":29,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027puppetlabs-apache\u0027, \u0027--version\u0027, \u00270.0.4\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"      # install puppet modules from git, use master, TODO: zuul-cloner this"},{"line_number":32,"context_line":"      shell(\u0027git clone https://git.openstack.org/openstack-infra/puppet-jenkins /etc/puppet/modules/jenkins\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_f56726b5","line":29,"in_reply_to":"7a016987_3ee65615","updated":"2015-05-27 23:18:36.000000000","message":"Clark\u0027s comment was never addressed, did this get resolved offline?","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b06eeef4f407e87563dc5b0e7da84449d22596b4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      shell(\u0027git clone https://git.openstack.org/openstack-infra/puppet-vcsrepo /etc/puppet/modules/vcsrepo\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      # Install the module being tested"},{"line_number":36,"context_line":"      puppet_module_install(:source \u003d\u003e proj_root, :module_name \u003d\u003e \u0027openstackci\u0027)"},{"line_number":37,"context_line":"      # List modules installed to help with debugging"},{"line_number":38,"context_line":"      on hosts[0], puppet(\u0027module\u0027,\u0027list\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":39,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_bec00651","line":36,"updated":"2015-05-21 22:43:39.000000000","message":"See above.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"c2c2ae6fdef60d159a849639ce116cd12f226d23","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      shell(\u0027git clone https://git.openstack.org/openstack-infra/puppet-vcsrepo /etc/puppet/modules/vcsrepo\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"      # Install the module being tested"},{"line_number":36,"context_line":"      puppet_module_install(:source \u003d\u003e proj_root, :module_name \u003d\u003e \u0027openstackci\u0027)"},{"line_number":37,"context_line":"      # List modules installed to help with debugging"},{"line_number":38,"context_line":"      on hosts[0], puppet(\u0027module\u0027,\u0027list\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":39,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a016987_d55e6ae8","line":36,"in_reply_to":"7a016987_bec00651","updated":"2015-05-27 23:18:36.000000000","message":"This is just copying the current module into /etc/puppet/modules, not installing it from the forge.","commit_id":"d9add83a168c364043810078bc178e879ceec3eb"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"538936e3ae078142e6dd4753647e45750c25c4cc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      # Install the module being tested"},{"line_number":36,"context_line":"      puppet_module_install(:source \u003d\u003e proj_root, :module_name \u003d\u003e \u0027openstackci\u0027)"},{"line_number":37,"context_line":"      # List modules installed to help with debugging"},{"line_number":38,"context_line":"      on hosts[0], puppet(\u0027module\u0027,\u0027list\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"},{"line_number":39,"context_line":"    end"},{"line_number":40,"context_line":"  end"},{"line_number":41,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"7a016987_f58ba666","line":38,"updated":"2015-05-27 23:18:58.000000000","message":"This could just be \u0027on host\u0027","commit_id":"26bfb8fe6384b2e9e8c004c997e47f41bff03a8d"}]}