)]}'
{"manifests/nodepool.pp":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"b968c8fdf7af746e70c9fcc6721d82f6efca8184","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    statsd_host               \u003d\u003e $statsd_host,"},{"line_number":55,"context_line":"    image_log_document_root   \u003d\u003e $image_log_document_root,"},{"line_number":56,"context_line":"    enable_image_log_via_http \u003d\u003e $enable_image_log_via_http,"},{"line_number":57,"context_line":"    scripts_dir               \u003d\u003e $::project_config::nodepool_scripts_dir,"},{"line_number":58,"context_line":"    elements_dir              \u003d\u003e $::project_config::nodepool_elements_dir,"},{"line_number":59,"context_line":"    require                   \u003d\u003e $::project_config::config_dir,"},{"line_number":60,"context_line":"    logging_conf_template     \u003d\u003e $nodepool_logging_template,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a016987_69ecfaba","line":57,"updated":"2015-05-23 00:03:12.000000000","message":"interesting, so we are saying project_config is a hard dependency for this.","commit_id":"f56115e3b0c2f889dff0c5c2e454b7c0daab3ae7"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"b968c8fdf7af746e70c9fcc6721d82f6efca8184","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  file { \u0027/home/nodepool/.config\u0027:"},{"line_number":76,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":77,"context_line":"    owner   \u003d\u003e \u0027nodepool\u0027,"},{"line_number":78,"context_line":"    group   \u003d\u003e \u0027nodepool\u0027,"},{"line_number":79,"context_line":"    require \u003d\u003e ["},{"line_number":80,"context_line":"      User[\u0027nodepool\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a016987_49e01ecd","line":77,"updated":"2015-05-23 00:03:12.000000000","message":"issue with rockets","commit_id":"f56115e3b0c2f889dff0c5c2e454b7c0daab3ae7"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"de0fcfc38726a82e23af2d38be41e80c3234f0c4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  $mysql_password,"},{"line_number":21,"context_line":"  $yaml_path,"},{"line_number":22,"context_line":"  $oscc_clouds \u003d {},"},{"line_number":23,"context_line":"  $oscc_cache \u003d {},"},{"line_number":24,"context_line":"  $oscc_client \u003d {},"},{"line_number":25,"context_line":"  $nodepool_ssh_private_key \u003d \u0027\u0027,"},{"line_number":26,"context_line":"  $logging_template \u003d \u0027nodepool/nodepool.logging.conf.erb\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_a209c12c","line":23,"updated":"2015-07-09 22:38:17.000000000","message":"We should allow environment to pass through:\n$environment \u003d {},\nhttps://git.openstack.org/cgit/openstack-infra/puppet-nodepool/tree/manifests/init.pp#n30","commit_id":"6024875d1ec03f0288c50a5d8a12c1084766bd8b"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"738e7f569ab12a7e33131cd441f9b59b45b61904","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  $mysql_password,"},{"line_number":21,"context_line":"  $yaml_path,"},{"line_number":22,"context_line":"  $oscc_clouds \u003d {},"},{"line_number":23,"context_line":"  $oscc_cache \u003d {},"},{"line_number":24,"context_line":"  $oscc_client \u003d {},"},{"line_number":25,"context_line":"  $nodepool_ssh_private_key \u003d \u0027\u0027,"},{"line_number":26,"context_line":"  $logging_template \u003d \u0027nodepool/nodepool.logging.conf.erb\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_6c5080d5","line":23,"in_reply_to":"ba3cc151_a209c12c","updated":"2015-07-10 08:41:42.000000000","message":"Done","commit_id":"6024875d1ec03f0288c50a5d8a12c1084766bd8b"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"d5e45005413a3611d84588d7040b625aa16a017b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $project_config_repo \u003d \u0027\u0027,"},{"line_number":32,"context_line":"  $jenkins_masters \u003d [],"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  class { \u0027project_config\u0027:"},{"line_number":36,"context_line":"    url  \u003d\u003e $project_config_repo,"},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_2c892a6f","line":34,"updated":"2015-07-09 22:30:37.000000000","message":"Need to protect against duplicate project_config declarations:\n\nif ! defined(Class[\u0027project_config\u0027]) {","commit_id":"6024875d1ec03f0288c50a5d8a12c1084766bd8b"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"738e7f569ab12a7e33131cd441f9b59b45b61904","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  $project_config_repo \u003d \u0027\u0027,"},{"line_number":32,"context_line":"  $jenkins_masters \u003d [],"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  class { \u0027project_config\u0027:"},{"line_number":36,"context_line":"    url  \u003d\u003e $project_config_repo,"},{"line_number":37,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_4c533ce3","line":34,"in_reply_to":"ba3cc151_2c892a6f","updated":"2015-07-10 08:41:42.000000000","message":"Done","commit_id":"6024875d1ec03f0288c50a5d8a12c1084766bd8b"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"de0fcfc38726a82e23af2d38be41e80c3234f0c4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    statsd_host               \u003d\u003e $statsd_host,"},{"line_number":51,"context_line":"    image_log_document_root   \u003d\u003e $image_log_document_root,"},{"line_number":52,"context_line":"    enable_image_log_via_http \u003d\u003e $enable_image_log_via_http,"},{"line_number":53,"context_line":"    scripts_dir               \u003d\u003e $::project_config::nodepool_scripts_dir,"},{"line_number":54,"context_line":"    elements_dir              \u003d\u003e $::project_config::nodepool_elements_dir,"},{"line_number":55,"context_line":"    require                   \u003d\u003e $::project_config::config_dir,"},{"line_number":56,"context_line":"    logging_conf_template     \u003d\u003e $logging_template,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_6210994e","line":53,"updated":"2015-07-09 22:38:17.000000000","message":"passthrough environment","commit_id":"6024875d1ec03f0288c50a5d8a12c1084766bd8b"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"738e7f569ab12a7e33131cd441f9b59b45b61904","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    statsd_host               \u003d\u003e $statsd_host,"},{"line_number":51,"context_line":"    image_log_document_root   \u003d\u003e $image_log_document_root,"},{"line_number":52,"context_line":"    enable_image_log_via_http \u003d\u003e $enable_image_log_via_http,"},{"line_number":53,"context_line":"    scripts_dir               \u003d\u003e $::project_config::nodepool_scripts_dir,"},{"line_number":54,"context_line":"    elements_dir              \u003d\u003e $::project_config::nodepool_elements_dir,"},{"line_number":55,"context_line":"    require                   \u003d\u003e $::project_config::config_dir,"},{"line_number":56,"context_line":"    logging_conf_template     \u003d\u003e $logging_template,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_2c6118a9","line":53,"in_reply_to":"ba3cc151_6210994e","updated":"2015-07-10 08:41:42.000000000","message":"Done","commit_id":"6024875d1ec03f0288c50a5d8a12c1084766bd8b"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"6c87432ae0a8e286ff862291a05313861b6242ba","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  class { \u0027::os_client_config\u0027:"},{"line_number":42,"context_line":"    clouds \u003d\u003e $oscc_clouds,"},{"line_number":43,"context_line":"    cache  \u003d\u003e $oscc_cache,"},{"line_number":44,"context_line":"    client \u003d\u003e $oscc_client,"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  class { \u0027::nodepool\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_a632aaf0","line":44,"updated":"2015-07-22 00:31:57.000000000","message":"These defaults don\u0027t work for nodepool user:\n\n$target_user \u003d \u0027root\u0027,\n$config_group \u003d $::id,\n\nIOError: [Errno 13] Permission denied: \u0027/etc/openstack/clouds.yaml\u0027","commit_id":"e0e95582c8b12b75ca1d2e562784729a00447fe1"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"198912ece6f61d50b4e08c93e275a18e6b60ebbf","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  class { \u0027::os_client_config\u0027:"},{"line_number":42,"context_line":"    clouds \u003d\u003e $oscc_clouds,"},{"line_number":43,"context_line":"    cache  \u003d\u003e $oscc_cache,"},{"line_number":44,"context_line":"    client \u003d\u003e $oscc_client,"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  class { \u0027::nodepool\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_e56cfe36","line":44,"in_reply_to":"3a50d1a3_a585af07","updated":"2015-07-22 16:06:09.000000000","message":"puppet is run as root and completes successfully. \nRestarting nodepool (outside of puppet) fails because nodepool is run as nodepool user, and it doesn\u0027t have permissions to access this file, so it fails to start with that error message.","commit_id":"e0e95582c8b12b75ca1d2e562784729a00447fe1"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"acdad9abbe563f3a630551b100aeed4201600346","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  class { \u0027::os_client_config\u0027:"},{"line_number":42,"context_line":"    clouds \u003d\u003e $oscc_clouds,"},{"line_number":43,"context_line":"    cache  \u003d\u003e $oscc_cache,"},{"line_number":44,"context_line":"    client \u003d\u003e $oscc_client,"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  class { \u0027::nodepool\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3a50d1a3_a585af07","line":44,"in_reply_to":"3a50d1a3_a632aaf0","updated":"2015-07-22 09:33:59.000000000","message":"You are not running puppet as root? Under which user do you run?","commit_id":"e0e95582c8b12b75ca1d2e562784729a00447fe1"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"04d35bb688496d07af270769bc50b6862bdf544a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class openstackci::nodepool ("},{"line_number":19,"context_line":"  $mysql_root_password,"},{"line_number":20,"context_line":"  $mysql_password,"},{"line_number":21,"context_line":"  $yaml_path,"},{"line_number":22,"context_line":"  $oscc_clouds \u003d {},"},{"line_number":23,"context_line":"  $oscc_cache \u003d {},"},{"line_number":24,"context_line":"  $oscc_client \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_ad512338","line":21,"updated":"2015-08-19 23:51:41.000000000","message":"A good default would be: /etc/project-config/nodepool/nodepool.yaml","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"44359f60cde2e963b62d0c80d4954d2f25e547c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"class openstackci::nodepool ("},{"line_number":19,"context_line":"  $mysql_root_password,"},{"line_number":20,"context_line":"  $mysql_password,"},{"line_number":21,"context_line":"  $yaml_path,"},{"line_number":22,"context_line":"  $oscc_clouds \u003d {},"},{"line_number":23,"context_line":"  $oscc_cache \u003d {},"},{"line_number":24,"context_line":"  $oscc_client \u003d {},"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_c985fd07","line":21,"in_reply_to":"fa1b9901_ad512338","updated":"2015-08-21 17:30:28.000000000","message":"Done","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"b7e395ac98e63c640ead718bdf848c6019d8d30e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    clouds      \u003d\u003e $oscc_clouds,"},{"line_number":43,"context_line":"    cache       \u003d\u003e $oscc_cache,"},{"line_number":44,"context_line":"    client      \u003d\u003e $oscc_client,"},{"line_number":45,"context_line":"    target_user \u003d\u003e \u0027nodepool\u0027,"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  class { \u0027::nodepool\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a4dcd0f_846b9a84","line":45,"updated":"2015-08-13 22:25:56.000000000","message":"FYI: os_client is putting the files in a user-level file, e.g. /home/$target_user/.config/openstack. This might be a nodepool change.","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"e3724d8d7b9b6a6f456a01657ec26b3757056013","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    clouds      \u003d\u003e $oscc_clouds,"},{"line_number":43,"context_line":"    cache       \u003d\u003e $oscc_cache,"},{"line_number":44,"context_line":"    client      \u003d\u003e $oscc_client,"},{"line_number":45,"context_line":"    target_user \u003d\u003e \u0027nodepool\u0027,"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  class { \u0027::nodepool\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_5f5eee44","line":45,"in_reply_to":"1a4dcd0f_846b9a84","updated":"2015-08-19 23:57:10.000000000","message":"btw, I updated my nodepool.yaml to configure this.\n\n#cloud-config-path: /etc/cloud/clouds.yaml\ncloud-config-path: /home/nodepool/.config/openstack/clouds.yaml\n\nas (finally) explained here: https://review.openstack.org/#/c/214407/","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"04d35bb688496d07af270769bc50b6862bdf544a","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  file { \u0027/etc/nodepool/nodepool.yaml\u0027:"},{"line_number":64,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":65,"context_line":"    path    \u003d\u003e $yaml_path,"},{"line_number":66,"context_line":"    owner   \u003d\u003e \u0027nodepool\u0027,"},{"line_number":67,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":68,"context_line":"    mode    \u003d\u003e \u00270400\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_ff7582f9","line":65,"updated":"2015-08-19 23:51:41.000000000","message":"s/path/source/\notherwise nothing is created","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"44359f60cde2e963b62d0c80d4954d2f25e547c8","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  file { \u0027/etc/nodepool/nodepool.yaml\u0027:"},{"line_number":64,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":65,"context_line":"    path    \u003d\u003e $yaml_path,"},{"line_number":66,"context_line":"    owner   \u003d\u003e \u0027nodepool\u0027,"},{"line_number":67,"context_line":"    group   \u003d\u003e \u0027root\u0027,"},{"line_number":68,"context_line":"    mode    \u003d\u003e \u00270400\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_29759931","line":65,"in_reply_to":"fa1b9901_ff7582f9","updated":"2015-08-21 17:30:28.000000000","message":"Done","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"04d35bb688496d07af270769bc50b6862bdf544a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    mode    \u003d\u003e \u00270400\u0027,"},{"line_number":69,"context_line":"    require \u003d\u003e ["},{"line_number":70,"context_line":"      File[\u0027/etc/nodepool\u0027],"},{"line_number":71,"context_line":"      User[\u0027nodepool\u0027],"},{"line_number":72,"context_line":"    ],"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_7f073218","line":71,"updated":"2015-08-19 23:51:41.000000000","message":"Should require Class project_config as well.","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"44359f60cde2e963b62d0c80d4954d2f25e547c8","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    mode    \u003d\u003e \u00270400\u0027,"},{"line_number":69,"context_line":"    require \u003d\u003e ["},{"line_number":70,"context_line":"      File[\u0027/etc/nodepool\u0027],"},{"line_number":71,"context_line":"      User[\u0027nodepool\u0027],"},{"line_number":72,"context_line":"    ],"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa1b9901_49724d4b","line":71,"in_reply_to":"fa1b9901_7f073218","updated":"2015-08-21 17:30:28.000000000","message":"Done","commit_id":"24d96dfbfe80486eba4704cf9a6b1b03401d558f"}],"templates/nodepool/nodepool.logging.conf.erb":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"c8dc2e17a9b737b8eef42818a20959d6ef1b44dc","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# THIS FILE HAS BEEN AUTOGENERATED"},{"line_number":5,"context_line":"# Regenerate it with tools/nodepool_log_config.py"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[loggers]"}],"source_content_type":"application/x-erb","patch_set":2,"id":"ba3cc151_ea549ffe","line":5,"updated":"2015-07-09 13:37:46.000000000","message":"I\u0027m not sure if this generated file belongs here.....need to investigate more","commit_id":"0066219f899622bf018d68942ba93d9d0bf2afd3"}]}