)]}'
{"spec/spec_helper_acceptance.rb":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9f8698ca56824d4276ba833f9694155fb16417a9","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      # installed by the test prep.  If not, we need to install the"},{"line_number":30,"context_line":"      # modules ourselves."},{"line_number":31,"context_line":"      on host, \"ls /etc/puppet/modules\" do |r|"},{"line_number":32,"context_line":"        if r.stdout \u003d\u003d \"\\n\""},{"line_number":33,"context_line":"          dir \u003d host.tmpdir(\u0027system-config\u0027)"},{"line_number":34,"context_line":"          on host, \"git clone https://git.openstack.org/openstack-infra/system-config #{dir}/system-config\""},{"line_number":35,"context_line":"          on host, \"#{dir}/system-config/tools/install_modules.sh\""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"7a016987_1859d95a","line":32,"updated":"2015-05-28 00:17:15.000000000","message":"This patch fails for me, I think because of this. stdout isn\u0027t newline or empty, it\u0027s\n\n Warning: Setting templatedir is deprecated. See http://links.puppetlabs.com/env-settings-deprecations\n   (at /usr/lib/ruby/vendor_ruby/puppet/settings.rb:1139:in `issue_deprecation_warning\u0027)\n /etc/puppet/modules (no modules installed)","commit_id":"ae414417eb5579e5e3fd0089fcb6d4df172b11fa"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"5e83bb73154a3228e13432665d54ce7a162c0ed8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      # installed by the test prep.  If not, we need to install the"},{"line_number":30,"context_line":"      # modules ourselves."},{"line_number":31,"context_line":"      on host, \"ls /etc/puppet/modules\" do |r|"},{"line_number":32,"context_line":"        if r.stdout \u003d\u003d \"\\n\""},{"line_number":33,"context_line":"          dir \u003d host.tmpdir(\u0027system-config\u0027)"},{"line_number":34,"context_line":"          on host, \"git clone https://git.openstack.org/openstack-infra/system-config #{dir}/system-config\""},{"line_number":35,"context_line":"          on host, \"#{dir}/system-config/tools/install_modules.sh\""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"7a016987_9cca5619","line":32,"in_reply_to":"7a016987_1859d95a","updated":"2015-05-28 06:19:16.000000000","message":"er, that was the output for `puppet module list`. `ls /etc/puppet/modules` is empty, not newline.","commit_id":"ae414417eb5579e5e3fd0089fcb6d4df172b11fa"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"ec52fcb4506678b5f792b015743d0da446b950d8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        if r.stdout \u003d\u003d \"\""},{"line_number":33,"context_line":"          dir \u003d host.tmpdir(\u0027system-config\u0027)"},{"line_number":34,"context_line":"          on host, \"git clone https://git.openstack.org/openstack-infra/system-config #{dir}/system-config\""},{"line_number":35,"context_line":"          on host, \"#{dir}/system-config/tools/install_modules.sh\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"          # Delete and then copy the module being tested in to place."},{"line_number":38,"context_line":"          on host, \"rm -fr /etc/puppet/modules/#{modname}\""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"3afb71cf_4bc4763f","line":35,"updated":"2015-06-04 23:14:44.000000000","message":"Looks like install_modules.sh lives at the top level, not in tools/ http://git.openstack.org/cgit/openstack-infra/system-config/tree/","commit_id":"d38ff0e296beb3fed1339341a9bac075163a8a99"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"683f387bfdec4f44ebf766135167b15d25230bde","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        zuul_clone_cmd +\u003d \"--zuul-url #{zuul_url} \""},{"line_number":39,"context_line":"        zuul_clone_cmd +\u003d \"git://git.openstack.org #{repo}\""},{"line_number":40,"context_line":"        on host, zuul_clone_cmd"},{"line_number":41,"context_line":"        on host, \"ls #{repo}\""},{"line_number":42,"context_line":"      else"},{"line_number":43,"context_line":"        on host, \"git clone https://git.openstack.org/#{repo}\""},{"line_number":44,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"ba3cc151_e986cd15","line":41,"updated":"2015-07-03 18:27:28.000000000","message":"Updated https://review.openstack.org/#/c/190839 to not include this, this was a debugging helper","commit_id":"d6ecad58cdb9c6d4327f7243adfda81e8e46254b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"24e6992fee5514aa163e27d4f23a0b3cb210cd35","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      install_package host, \u0027git\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"      # clean out any module cruft"},{"line_number":26,"context_line":"      shell(\u0027rm -fr /etc/puppet/modules/*\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"      # install library modules from the forge"},{"line_number":29,"context_line":"      on host, puppet(\u0027module\u0027,\u0027install\u0027,\u0027puppetlabs-apache\u0027, \u0027--version\u0027, \u00270.0.4\u0027), { :acceptable_exit_codes \u003d\u003e 0 }"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"ba3cc151_60b9fc78","side":"PARENT","line":26,"updated":"2015-07-07 19:35:10.000000000","message":"We removed this because r10k purges this for us. 1) it turns out that\u0027s unreliable in some cases, so we put it back, and 2) you\u0027re not using r10k so you should probably keep this.","commit_id":"cdc03e1cc8ceb0a3a67f6835529eedbb978b2e74"}]}