)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"6a1da5ee122af67266cd7e12aab98407ab4d769c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some third-party vendors may want to leverage the Jenkins Job Builder"},{"line_number":10,"context_line":"library, some may not. Put it in a separate manifest from the previous"},{"line_number":11,"context_line":"`system-config`\u0027s `jenkins.pp` file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc7a46a8cb364b9e64b1fddb6b4f9df5a9e1fdd5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_082227a3","line":11,"updated":"2015-05-22 19:10:57.000000000","message":"Please add a new patch in system-config that consumes this patch.\nInclude a Depends-On: Ibc7a46a8cb364b9e64b1fddb6b4f9df5a9e1fdd5 in the commit message.\n\nThe, please add that patch\u0027s change-id here:\nNeeded-by: \u003csystem-config change-id\u003e\n\nThanks!","commit_id":"b09333154f1e158b9483c7f018f60cc458abf2db"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"e9d30248d4cb53d0d7963d1c0f98a6ebfd337637","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Some third-party vendors may want to leverage the Jenkins Job Builder"},{"line_number":10,"context_line":"library, some may not. Put it in a separate manifest from the previous"},{"line_number":11,"context_line":"`system-config`\u0027s `jenkins.pp` file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc7a46a8cb364b9e64b1fddb6b4f9df5a9e1fdd5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_763d388e","line":12,"updated":"2015-07-08 00:55:16.000000000","message":"Please add the related system-config id here for quick reference: \n\nNeeded-by: I4e27ec9e47f55799443b5ebad19ebfbaebe061c4","commit_id":"500712db032a2e83f24301d1c2bb8b42544ffa48"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"83623b631dfb739307e1aa49c586319ff444d115","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Some third-party vendors may want to leverage the Jenkins Job Builder"},{"line_number":10,"context_line":"library, some may not. Put it in a separate manifest from the previous"},{"line_number":11,"context_line":"`system-config`\u0027s `jenkins.pp` file."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibc7a46a8cb364b9e64b1fddb6b4f9df5a9e1fdd5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba3cc151_ba5f1e0e","line":12,"in_reply_to":"ba3cc151_763d388e","updated":"2015-07-08 05:21:06.000000000","message":"Done","commit_id":"500712db032a2e83f24301d1c2bb8b42544ffa48"}],"manifests/jenkins_job_builder.pp":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"06094d03102d4544c79ca5ae24801fc14634934a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrig\u0027,"},{"line_number":5,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":6,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":7,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027"},{"line_number":8,"context_line":") {"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    class { \u0027project_config\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a016987_94a1a948","line":7,"updated":"2015-05-22 00:48:10.000000000","message":"You need this argument:\n $project_config_repo \u003d \u0027\u0027,\n\nhttps://github.com/openstack-infra/system-config/blob/master/modules/openstack_project/manifests/jenkins.pp#L20","commit_id":"72d5c2f015c71e8a4bc99396601695a31ad28135"},{"author":{"_account_id":7505,"name":"Jaume Devesa","email":"devvesa@gmail.com","username":"devesa"},"change_message_id":"43a3f5ee42880b5f225b984eceb51ce30396399d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"      password                    \u003d\u003e $jenkins_jobs_password,"},{"line_number":19,"context_line":"      git_revision                \u003d\u003e $jenkins_git_revision,"},{"line_number":20,"context_line":"      git_url                     \u003d\u003e $jenkins_git_url,"},{"line_number":21,"context_line":"      config_dir                  \u003d\u003e $::project_config::jenkins_job_builder_config_dir,"},{"line_number":22,"context_line":"      require                     \u003d\u003e $::project_config::config_dir,"},{"line_number":23,"context_line":"    }"},{"line_number":24,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a016987_d40a8189","line":21,"updated":"2015-05-22 00:19:22.000000000","message":"Not sure if project_config\u0027s variables should be referenced like system-config or not. I understand that third-party vendors will need some kind of project_config parameters before deploying... so I leave it as it is.","commit_id":"72d5c2f015c71e8a4bc99396601695a31ad28135"},{"author":{"_account_id":8617,"name":"Hunter Haugen","email":"hunter@puppet.com","username":"hunner"},"change_message_id":"5fe9dff19df6bad1eb31f27a75ce27903049e8b4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  $project_config_repo \u003d \u0027\u0027"},{"line_number":10,"context_line":") {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    class { \u0027project_config\u0027:"},{"line_number":13,"context_line":"      url  \u003d\u003e $project_config_repo,"},{"line_number":14,"context_line":"    }"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a016987_22d505e7","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":4},"updated":"2015-05-22 17:06:21.000000000","message":"This should be 2 space indentation.","commit_id":"b8d98ffd06332a239fc5fb70316d566896f059a4"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b64e927f246a37917f7d5a67d2f7eff8687930eb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstackci::jenkins_job_builder ("},{"line_number":4,"context_line":"  $vhost_name \u003d $::fqdn,"},{"line_number":5,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrig\u0027,"},{"line_number":6,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":7,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":8,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba3cc151_66bc036d","line":5,"updated":"2015-06-29 20:15:52.000000000","message":"We can rename the user in openstack-infra if we would like to go ahead and nip this typo in the bud before it spreads any further.","commit_id":"b09333154f1e158b9483c7f018f60cc458abf2db"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3a7d0e3b58a5a8eb9b012ea3a018d9afd6cb755b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":9,"context_line":"  $project_config_repo \u003d \u0027\u0027"},{"line_number":10,"context_line":") {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  class { \u0027project_config\u0027:"},{"line_number":13,"context_line":"    url  \u003d\u003e $project_config_repo,"},{"line_number":14,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_84bdd1d9","line":11,"updated":"2015-07-02 21:39:59.000000000","message":"Need to add protections against duplicate declarations for this. and also here: http://git.openstack.org/cgit/openstack-infra/puppet-openstackci/tree/manifests/zuul_scheduler.pp#n49\n\ne.g.   if ! defined(Class[\u0027project_config\u0027]) {\n    class { \u0027project_config\u0027:\n      url  \u003d\u003e $project_config_repo,\n    }\n  }\n\n\nAlso for consistency we should add:\n\n base \u003d\u003e $project_config_base,","commit_id":"20191ed097bd3ffaebfcbf9361f7ee16246a236a"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"cabf9ffa1035481fb38a043cf7d96e24d77259ac","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":9,"context_line":"  $project_config_repo \u003d \u0027\u0027"},{"line_number":10,"context_line":") {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  class { \u0027project_config\u0027:"},{"line_number":13,"context_line":"    url  \u003d\u003e $project_config_repo,"},{"line_number":14,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_97ad5d8a","line":11,"in_reply_to":"ba3cc151_84bdd1d9","updated":"2015-07-07 22:35:12.000000000","message":"Done","commit_id":"20191ed097bd3ffaebfcbf9361f7ee16246a236a"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"760e2e184c5b04f1305fc257e47ae6c880f8c424","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":9,"context_line":"  $project_config_repo \u003d \u0027\u0027"},{"line_number":10,"context_line":") {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  class { \u0027project_config\u0027:"},{"line_number":13,"context_line":"    url  \u003d\u003e $project_config_repo,"},{"line_number":14,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_367010a4","line":11,"in_reply_to":"ba3cc151_97ad5d8a","updated":"2015-07-08 00:53:03.000000000","message":"you need this too: \" and also here: http://git.openstack.org/cgit/openstack-infra/puppet-openstackci/tree/manifests/zuul_scheduler.pp#n49\"","commit_id":"20191ed097bd3ffaebfcbf9361f7ee16246a236a"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"688267bb0630a524d341b6d6cbb99165ba1fed39","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  class { \u0027::jenkins::job_builder\u0027:"},{"line_number":17,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e 1200,"},{"line_number":18,"context_line":"    url                         \u003d\u003e \"https://${vhost_name}/\","},{"line_number":19,"context_line":"    username                    \u003d\u003e $jenkins_jobs_username,"},{"line_number":20,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_fc59305c","line":17,"updated":"2015-07-07 22:33:21.000000000","message":"maybe parameterize this as well?","commit_id":"20191ed097bd3ffaebfcbf9361f7ee16246a236a"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"cabf9ffa1035481fb38a043cf7d96e24d77259ac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  }"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  class { \u0027::jenkins::job_builder\u0027:"},{"line_number":17,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e 1200,"},{"line_number":18,"context_line":"    url                         \u003d\u003e \"https://${vhost_name}/\","},{"line_number":19,"context_line":"    username                    \u003d\u003e $jenkins_jobs_username,"},{"line_number":20,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_b7a8a178","line":17,"in_reply_to":"ba3cc151_fc59305c","updated":"2015-07-07 22:35:12.000000000","message":"Done","commit_id":"20191ed097bd3ffaebfcbf9361f7ee16246a236a"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3a7d0e3b58a5a8eb9b012ea3a018d9afd6cb755b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  class { \u0027::jenkins::job_builder\u0027:"},{"line_number":17,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e 1200,"},{"line_number":18,"context_line":"    url                         \u003d\u003e \"https://${vhost_name}/\","},{"line_number":19,"context_line":"    username                    \u003d\u003e $jenkins_jobs_username,"},{"line_number":20,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"},{"line_number":21,"context_line":"    git_revision                \u003d\u003e $jenkins_git_revision,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_fafc74b9","line":18,"updated":"2015-07-02 21:39:59.000000000","message":"My setup doesn\u0027t use https. Also I\u0027m at port 8080. How about we just pass in the jenkins url instead of vhost_name?","commit_id":"20191ed097bd3ffaebfcbf9361f7ee16246a236a"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"cabf9ffa1035481fb38a043cf7d96e24d77259ac","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  class { \u0027::jenkins::job_builder\u0027:"},{"line_number":17,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e 1200,"},{"line_number":18,"context_line":"    url                         \u003d\u003e \"https://${vhost_name}/\","},{"line_number":19,"context_line":"    username                    \u003d\u003e $jenkins_jobs_username,"},{"line_number":20,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"},{"line_number":21,"context_line":"    git_revision                \u003d\u003e $jenkins_git_revision,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_57b6f5dc","line":18,"in_reply_to":"ba3cc151_fafc74b9","updated":"2015-07-07 22:35:12.000000000","message":"Done","commit_id":"20191ed097bd3ffaebfcbf9361f7ee16246a236a"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"5d9af3bb803e0aacb5168273dbb5ec08c2aed2e8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstackci::jenkins_job_builder ("},{"line_number":4,"context_line":"  $vhost_name \u003d $::fqdn,"},{"line_number":5,"context_line":"  $jenkins_url \u003d \u0027http://${vhost_name}:8080\u0027,"},{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba3cc151_a97d7e6e","line":5,"updated":"2015-07-08 16:34:27.000000000","message":"Arrg! does this need double quotes instead of single quote?","commit_id":"bd38ddb2e31642bdc36fc06ec2e402fb7b75e8b9"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"7d21e3d89f2e7c82deb9e63a4e48b4ef2f913504","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"class openstackci::jenkins_job_builder ("},{"line_number":4,"context_line":"  $vhost_name \u003d $::fqdn,"},{"line_number":5,"context_line":"  $jenkins_url \u003d \u0027http://${vhost_name}:8080\u0027,"},{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"ba3cc151_09efcab1","line":5,"in_reply_to":"ba3cc151_a97d7e6e","updated":"2015-07-08 16:41:16.000000000","message":"Done","commit_id":"bd38ddb2e31642bdc36fc06ec2e402fb7b75e8b9"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"1e215a098e62885dab3b7c1c66df58b0c1f6e925","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class openstackci::jenkins_job_builder ("},{"line_number":4,"context_line":"  $vhost_name \u003d $::fqdn,"},{"line_number":5,"context_line":"  $jenkins_url \u003d \"http://${vhost_name}:8080\","},{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_cd93235a","line":6,"updated":"2015-07-08 20:48:45.000000000","message":"I\u0027m wondering if these would be better as jenkins_* instead of jenkins_jobs_*?  since these are actually jenkins configurations for JJB.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"eaf2d1409bc3a61733686a9fa8e307ede0e5fa13","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class openstackci::jenkins_job_builder ("},{"line_number":4,"context_line":"  $vhost_name \u003d $::fqdn,"},{"line_number":5,"context_line":"  $jenkins_url \u003d \"http://${vhost_name}:8080\","},{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_98b8f712","line":6,"in_reply_to":"ba3cc151_cd93235a","updated":"2015-07-08 21:11:45.000000000","message":"Done","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"1e215a098e62885dab3b7c1c66df58b0c1f6e925","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $jenkins_url \u003d \"http://${vhost_name}:8080\","},{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":10,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":11,"context_line":"  $project_config_repo \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_4dc07350","line":8,"updated":"2015-07-08 20:48:45.000000000","message":"This ironically is the probably the best named of the bunch since this config is specific to jenkins jobs.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"eaf2d1409bc3a61733686a9fa8e307ede0e5fa13","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  $jenkins_url \u003d \"http://${vhost_name}:8080\","},{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":10,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":11,"context_line":"  $project_config_repo \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_f8d90357","line":8,"in_reply_to":"ba3cc151_4dc07350","updated":"2015-07-08 21:11:45.000000000","message":"changed this to jjb_update_timeout because this is actually a puppet timeout setting when running the update command.  JJB doesn\u0027t actually have a timeout cmd at all but in this context it\u0027s for running JJB.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"45ec0653d2692108b67190100319efa2af9952a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":10,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":11,"context_line":"  $project_config_repo \u003d \u0027\u0027,"},{"line_number":12,"context_line":"  $project_config_base \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_27f50eec","line":9,"updated":"2015-07-08 19:47:18.000000000","message":"I would encourage jjb_git_url or jenkins_jobs_git_url to clarify this is the jjb git url not a git url for a jenkins.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"eaf2d1409bc3a61733686a9fa8e307ede0e5fa13","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":10,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":11,"context_line":"  $project_config_repo \u003d \u0027\u0027,"},{"line_number":12,"context_line":"  $project_config_base \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_38bbebe6","line":9,"in_reply_to":"ba3cc151_27f50eec","updated":"2015-07-08 21:11:45.000000000","message":"Done","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"1e215a098e62885dab3b7c1c66df58b0c1f6e925","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  $jenkins_jobs_username \u003d \u0027gerrit\u0027,"},{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":10,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":11,"context_line":"  $project_config_repo \u003d \u0027\u0027,"},{"line_number":12,"context_line":"  $project_config_base \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_ada49fa5","line":9,"in_reply_to":"ba3cc151_27f50eec","updated":"2015-07-08 20:48:45.000000000","message":"I like either jjb_git_url or jenkins_job_builder_git_url but prefer the former just because it\u0027s shorter.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"45ec0653d2692108b67190100319efa2af9952a4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":10,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":11,"context_line":"  $project_config_repo \u003d \u0027\u0027,"},{"line_number":12,"context_line":"  $project_config_base \u003d \u0027\u0027,"},{"line_number":13,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_87e41a3c","line":10,"updated":"2015-07-08 19:47:18.000000000","message":"Same here, jjb_git_revision or jenkins_jobs_git_revision in keeping with the variables above.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"eaf2d1409bc3a61733686a9fa8e307ede0e5fa13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  $jenkins_jobs_password \u003d \u0027\u0027,"},{"line_number":8,"context_line":"  $jenkins_jobs_update_timeout \u003d 1200,"},{"line_number":9,"context_line":"  $jenkins_git_url \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":10,"context_line":"  $jenkins_git_revision \u003d \u0027master\u0027,"},{"line_number":11,"context_line":"  $project_config_repo \u003d \u0027\u0027,"},{"line_number":12,"context_line":"  $project_config_base \u003d \u0027\u0027,"},{"line_number":13,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_b8cffb7d","line":10,"in_reply_to":"ba3cc151_87e41a3c","updated":"2015-07-08 21:11:45.000000000","message":"Done","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"45ec0653d2692108b67190100319efa2af9952a4","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    username                    \u003d\u003e $jenkins_jobs_username,"},{"line_number":25,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"},{"line_number":26,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e $jenkins_jobs_update_timeout,"},{"line_number":27,"context_line":"    git_revision                \u003d\u003e $jenkins_git_revision,"},{"line_number":28,"context_line":"    git_url                     \u003d\u003e $jenkins_git_url,"},{"line_number":29,"context_line":"    config_dir                  \u003d\u003e $::project_config::jenkins_job_builder_config_dir,"},{"line_number":30,"context_line":"    require                     \u003d\u003e $::project_config::config_dir,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_67d6b650","line":27,"updated":"2015-07-08 19:47:18.000000000","message":"Same change here.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"eaf2d1409bc3a61733686a9fa8e307ede0e5fa13","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    username                    \u003d\u003e $jenkins_jobs_username,"},{"line_number":25,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"},{"line_number":26,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e $jenkins_jobs_update_timeout,"},{"line_number":27,"context_line":"    git_revision                \u003d\u003e $jenkins_git_revision,"},{"line_number":28,"context_line":"    git_url                     \u003d\u003e $jenkins_git_url,"},{"line_number":29,"context_line":"    config_dir                  \u003d\u003e $::project_config::jenkins_job_builder_config_dir,"},{"line_number":30,"context_line":"    require                     \u003d\u003e $::project_config::config_dir,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_78c5f359","line":27,"in_reply_to":"ba3cc151_67d6b650","updated":"2015-07-08 21:11:45.000000000","message":"Done","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"change_message_id":"45ec0653d2692108b67190100319efa2af9952a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"},{"line_number":26,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e $jenkins_jobs_update_timeout,"},{"line_number":27,"context_line":"    git_revision                \u003d\u003e $jenkins_git_revision,"},{"line_number":28,"context_line":"    git_url                     \u003d\u003e $jenkins_git_url,"},{"line_number":29,"context_line":"    config_dir                  \u003d\u003e $::project_config::jenkins_job_builder_config_dir,"},{"line_number":30,"context_line":"    require                     \u003d\u003e $::project_config::config_dir,"},{"line_number":31,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_07c7aa98","line":28,"updated":"2015-07-08 19:47:18.000000000","message":"And here.","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"eaf2d1409bc3a61733686a9fa8e307ede0e5fa13","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    password                    \u003d\u003e $jenkins_jobs_password,"},{"line_number":26,"context_line":"    jenkins_jobs_update_timeout \u003d\u003e $jenkins_jobs_update_timeout,"},{"line_number":27,"context_line":"    git_revision                \u003d\u003e $jenkins_git_revision,"},{"line_number":28,"context_line":"    git_url                     \u003d\u003e $jenkins_git_url,"},{"line_number":29,"context_line":"    config_dir                  \u003d\u003e $::project_config::jenkins_job_builder_config_dir,"},{"line_number":30,"context_line":"    require                     \u003d\u003e $::project_config::config_dir,"},{"line_number":31,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba3cc151_98c23752","line":28,"in_reply_to":"ba3cc151_07c7aa98","updated":"2015-07-08 21:11:45.000000000","message":"Done","commit_id":"72caa591b5e6fa52823bc20040c115cd7fbd801e"}]}