)]}'
{"manifests/jenkins_master.pp":[{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"74e9cb79634e5462814c5289ac9a5d6289c7ca86","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      }"},{"line_number":105,"context_line":"    }"},{"line_number":106,"context_line":"    class { \u0027::jenkins::job_builder\u0027:"},{"line_number":107,"context_line":"      jenkins_jobs_update_timeout \u003d\u003e $jenkins_update_timeout,"},{"line_number":108,"context_line":"      url                         \u003d\u003e $jenkins_url,"},{"line_number":109,"context_line":"      username                    \u003d\u003e $jenkins_username,"},{"line_number":110,"context_line":"      password                    \u003d\u003e $jenkins_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba3cc151_923c41e2","line":107,"updated":"2015-07-09 05:29:33.000000000","message":"this should actually be jjb_update_timeout because it\u0027s the jjb timeout when running a jjb command.","commit_id":"66cc8b1c6b7cece61cccb2208348e5900ca26c64"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"0893442393a04229266e9b0aabf3c6bd7a352e97","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      }"},{"line_number":105,"context_line":"    }"},{"line_number":106,"context_line":"    class { \u0027::jenkins::job_builder\u0027:"},{"line_number":107,"context_line":"      jenkins_jobs_update_timeout \u003d\u003e $jenkins_update_timeout,"},{"line_number":108,"context_line":"      url                         \u003d\u003e $jenkins_url,"},{"line_number":109,"context_line":"      username                    \u003d\u003e $jenkins_username,"},{"line_number":110,"context_line":"      password                    \u003d\u003e $jenkins_password,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba3cc151_65a3f900","line":107,"in_reply_to":"ba3cc151_923c41e2","updated":"2015-07-09 05:38:47.000000000","message":"Done","commit_id":"66cc8b1c6b7cece61cccb2208348e5900ca26c64"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d482d429963964ad67e358619c96fb17d214d99f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $jenkins_ssh_private_key \u003d \u0027\u0027,"},{"line_number":14,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_df82a9fe","line":16,"updated":"2015-07-09 18:23:38.000000000","message":"This will not work if $vhost_name is unset:\n\nhttp://paste.openstack.org/show/359277/","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"eb39551dea372d488d0060a383f48c7b19786823","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $jenkins_ssh_private_key \u003d \u0027\u0027,"},{"line_number":14,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_ea7a4df0","line":16,"in_reply_to":"ba3cc151_df82a9fe","updated":"2015-07-09 18:58:20.000000000","message":"Discussed and we can set the default to http://localhost:8080","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"d060784a62d1d51c8addbe8b00c68d165f495469","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  $jenkins_ssh_private_key \u003d \u0027\u0027,"},{"line_number":14,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_7d79222e","line":16,"in_reply_to":"ba3cc151_ea7a4df0","updated":"2015-07-09 20:34:17.000000000","message":"Done","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d482d429963964ad67e358619c96fb17d214d99f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_5fa699ab","line":17,"updated":"2015-07-09 18:23:38.000000000","message":"I would prefer to see this value not have any default and be at the top of the params list after $serveradmin. Setting a password to empty string is likely to cause errors that aren\u0027t immediately obvious.","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"eb39551dea372d488d0060a383f48c7b19786823","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_452d6a8d","line":17,"in_reply_to":"ba3cc151_4ac1f94c","updated":"2015-07-09 18:58:20.000000000","message":"This default password is convenient for unsecured jenkins. \n\nIf we do make it required, I\u0027d say you should make the username required as well because it would fail for the same reason. Also there\u0027s no puppet that creates that user AFAIK.","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"d060784a62d1d51c8addbe8b00c68d165f495469","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_40e0f525","line":17,"in_reply_to":"ba3cc151_5fa699ab","updated":"2015-07-09 20:34:17.000000000","message":"Done","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"bff11ce427c56ab8040441a334f94a7563f58ee3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_4ac1f94c","line":17,"in_reply_to":"ba3cc151_5fa699ab","updated":"2015-07-09 18:42:53.000000000","message":"I strongly agree with this point.","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"eb39551dea372d488d0060a383f48c7b19786823","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":21,"context_line":"  $jjb_git_revision        \u003d \u0027master\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_853e12b6","line":18,"updated":"2015-07-09 18:58:20.000000000","message":"Also, my jenkins username is \"jenkins\", which is probably a better default than gerrit, but don\u0027t really want to nit that.","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"1ba3d0adc96a9d4af7b72ad59f177dc6b641631a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":21,"context_line":"  $jjb_git_revision        \u003d \u0027master\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_0d21dd9d","line":18,"updated":"2015-07-09 13:52:45.000000000","message":"NIT: username should come before password.","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"d060784a62d1d51c8addbe8b00c68d165f495469","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":21,"context_line":"  $jjb_git_revision        \u003d \u0027master\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_00d50d41","line":18,"in_reply_to":"ba3cc151_0d21dd9d","updated":"2015-07-09 20:34:17.000000000","message":"Done","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"d060784a62d1d51c8addbe8b00c68d165f495469","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":16,"context_line":"  $jenkins_url             \u003d \"https://${vhost_name}/\","},{"line_number":17,"context_line":"  $jenkins_password        \u003d \u0027\u0027,"},{"line_number":18,"context_line":"  $jenkins_username        \u003d \u0027gerrit\u0027,"},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":21,"context_line":"  $jjb_git_revision        \u003d \u0027master\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_c0cac59f","line":18,"in_reply_to":"ba3cc151_853e12b6","updated":"2015-07-09 20:34:17.000000000","message":"Done","commit_id":"c3a48a95cf90825dd2e9eb0067eb4ea25fd56058"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"23708e50132f159fcd4e2af921f78cbecf798bd2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"class openstackci::jenkins_master ("},{"line_number":4,"context_line":"  $serveradmin,"},{"line_number":5,"context_line":"  $jenkins_username        \u003d \u0027jenkins\u0027,"},{"line_number":6,"context_line":"  $jenkins_password,"},{"line_number":7,"context_line":"  $vhost_name              \u003d $::fqdn,"},{"line_number":8,"context_line":"  $logo                    \u003d \u0027\u0027, # Logo must be present in puppet-jenkins/files"},{"line_number":9,"context_line":"  $ssl_cert_file           \u003d \u0027/etc/ssl/certs/ssl-cert-snakeoil.pem\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_6056595d","line":6,"updated":"2015-07-09 20:43:23.000000000","message":"nit - style guide suggests require parameters go before parameters with defaults https://docs.puppetlabs.com/guides/style_guide.html#display-order-of-parameters","commit_id":"33cbda53826f775de9389eb304294437f6d78b81"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"9ce47cdf14174ae805a52824f1a7c6356f34d920","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  $jenkins_ssh_private_key \u003d \u0027\u0027,"},{"line_number":16,"context_line":"  $jenkins_ssh_public_key  \u003d \u0027\u0027,"},{"line_number":17,"context_line":"  $manage_jenkins_jobs     \u003d false,"},{"line_number":18,"context_line":"  $jenkins_url             \u003d \"http://localhost:8080\","},{"line_number":19,"context_line":"  $jjb_update_timeout      \u003d 1200,"},{"line_number":20,"context_line":"  $jjb_git_url             \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"},{"line_number":21,"context_line":"  $jjb_git_revision        \u003d \u0027master\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_024c2dc6","line":18,"updated":"2015-07-09 22:54:08.000000000","message":"Need to be single quotes to pass jenkins.\nhttp://logs.openstack.org/84/199784/6/check/gate-puppet-openstackci-puppet-lint/5175b41/console.html#_2015-07-09_22_13_19_698","commit_id":"ae6aa66c7e237a90f7b0e2cd449cfbe1dbfad15a"}]}
