)]}'
{"files/logstash/logstash-indexer.default":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"a23ffbaf8be9be78359086ba5e1a75637bce7738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba3cc151_eb65a5ae","updated":"2015-07-09 00:29:27.000000000","message":"Should this file be pulled up one level? I kept inside ./logstash folder as it was in openstack_project module.","commit_id":"c3e44793a09efaf96819aab5180cf99c4cff2e1a"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6f27789e90ab07e5dc195f09468467ed6d91bbca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Increase the max heap size to twice the default."},{"line_number":2,"context_line":"# Default is 25% of memory or 1g whichever is less."},{"line_number":3,"context_line":"JAVA_ARGS\u003d\u0027-Xmx2g\u0027"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a41bdd9_57ad0787","line":3,"updated":"2015-07-11 22:30:02.000000000","message":"Done, got rid of this file entirely. Setting content inline.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"cc9b3d5ee9261866f80a4132fa0b2f26d901710a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Increase the max heap size to twice the default."},{"line_number":2,"context_line":"# Default is 25% of memory or 1g whichever is less."},{"line_number":3,"context_line":"JAVA_ARGS\u003d\u0027-Xmx2g\u0027"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"ba3cc151_f20c66ee","line":3,"updated":"2015-07-10 09:16:28.000000000","message":"i\u0027d love if that can be parameterized, overriding JAVA_ARGS has been proved to be useful under different situations","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"62c012d88157687ed8fd482d85a3b06a80248741","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Increase the max heap size to twice the default."},{"line_number":2,"context_line":"# Default is 25% of memory or 1g whichever is less."},{"line_number":3,"context_line":"JAVA_ARGS\u003d\u0027-Xmx2g\u0027"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a41bdd9_9f25f35d","line":3,"in_reply_to":"ba3cc151_f20c66ee","updated":"2015-07-10 23:06:28.000000000","message":"++ I would like to see this be parameterized too","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"}],"manifests/elasticsearch_node.pp":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6f27789e90ab07e5dc195f09468467ed6d91bbca","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  class { \u0027logstash::elasticsearch\u0027: }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  class { \u0027::elasticsearch\u0027:"},{"line_number":28,"context_line":"    es_template_config \u003d\u003e {"},{"line_number":29,"context_line":"      \u0027index.store.compress.stored\u0027          \u003d\u003e true,"},{"line_number":30,"context_line":"      \u0027index.store.compress.tv\u0027              \u003d\u003e true,"},{"line_number":31,"context_line":"      \u0027indices.memory.index_buffer_size\u0027     \u003d\u003e \u002733%\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_77aa8b72","line":28,"updated":"2015-07-11 22:30:02.000000000","message":"I have exposed parameters related to deployment size and recover_after_time. I think the rest, if there is a need, should be done later to keep this patch manageable.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"cc9b3d5ee9261866f80a4132fa0b2f26d901710a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  class { \u0027logstash::elasticsearch\u0027: }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  class { \u0027::elasticsearch\u0027:"},{"line_number":28,"context_line":"    es_template_config \u003d\u003e {"},{"line_number":29,"context_line":"      \u0027index.store.compress.stored\u0027          \u003d\u003e true,"},{"line_number":30,"context_line":"      \u0027index.store.compress.tv\u0027              \u003d\u003e true,"},{"line_number":31,"context_line":"      \u0027indices.memory.index_buffer_size\u0027     \u003d\u003e \u002733%\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_1229ca37","line":28,"updated":"2015-07-10 09:16:28.000000000","message":"can these settings be parameterized somehow?","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"62c012d88157687ed8fd482d85a3b06a80248741","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  class { \u0027logstash::elasticsearch\u0027: }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  class { \u0027::elasticsearch\u0027:"},{"line_number":28,"context_line":"    es_template_config \u003d\u003e {"},{"line_number":29,"context_line":"      \u0027index.store.compress.stored\u0027          \u003d\u003e true,"},{"line_number":30,"context_line":"      \u0027index.store.compress.tv\u0027              \u003d\u003e true,"},{"line_number":31,"context_line":"      \u0027indices.memory.index_buffer_size\u0027     \u003d\u003e \u002733%\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_5f20cb49","line":28,"in_reply_to":"ba3cc151_1229ca37","updated":"2015-07-10 23:06:28.000000000","message":"I don\u0027t think all of these need to be parameterized, but some of them should be","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"62c012d88157687ed8fd482d85a3b06a80248741","unresolved":false,"context_lines":[{"line_number":30,"context_line":"      \u0027index.store.compress.tv\u0027              \u003d\u003e true,"},{"line_number":31,"context_line":"      \u0027indices.memory.index_buffer_size\u0027     \u003d\u003e \u002733%\u0027,"},{"line_number":32,"context_line":"      \u0027bootstrap.mlockall\u0027                   \u003d\u003e true,"},{"line_number":33,"context_line":"      \u0027gateway.recover_after_nodes\u0027          \u003d\u003e \u00275\u0027,"},{"line_number":34,"context_line":"      \u0027gateway.recover_after_time\u0027           \u003d\u003e \u00275m\u0027,"},{"line_number":35,"context_line":"      \u0027gateway.expected_nodes\u0027               \u003d\u003e \u00276\u0027,"},{"line_number":36,"context_line":"      \u0027discovery.zen.minimum_master_nodes\u0027   \u003d\u003e \u00274\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_ffd75f21","line":33,"updated":"2015-07-10 23:06:28.000000000","message":"This is dependent on the cluster deployment","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"62c012d88157687ed8fd482d85a3b06a80248741","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      \u0027bootstrap.mlockall\u0027                   \u003d\u003e true,"},{"line_number":33,"context_line":"      \u0027gateway.recover_after_nodes\u0027          \u003d\u003e \u00275\u0027,"},{"line_number":34,"context_line":"      \u0027gateway.recover_after_time\u0027           \u003d\u003e \u00275m\u0027,"},{"line_number":35,"context_line":"      \u0027gateway.expected_nodes\u0027               \u003d\u003e \u00276\u0027,"},{"line_number":36,"context_line":"      \u0027discovery.zen.minimum_master_nodes\u0027   \u003d\u003e \u00274\u0027,"},{"line_number":37,"context_line":"      \u0027discovery.zen.ping.multicast.enabled\u0027 \u003d\u003e false,"},{"line_number":38,"context_line":"      \u0027discovery.zen.ping.unicast.hosts\u0027     \u003d\u003e $discover_nodes,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_7fe4af0c","line":35,"updated":"2015-07-10 23:06:28.000000000","message":"This will also be different for different deployments","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"62c012d88157687ed8fd482d85a3b06a80248741","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      \u0027gateway.recover_after_nodes\u0027          \u003d\u003e \u00275\u0027,"},{"line_number":34,"context_line":"      \u0027gateway.recover_after_time\u0027           \u003d\u003e \u00275m\u0027,"},{"line_number":35,"context_line":"      \u0027gateway.expected_nodes\u0027               \u003d\u003e \u00276\u0027,"},{"line_number":36,"context_line":"      \u0027discovery.zen.minimum_master_nodes\u0027   \u003d\u003e \u00274\u0027,"},{"line_number":37,"context_line":"      \u0027discovery.zen.ping.multicast.enabled\u0027 \u003d\u003e false,"},{"line_number":38,"context_line":"      \u0027discovery.zen.ping.unicast.hosts\u0027     \u003d\u003e $discover_nodes,"},{"line_number":39,"context_line":"    },"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_3fee27ed","line":36,"updated":"2015-07-10 23:06:28.000000000","message":"And this too","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6f27789e90ab07e5dc195f09468467ed6d91bbca","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    version            \u003d\u003e $version,"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  cron { \u0027delete_old_es_indices\u0027:"},{"line_number":45,"context_line":"    user        \u003d\u003e \u0027root\u0027,"},{"line_number":46,"context_line":"    hour        \u003d\u003e \u00272\u0027,"},{"line_number":47,"context_line":"    minute      \u003d\u003e \u00270\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_17b69fdc","line":44,"updated":"2015-07-11 22:30:02.000000000","message":"Done.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"cc9b3d5ee9261866f80a4132fa0b2f26d901710a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    version            \u003d\u003e $version,"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  cron { \u0027delete_old_es_indices\u0027:"},{"line_number":45,"context_line":"    user        \u003d\u003e \u0027root\u0027,"},{"line_number":46,"context_line":"    hour        \u003d\u003e \u00272\u0027,"},{"line_number":47,"context_line":"    minute      \u003d\u003e \u00270\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_32d16e30","line":44,"updated":"2015-07-10 09:16:28.000000000","message":"can the times of cron, and the duration, be parameterized as well?","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6f27789e90ab07e5dc195f09468467ed6d91bbca","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/usr/bin:/bin:/usr/sbin:/sbin\u0027,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  cron { \u0027optimize_old_es_indices\u0027:"},{"line_number":53,"context_line":"    ensure      \u003d\u003e absent,"},{"line_number":54,"context_line":"    user        \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    hour        \u003d\u003e \u002713\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_37bba3c6","line":52,"updated":"2015-07-11 22:30:02.000000000","message":"Done.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"62c012d88157687ed8fd482d85a3b06a80248741","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/usr/bin:/bin:/usr/sbin:/sbin\u0027,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  cron { \u0027optimize_old_es_indices\u0027:"},{"line_number":53,"context_line":"    ensure      \u003d\u003e absent,"},{"line_number":54,"context_line":"    user        \u003d\u003e \u0027root\u0027,"},{"line_number":55,"context_line":"    hour        \u003d\u003e \u002713\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_9faad384","line":52,"updated":"2015-07-10 23:06:28.000000000","message":"This is old cruft that should be removed, let\u0027s not create a new cron that we are ensuring is absent.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::elasticsearch_node ("},{"line_number":20,"context_line":"  $discover_nodes \u003d [\u0027localhost\u0027],"},{"line_number":21,"context_line":"  $heap_size \u003d \u002730g\u0027,"},{"line_number":22,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":23,"context_line":"  $es_gw_recover_after_nodes \u003d \u00275\u0027,"},{"line_number":24,"context_line":"  $es_gw_recover_after_time \u003d \u00275m\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_6415a9e3","line":21,"updated":"2015-08-10 22:22:16.000000000","message":"Done","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::elasticsearch_node ("},{"line_number":20,"context_line":"  $discover_nodes \u003d [\u0027localhost\u0027],"},{"line_number":21,"context_line":"  $heap_size \u003d \u002730g\u0027,"},{"line_number":22,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":23,"context_line":"  $es_gw_recover_after_nodes \u003d \u00275\u0027,"},{"line_number":24,"context_line":"  $es_gw_recover_after_time \u003d \u00275m\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_588c0a7f","line":21,"updated":"2015-08-04 23:26:08.000000000","message":"how about es_heap_size for consistency?","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class openstackci::elasticsearch_node ("},{"line_number":20,"context_line":"  $discover_nodes \u003d [\u0027localhost\u0027],"},{"line_number":21,"context_line":"  $heap_size \u003d \u002730g\u0027,"},{"line_number":22,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":23,"context_line":"  $es_gw_recover_after_nodes \u003d \u00275\u0027,"},{"line_number":24,"context_line":"  $es_gw_recover_after_time \u003d \u00275m\u0027,"},{"line_number":25,"context_line":"  $es_gw_expected_nodes \u003d \u00276\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_04d38539","line":22,"updated":"2015-08-10 22:22:16.000000000","message":"Done","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class openstackci::elasticsearch_node ("},{"line_number":20,"context_line":"  $discover_nodes \u003d [\u0027localhost\u0027],"},{"line_number":21,"context_line":"  $heap_size \u003d \u002730g\u0027,"},{"line_number":22,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":23,"context_line":"  $es_gw_recover_after_nodes \u003d \u00275\u0027,"},{"line_number":24,"context_line":"  $es_gw_recover_after_time \u003d \u00275m\u0027,"},{"line_number":25,"context_line":"  $es_gw_expected_nodes \u003d \u00276\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_f89b96c7","line":22,"updated":"2015-08-04 23:26:08.000000000","message":"how about es_version for consistency?","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"}],"manifests/logstash.pp":[{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"62c012d88157687ed8fd482d85a3b06a80248741","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    statsd_host \u003d\u003e $statsd_host,"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include \u0027subunit2sql\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  class { \u0027subunit2sql::server\u0027:"},{"line_number":43,"context_line":"    db_host \u003d\u003e $subunit2sql_db_host,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_1f76c33e","line":40,"updated":"2015-07-10 23:06:28.000000000","message":"Can we make subunit2sql optional?","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6f27789e90ab07e5dc195f09468467ed6d91bbca","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    statsd_host \u003d\u003e $statsd_host,"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include \u0027subunit2sql\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  class { \u0027subunit2sql::server\u0027:"},{"line_number":43,"context_line":"    db_host \u003d\u003e $subunit2sql_db_host,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_d7afd77b","line":40,"updated":"2015-07-11 22:30:02.000000000","message":"I do not fully understand what are the consequences. If the s2sql is not used, I assume simpleproxy below is not needed too? Is there something else that needs to happen? I.e. is making subunit2sql optional would only involve below section of the manifest? If it is more complex than optionally disabling section below, I would rather do it in another patch.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Logstash web frontend glue class."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::logstash ("},{"line_number":20,"context_line":"  $discover_nodes,"},{"line_number":21,"context_line":"  $statsd_host,"},{"line_number":22,"context_line":"  $subunit2sql_db_host,"},{"line_number":23,"context_line":"  $subunit2sql_db_pass,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_b8caee9f","line":20,"updated":"2015-08-04 23:26:08.000000000","message":"Can we default this as in logstash.pp? \n$discover_nodes \u003d [\u0027localhost\u0027]","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# Logstash web frontend glue class."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::logstash ("},{"line_number":20,"context_line":"  $discover_nodes,"},{"line_number":21,"context_line":"  $statsd_host,"},{"line_number":22,"context_line":"  $subunit2sql_db_host,"},{"line_number":23,"context_line":"  $subunit2sql_db_pass,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_a4e2d1ff","line":20,"updated":"2015-08-10 22:22:16.000000000","message":"Done","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::logstash ("},{"line_number":20,"context_line":"  $discover_nodes,"},{"line_number":21,"context_line":"  $statsd_host,"},{"line_number":22,"context_line":"  $subunit2sql_db_host,"},{"line_number":23,"context_line":"  $subunit2sql_db_pass,"},{"line_number":24,"context_line":"  $log_processor_config,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_78422640","line":21,"updated":"2015-08-04 23:26:08.000000000","message":"Follow-up change should make the statsd_host optional, or can we default now to localhost?","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::logstash ("},{"line_number":20,"context_line":"  $discover_nodes,"},{"line_number":21,"context_line":"  $statsd_host,"},{"line_number":22,"context_line":"  $subunit2sql_db_host,"},{"line_number":23,"context_line":"  $subunit2sql_db_pass,"},{"line_number":24,"context_line":"  $log_processor_config,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_44f18dcc","line":21,"updated":"2015-08-10 22:22:16.000000000","message":"The way value is used, it could default to empty string. I am not certain what is the best way, would leave for followup.","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"c57d5a2e7bde78cf436ec395ff9f32542996a88d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::logstash ("},{"line_number":20,"context_line":"  $discover_nodes \u003d [\u0027localhost\u0027],"},{"line_number":21,"context_line":"  $statsd_host,"},{"line_number":22,"context_line":"  $subunit2sql_db_host,"},{"line_number":23,"context_line":"  $subunit2sql_db_pass,"},{"line_number":24,"context_line":"  $log_processor_config,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"da20952f_25a619c2","line":21,"updated":"2015-08-26 18:31:20.000000000","message":"I did here where it gets set to undef:\nhttps://git.openstack.org/cgit/openstack-infra/puppet-nodepool/tree/manifests/init.pp#n26","commit_id":"fc1f2e128920445e66ce0069cf6343f0898039cc"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"b6723923c9af444a66f351ff7787f02636ad5d1c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    proxy_elasticsearch \u003d\u003e true,"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  class { \u0027log_processor\u0027: }"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  class { \u0027log_processor::client\u0027:"},{"line_number":36,"context_line":"    config_file \u003d\u003e $log_processor_config,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a26ad4f_030a7e79","line":33,"updated":"2015-10-30 22:25:22.000000000","message":"This should be broken out into another class, not all deployments will want to have the log_processor gearman server and the logstash web service on the same host.","commit_id":"95146ff74c7c96fb8dbc4e0169b65c4e93f474f9"},{"author":{"_account_id":6039,"name":"Joni Harker","email":"code@gentlydownthe.net","username":"jesusaurus"},"change_message_id":"b6723923c9af444a66f351ff7787f02636ad5d1c","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    statsd_host \u003d\u003e $statsd_host,"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include subunit2sql"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  class { \u0027subunit2sql::server\u0027:"},{"line_number":43,"context_line":"    db_host \u003d\u003e $subunit2sql_db_host,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a26ad4f_230f7a89","line":40,"updated":"2015-10-30 22:25:22.000000000","message":"This should be broken out into another class, not all deployments will want to have the subunit2sql database and the logstash web service on the same host.","commit_id":"95146ff74c7c96fb8dbc4e0169b65c4e93f474f9"}],"manifests/logstash_worker.pp":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6f27789e90ab07e5dc195f09468467ed6d91bbca","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  include log_processor"},{"line_number":39,"context_line":"  log_processor::worker { \u0027A\u0027:"},{"line_number":40,"context_line":"    config_file \u003d\u003e $log_processor_config,"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":"  log_processor::worker { \u0027B\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_f7b45bd2","line":39,"updated":"2015-07-11 22:30:02.000000000","message":"Added $log_processor_workers parameter. It is array of the form [\u0027A\u0027, \u0027B\u0027] that is expanded into corresponding workers. But, the same way as it is now, extra workers would not be automatically disabled when removed from the array.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"cc9b3d5ee9261866f80a4132fa0b2f26d901710a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  include log_processor"},{"line_number":39,"context_line":"  log_processor::worker { \u0027A\u0027:"},{"line_number":40,"context_line":"    config_file \u003d\u003e $log_processor_config,"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":"  log_processor::worker { \u0027B\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_b2c81e58","line":39,"updated":"2015-07-10 09:16:28.000000000","message":"do we want a fixed number of log processors?","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6f27789e90ab07e5dc195f09468467ed6d91bbca","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  class { \u0027::elasticsearch\u0027:"},{"line_number":53,"context_line":"    es_template_config \u003d\u003e {"},{"line_number":54,"context_line":"      \u0027gateway.recover_after_nodes\u0027          \u003d\u003e \u00275\u0027,"},{"line_number":55,"context_line":"      \u0027gateway.recover_after_time\u0027           \u003d\u003e \u00275m\u0027,"},{"line_number":56,"context_line":"      \u0027gateway.expected_nodes\u0027               \u003d\u003e \u00276\u0027,"},{"line_number":57,"context_line":"      \u0027discovery.zen.minimum_master_nodes\u0027   \u003d\u003e \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_97caaf4e","line":54,"updated":"2015-07-11 22:30:02.000000000","message":"Done. Parametrized recover time and number of nodes.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"cc9b3d5ee9261866f80a4132fa0b2f26d901710a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  class { \u0027::elasticsearch\u0027:"},{"line_number":53,"context_line":"    es_template_config \u003d\u003e {"},{"line_number":54,"context_line":"      \u0027gateway.recover_after_nodes\u0027          \u003d\u003e \u00275\u0027,"},{"line_number":55,"context_line":"      \u0027gateway.recover_after_time\u0027           \u003d\u003e \u00275m\u0027,"},{"line_number":56,"context_line":"      \u0027gateway.expected_nodes\u0027               \u003d\u003e \u00276\u0027,"},{"line_number":57,"context_line":"      \u0027discovery.zen.minimum_master_nodes\u0027   \u003d\u003e \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_528bd21e","line":54,"updated":"2015-07-10 09:16:28.000000000","message":"can these times be parameterized?","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::logstash_worker ("},{"line_number":20,"context_line":"  $elasticsearch_nodes \u003d [],"},{"line_number":21,"context_line":"  $log_processor_config,"},{"line_number":22,"context_line":"  $heap_size \u003d \u00271g\u0027,"},{"line_number":23,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":24,"context_line":"  # Increase the indexer max heap size to twice the default."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_c4dcbd48","line":21,"updated":"2015-08-10 22:22:16.000000000","message":"The current config used for Infra is infra-specific. Adding default now would require creating a parametrized template, which I\u0027d rather do in a followup.","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class openstackci::logstash_worker ("},{"line_number":20,"context_line":"  $elasticsearch_nodes \u003d [],"},{"line_number":21,"context_line":"  $log_processor_config,"},{"line_number":22,"context_line":"  $heap_size \u003d \u00271g\u0027,"},{"line_number":23,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":24,"context_line":"  # Increase the indexer max heap size to twice the default."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_7821c64c","line":21,"updated":"2015-08-04 23:26:08.000000000","message":"no default config?","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class openstackci::logstash_worker ("},{"line_number":20,"context_line":"  $elasticsearch_nodes \u003d [],"},{"line_number":21,"context_line":"  $log_processor_config,"},{"line_number":22,"context_line":"  $heap_size \u003d \u00271g\u0027,"},{"line_number":23,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":24,"context_line":"  # Increase the indexer max heap size to twice the default."},{"line_number":25,"context_line":"  # Default is 25% of memory or 1g whichever is less."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_e4df7938","line":22,"updated":"2015-08-10 22:22:16.000000000","message":"Done","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class openstackci::logstash_worker ("},{"line_number":20,"context_line":"  $elasticsearch_nodes \u003d [],"},{"line_number":21,"context_line":"  $log_processor_config,"},{"line_number":22,"context_line":"  $heap_size \u003d \u00271g\u0027,"},{"line_number":23,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":24,"context_line":"  # Increase the indexer max heap size to twice the default."},{"line_number":25,"context_line":"  # Default is 25% of memory or 1g whichever is less."}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_381b3e1d","line":22,"updated":"2015-08-04 23:26:08.000000000","message":"prefix with es?","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  $elasticsearch_nodes \u003d [],"},{"line_number":21,"context_line":"  $log_processor_config,"},{"line_number":22,"context_line":"  $heap_size \u003d \u00271g\u0027,"},{"line_number":23,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":24,"context_line":"  # Increase the indexer max heap size to twice the default."},{"line_number":25,"context_line":"  # Default is 25% of memory or 1g whichever is less."},{"line_number":26,"context_line":"  $indexer_java_args \u003d \u0027-Xmx2g\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_84e79511","line":23,"updated":"2015-08-10 22:22:16.000000000","message":"Done","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  $elasticsearch_nodes \u003d [],"},{"line_number":21,"context_line":"  $log_processor_config,"},{"line_number":22,"context_line":"  $heap_size \u003d \u00271g\u0027,"},{"line_number":23,"context_line":"  $version \u003d \u00270.90.9\u0027,"},{"line_number":24,"context_line":"  # Increase the indexer max heap size to twice the default."},{"line_number":25,"context_line":"  # Default is 25% of memory or 1g whichever is less."},{"line_number":26,"context_line":"  $indexer_java_args \u003d \u0027-Xmx2g\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_58164af2","line":23,"updated":"2015-08-04 23:26:08.000000000","message":"prefix with es?","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  include log_processor"},{"line_number":48,"context_line":"  log_processor::worker { $log_processor_workers:"},{"line_number":49,"context_line":"    config_file \u003d\u003e $log_processor_config,"},{"line_number":50,"context_line":"  }"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_d85b3af5","line":48,"updated":"2015-08-04 23:26:08.000000000","message":"Interesting. I didn\u0027t know you can pass an array here.","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"}],"manifests/subunit_worker.pp":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"8d78da559da8fc2b8ad1b84fc609866391e6858a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  subunit2sql::worker { \u0027A\u0027:"},{"line_number":27,"context_line":"    config_file \u003d\u003e $subunit2sql_config_file,"},{"line_number":28,"context_line":"    db_host     \u003d\u003e $subunit2sql_db_host,"},{"line_number":29,"context_line":"    db_pass     \u003d\u003e $subunit2sql_db_pass,"},{"line_number":30,"context_line":"  }"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba3cc151_766aaab4","line":29,"updated":"2015-07-09 17:11:28.000000000","message":"This class uses logstash user/group, but does not set them up. So it would result in error if someone uses this as is. The proper fix is probably through subunit2sql module. But we can add a workaround here by creating required users. I would add it with the next patch.","commit_id":"4b6651361da2a9448751a3377f1a92332986f7ba"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  # [mmedvede]: subunit2sql is supposed to create users it uses,"},{"line_number":37,"context_line":"  # but it doesn\u0027t yet."},{"line_number":38,"context_line":"  user {\u0027logstash\u0027:"},{"line_number":39,"context_line":"    ensure \u003d\u003e present,"},{"line_number":40,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_441aed18","line":37,"updated":"2015-08-10 22:22:16.000000000","message":"Done","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  # [mmedvede]: subunit2sql is supposed to create users it uses,"},{"line_number":37,"context_line":"  # but it doesn\u0027t yet."},{"line_number":38,"context_line":"  user {\u0027logstash\u0027:"},{"line_number":39,"context_line":"    ensure \u003d\u003e present,"},{"line_number":40,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_f8a156aa","line":37,"updated":"2015-08-04 23:26:08.000000000","message":"In this case, let\u0027s protect them for easier forwards compatibility:\nif ! defined(User[\u0027logstash\u0027]) {","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    ensure \u003d\u003e present,"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":"  group {\u0027logstash\u0027:"},{"line_number":42,"context_line":"    ensure \u003d\u003e present,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_18e1a2d0","line":42,"updated":"2015-08-04 23:26:08.000000000","message":"if ! defined(Group[\u0027logstash\u0027]) {","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"}],"templates/logstash/indexer.conf.erb":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"a23ffbaf8be9be78359086ba5e1a75637bce7738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba3cc151_8b0739c9","updated":"2015-07-09 00:29:27.000000000","message":"Same as previous - should this be pulled up one level and named \u0027logstash.indexer.conf.erb\u0027?","commit_id":"c3e44793a09efaf96819aab5180cf99c4cff2e1a"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"59fa5e83b897b8c221f5a1386f13b3a7d1ac15fb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"    multiline {"},{"line_number":39,"context_line":"      negate \u003d\u003e false"},{"line_number":40,"context_line":"      pattern \u003d\u003e \"^%{TIMESTAMP_ISO8601}%{SPACE}%{NUMBER}?%{SPACE}?TRACE\""},{"line_number":41,"context_line":"      what \u003d\u003e \"previous\""},{"line_number":42,"context_line":"      stream_identity \u003d\u003e \"%{host}.%{filename}\""},{"line_number":43,"context_line":"    }"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1a4dcd0f_b80c2e95","line":40,"updated":"2015-08-04 23:26:08.000000000","message":"Out of sync a bit. https://git.openstack.org/cgit/openstack-infra/system-config/tree/modules/openstack_project/templates/logstash/indexer.conf.erb#n40\n\n      # NOTE(mriedem): oslo.log 1.2.0 changed the logging_exception_prefix\n      # config option from using TRACE to ERROR so we have to handle both.\n      pattern \u003d\u003e \"^%{TIMESTAMP_ISO8601}%{SPACE}%{NUMBER}?%{SPACE}?(TRACE|ERROR)\"","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"6b9d9951dd4544ad30de5c0858f832dda3abce51","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    }"},{"line_number":38,"context_line":"    multiline {"},{"line_number":39,"context_line":"      negate \u003d\u003e false"},{"line_number":40,"context_line":"      pattern \u003d\u003e \"^%{TIMESTAMP_ISO8601}%{SPACE}%{NUMBER}?%{SPACE}?TRACE\""},{"line_number":41,"context_line":"      what \u003d\u003e \"previous\""},{"line_number":42,"context_line":"      stream_identity \u003d\u003e \"%{host}.%{filename}\""},{"line_number":43,"context_line":"    }"}],"source_content_type":"application/x-erb","patch_set":6,"id":"1a4dcd0f_24d6c127","line":40,"updated":"2015-08-10 22:22:16.000000000","message":"Synced. Also checked all other modules, all up-to-date with system-config","commit_id":"753a8e5329ef22e23ff1cc0a1da4ba7ed3b01711"}]}
