)]}'
{"contrib/single_node_ci_site.pp":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"2c286e03edc3f95cd6afa893151ce10474cf90b2","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"node default {"},{"line_number":24,"context_line":"  # If your fqdn is not resolvable, use your ip address"},{"line_number":25,"context_line":"  $vhost_name \u003d hiera(\u0027vhost_name\u0027, $::fqdn)"},{"line_number":26,"context_line":"  $project_config_repo \u003d hiera(\u0027project_config_repo\u0027, \u0027XXX\u0027)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  # Jenkins Configurations"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_362d4a46","line":25,"updated":"2015-09-23 22:47:59.000000000","message":"Most of the parameters can be assigned directly inside the class below. No need create a variable if it is only used once ($vhost_name is exception)","commit_id":"181732fed85dd852aae847cc4f8bbbd69d575f94"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"78139106a7767495524d2eb40836b51a97793092","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    jenkins_username            \u003d\u003e hiera(\u0027jenkins_username\u0027, \u0027jenkins\u0027),"},{"line_number":32,"context_line":"    jenkins_password            \u003d\u003e hiera(\u0027jenkins_password\u0027, \u0027XXX\u0027),"},{"line_number":33,"context_line":"    jenkins_ssh_private_key     \u003d\u003e hiera(\u0027jenkins_ssh_private_key\u0027, \u0027XXX\u0027),"},{"line_number":34,"context_line":"    jenkins_ssh_public_key      \u003d\u003e hiera(\u0027jenkins_ssh_public_key\u0027, \u0027XXX\u0027),"},{"line_number":35,"context_line":"    gerrit_server               \u003d\u003e hiera(\u0027gerrit_server\u0027, \u0027review.openstack.org\u0027),"},{"line_number":36,"context_line":"    gerrit_user                 \u003d\u003e hiera(\u0027gerrit_user\u0027, \u0027XXX\u0027),"},{"line_number":37,"context_line":"    gerrit_user_ssh_public_key  \u003d\u003e hiera(\u0027gerrit_user_ssh_public_key\u0027, \u0027XXX\u0027),"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"9a1a9d01_bc4544b4","line":34,"updated":"2015-10-02 07:23:21.000000000","message":"these default values such as keys will cause problems as this is not a valid key. Maybe we can just make the hiera value mandatory?","commit_id":"fa1ff5825cb4e3fa90bc1f58768dde68ce56b7b2"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"fc9f80c64951993390a18bbb1927892b2e9cdf63","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    jenkins_username            \u003d\u003e hiera(\u0027jenkins_username\u0027, \u0027jenkins\u0027),"},{"line_number":32,"context_line":"    jenkins_password            \u003d\u003e hiera(\u0027jenkins_password\u0027, \u0027XXX\u0027),"},{"line_number":33,"context_line":"    jenkins_ssh_private_key     \u003d\u003e hiera(\u0027jenkins_ssh_private_key\u0027, \u0027XXX\u0027),"},{"line_number":34,"context_line":"    jenkins_ssh_public_key      \u003d\u003e hiera(\u0027jenkins_ssh_public_key\u0027, \u0027XXX\u0027),"},{"line_number":35,"context_line":"    gerrit_server               \u003d\u003e hiera(\u0027gerrit_server\u0027, \u0027review.openstack.org\u0027),"},{"line_number":36,"context_line":"    gerrit_user                 \u003d\u003e hiera(\u0027gerrit_user\u0027, \u0027XXX\u0027),"},{"line_number":37,"context_line":"    gerrit_user_ssh_public_key  \u003d\u003e hiera(\u0027gerrit_user_ssh_public_key\u0027, \u0027XXX\u0027),"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"9a1a9d01_bac99bae","line":34,"in_reply_to":"9a1a9d01_82ba496d","updated":"2015-10-03 07:08:43.000000000","message":"Well, from my tests, if you try to add a key with XXX it will just simply fail, services won\u0027t start . And having a default value that doesn\u0027t even work sounds like a bad idea to me. From my experience in sandbox deployments, it\u0027s even worse, because it\u0027s hiding the problem, so we get errors from certs and keys, instead having a clear hiera message about \"missing keys\".\nSo rather than following a pattern that i think is buggy, better fix that, and fix in system-config as well...","commit_id":"fa1ff5825cb4e3fa90bc1f58768dde68ce56b7b2"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"acd6abd58ecf9e9deef54d997548d574fc6cceed","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    jenkins_username            \u003d\u003e hiera(\u0027jenkins_username\u0027, \u0027jenkins\u0027),"},{"line_number":32,"context_line":"    jenkins_password            \u003d\u003e hiera(\u0027jenkins_password\u0027, \u0027XXX\u0027),"},{"line_number":33,"context_line":"    jenkins_ssh_private_key     \u003d\u003e hiera(\u0027jenkins_ssh_private_key\u0027, \u0027XXX\u0027),"},{"line_number":34,"context_line":"    jenkins_ssh_public_key      \u003d\u003e hiera(\u0027jenkins_ssh_public_key\u0027, \u0027XXX\u0027),"},{"line_number":35,"context_line":"    gerrit_server               \u003d\u003e hiera(\u0027gerrit_server\u0027, \u0027review.openstack.org\u0027),"},{"line_number":36,"context_line":"    gerrit_user                 \u003d\u003e hiera(\u0027gerrit_user\u0027, \u0027XXX\u0027),"},{"line_number":37,"context_line":"    gerrit_user_ssh_public_key  \u003d\u003e hiera(\u0027gerrit_user_ssh_public_key\u0027, \u0027XXX\u0027),"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"9a1a9d01_82ba496d","line":34,"in_reply_to":"9a1a9d01_bc4544b4","updated":"2015-10-02 15:18:05.000000000","message":"I am following the pattern used here: http://git.openstack.org/cgit/openstack-infra/system-config/tree/manifests/site.pp\n\nI don\u0027t mind to diverge, but would like to see if there\u0027s a particular reason using \u0027XXX\u0027 was used there.","commit_id":"fa1ff5825cb4e3fa90bc1f58768dde68ce56b7b2"}],"manifests/single_node_ci.pp":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"8e36df456eb34d3b2101aa32ef6d6c973c9f8b5e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# called the \"project-config data repository\"."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"node default {"},{"line_number":23,"context_line":"  $vhost_name \u003d $::fqdn"},{"line_number":24,"context_line":"  $project_config_repo \u003d hiera(\u0027project_config_repo\u0027, \u0027XXX\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  #Jenkins Configurations"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_36704ddc","line":23,"updated":"2015-09-22 04:30:49.000000000","message":"put these all in hiera with defaults where possible.\nAlso add a note that if the fqdn is not resolvable by dns or host file, use an ip address here","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3e9b9bb56fbc9453a6c1ae2145a2847877d7f818","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# called the \"project-config data repository\"."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"node default {"},{"line_number":23,"context_line":"  $vhost_name \u003d $::fqdn"},{"line_number":24,"context_line":"  $project_config_repo \u003d hiera(\u0027project_config_repo\u0027, \u0027XXX\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  #Jenkins Configurations"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_37b02b43","line":23,"in_reply_to":"ba15a1d1_36704ddc","updated":"2015-09-22 18:02:26.000000000","message":"Done","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"8e36df456eb34d3b2101aa32ef6d6c973c9f8b5e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $git_email \u003d hiera(\u0027git_email\u0027, \u0027XXX\u0027)"},{"line_number":40,"context_line":"  $git_name \u003d hiera(\u0027git_name\u0027, \u0027XXX\u0027)"},{"line_number":41,"context_line":"  $log_server \u003d hiera(\u0027log_server\u0027, \u0027XXX\u0027)"},{"line_number":42,"context_line":"  $logs_url_pattern \u003d \"http://${log_server}/{build.parameters[LOG_PATH]}\""},{"line_number":43,"context_line":"  $smtp_host \u003d hiera(\u0027smtp_host\u0027, \u0027localhost\u0027)"},{"line_number":44,"context_line":"  $zuul_revision \u003d \u0027master\u0027"},{"line_number":45,"context_line":"  $zuul_git_source_repo \u003d \u0027https://git.openstack.org/openstack-infra/zuul\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_3615ad48","line":42,"updated":"2015-09-22 04:30:49.000000000","message":"Does this need to be a variable or can it be used directly?","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3e9b9bb56fbc9453a6c1ae2145a2847877d7f818","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  $git_email \u003d hiera(\u0027git_email\u0027, \u0027XXX\u0027)"},{"line_number":40,"context_line":"  $git_name \u003d hiera(\u0027git_name\u0027, \u0027XXX\u0027)"},{"line_number":41,"context_line":"  $log_server \u003d hiera(\u0027log_server\u0027, \u0027XXX\u0027)"},{"line_number":42,"context_line":"  $logs_url_pattern \u003d \"http://${log_server}/{build.parameters[LOG_PATH]}\""},{"line_number":43,"context_line":"  $smtp_host \u003d hiera(\u0027smtp_host\u0027, \u0027localhost\u0027)"},{"line_number":44,"context_line":"  $zuul_revision \u003d \u0027master\u0027"},{"line_number":45,"context_line":"  $zuul_git_source_repo \u003d \u0027https://git.openstack.org/openstack-infra/zuul\u0027"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_9744971b","line":42,"in_reply_to":"ba15a1d1_3615ad48","updated":"2015-09-22 18:02:26.000000000","message":"Done","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"8e36df456eb34d3b2101aa32ef6d6c973c9f8b5e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      \u0027NODEPOOL_SSH_KEY\u0027 \u003d\u003e $jenkins_ssh_public_key"},{"line_number":110,"context_line":"    },"},{"line_number":111,"context_line":"    project_config_repo       \u003d\u003e $project_config_repo,"},{"line_number":112,"context_line":"    enable_image_log_via_http \u003d\u003e false,"},{"line_number":113,"context_line":"    jenkins_masters           \u003d\u003e ["},{"line_number":114,"context_line":"      { name        \u003d\u003e \u0027local-jenkins\u0027,"},{"line_number":115,"context_line":"        url         \u003d\u003e \u0027http://localhost:8080/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_d13a3bcd","line":112,"updated":"2015-09-22 04:30:49.000000000","message":"Add a comment that enabling this to true would conflict with the zuul status page.","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3e9b9bb56fbc9453a6c1ae2145a2847877d7f818","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      \u0027NODEPOOL_SSH_KEY\u0027 \u003d\u003e $jenkins_ssh_public_key"},{"line_number":110,"context_line":"    },"},{"line_number":111,"context_line":"    project_config_repo       \u003d\u003e $project_config_repo,"},{"line_number":112,"context_line":"    enable_image_log_via_http \u003d\u003e false,"},{"line_number":113,"context_line":"    jenkins_masters           \u003d\u003e ["},{"line_number":114,"context_line":"      { name        \u003d\u003e \u0027local-jenkins\u0027,"},{"line_number":115,"context_line":"        url         \u003d\u003e \u0027http://localhost:8080/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_318594ac","line":112,"in_reply_to":"ba15a1d1_d13a3bcd","updated":"2015-09-22 18:02:26.000000000","message":"Done","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"8e36df456eb34d3b2101aa32ef6d6c973c9f8b5e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    project_config_repo       \u003d\u003e $project_config_repo,"},{"line_number":112,"context_line":"    enable_image_log_via_http \u003d\u003e false,"},{"line_number":113,"context_line":"    jenkins_masters           \u003d\u003e ["},{"line_number":114,"context_line":"      { name        \u003d\u003e \u0027local-jenkins\u0027,"},{"line_number":115,"context_line":"        url         \u003d\u003e \u0027http://localhost:8080/\u0027,"},{"line_number":116,"context_line":"        user        \u003d\u003e $jenkins_username,"},{"line_number":117,"context_line":"        apikey      \u003d\u003e $jenkins_api_key,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_56bce16b","line":114,"updated":"2015-09-22 04:30:49.000000000","message":"Need to check how this syncs with nodepool configuration in project-config","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3e9b9bb56fbc9453a6c1ae2145a2847877d7f818","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    project_config_repo       \u003d\u003e $project_config_repo,"},{"line_number":112,"context_line":"    enable_image_log_via_http \u003d\u003e false,"},{"line_number":113,"context_line":"    jenkins_masters           \u003d\u003e ["},{"line_number":114,"context_line":"      { name        \u003d\u003e \u0027local-jenkins\u0027,"},{"line_number":115,"context_line":"        url         \u003d\u003e \u0027http://localhost:8080/\u0027,"},{"line_number":116,"context_line":"        user        \u003d\u003e $jenkins_username,"},{"line_number":117,"context_line":"        apikey      \u003d\u003e $jenkins_api_key,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"ba15a1d1_729f9103","line":114,"in_reply_to":"ba15a1d1_56bce16b","updated":"2015-09-22 18:02:26.000000000","message":"Done","commit_id":"83323f4a23476dff6120d22c0a8d13d47e07e65f"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"cadae231f829f0fc67a304a22baaba0a7efabe73","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# A sample puppet node configuration that installs and configures Jenkins,"},{"line_number":18,"context_line":"# Zuul, Nodepool, Jenkins Job Builder, onto a single VM using the"},{"line_number":19,"context_line":"# specified project-config repository and other configurations stored in hiera."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"node default {"},{"line_number":22,"context_line":"  # If your fqdn is not resolvable, use your ip address"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba15a1d1_66b3259b","line":19,"updated":"2015-09-23 15:51:40.000000000","message":"Maybe add:\n# Zuul UI would be available on port 80, and Jenkins on 8080.","commit_id":"bc024d50532c0182ca857d4eda70c7c163ef898f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"e44527d20bec26491a327c085549be3affbee214","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# A sample puppet node configuration that installs and configures Jenkins,"},{"line_number":18,"context_line":"# Zuul, Nodepool, Jenkins Job Builder, onto a single VM using the"},{"line_number":19,"context_line":"# specified project-config repository and other configurations stored in hiera."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"node default {"},{"line_number":22,"context_line":"  # If your fqdn is not resolvable, use your ip address"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba15a1d1_0d64c5b6","line":19,"in_reply_to":"ba15a1d1_66b3259b","updated":"2015-09-23 16:57:30.000000000","message":"Done","commit_id":"bc024d50532c0182ca857d4eda70c7c163ef898f"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"cadae231f829f0fc67a304a22baaba0a7efabe73","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# Zuul, Nodepool, Jenkins Job Builder, onto a single VM using the"},{"line_number":19,"context_line":"# specified project-config repository and other configurations stored in hiera."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"node default {"},{"line_number":22,"context_line":"  # If your fqdn is not resolvable, use your ip address"},{"line_number":23,"context_line":"  $vhost_name \u003d hiera(\u0027vhost_name\u0027, $::fqdn)"},{"line_number":24,"context_line":"  $project_config_repo \u003d hiera(\u0027project_config_repo\u0027, \u0027XXX\u0027)"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba15a1d1_da952833","line":21,"updated":"2015-09-23 15:51:40.000000000","message":"Do I get it right: this is only intended to be used in masterless environment? I have tried to come up with a way to test it with puppet master that has other nodes, and it would not work, as it would clobber them.\n\nTo avoid that, we can define class instead, e.g. \"class single_node_ci (){\". And then add example of how to use it: node allinone-ci { class { \u0027::openstackci::single_node_ci\u0027:}}.","commit_id":"bc024d50532c0182ca857d4eda70c7c163ef898f"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"e44527d20bec26491a327c085549be3affbee214","unresolved":false,"context_lines":[{"line_number":18,"context_line":"# Zuul, Nodepool, Jenkins Job Builder, onto a single VM using the"},{"line_number":19,"context_line":"# specified project-config repository and other configurations stored in hiera."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"node default {"},{"line_number":22,"context_line":"  # If your fqdn is not resolvable, use your ip address"},{"line_number":23,"context_line":"  $vhost_name \u003d hiera(\u0027vhost_name\u0027, $::fqdn)"},{"line_number":24,"context_line":"  $project_config_repo \u003d hiera(\u0027project_config_repo\u0027, \u0027XXX\u0027)"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"ba15a1d1_ed04f17e","line":21,"in_reply_to":"ba15a1d1_da952833","updated":"2015-09-23 16:57:30.000000000","message":"I only tested in masterless puppet environment. I had it originally as 2 classes, but thought this would be simpler. I\u0027ll change it after we discuss the best way to separate it out.","commit_id":"bc024d50532c0182ca857d4eda70c7c163ef898f"}]}