)]}'
{"manifests/logserver.pp":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"b2de6e589f1f2e60cdc0b4caa9c5d36ecd410fbf","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $swift_region_name \u003d \u0027\u0027,"},{"line_number":26,"context_line":"  $swift_default_container \u003d \u0027\u0027,"},{"line_number":27,"context_line":"  $ssl \u003d false,"},{"line_number":28,"context_line":"  $ssl_cert_file \u003d \u0027\u0027,"},{"line_number":29,"context_line":"  $ssl_cert_file_contents \u003d \u0027\u0027,"},{"line_number":30,"context_line":"  $ssl_key_file \u003d \u0027\u0027,"},{"line_number":31,"context_line":"  $ssl_key_file_contents \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a29b11f_8094b344","line":28,"updated":"2015-10-23 22:09:44.000000000","message":"use \u0027undef\u0027 instead of empty string for all of these and comparisons below. \nI thought there was a check that verified for this....","commit_id":"4b9361344322ccd12c8873ce18d1ab3d7d1fdb95"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c061034944ca2aa0ff5b05cfe8c0edd7378d0db5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $swift_region_name \u003d \u0027\u0027,"},{"line_number":26,"context_line":"  $swift_default_container \u003d \u0027\u0027,"},{"line_number":27,"context_line":"  $ssl \u003d false,"},{"line_number":28,"context_line":"  $ssl_cert_file \u003d \u0027\u0027,"},{"line_number":29,"context_line":"  $ssl_cert_file_contents \u003d \u0027\u0027,"},{"line_number":30,"context_line":"  $ssl_key_file \u003d \u0027\u0027,"},{"line_number":31,"context_line":"  $ssl_key_file_contents \u003d \u0027\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_dc146245","line":28,"in_reply_to":"3a29b11f_8094b344","updated":"2015-11-10 15:47:24.000000000","message":"What about for the other parameters above? Should we not have a separate change which switches defaults for everything from a null string to undef for consistency? I\u0027m attempting to stick to the local convention in the file I\u0027m patching, which seems to be using null strings so far.","commit_id":"4b9361344322ccd12c8873ce18d1ab3d7d1fdb95"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"47983b1910b1e955d5916bd1d25323e95374068c","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    ::httpd::vhost { \"logs.${domain}\":"},{"line_number":164,"context_line":"      port       \u003d\u003e 443, # Is required despite not being used."},{"line_number":165,"context_line":"      docroot    \u003d\u003e \u0027/srv/static/logs\u0027,"},{"line_number":166,"context_line":"      priority   \u003d\u003e \u002750\u0027,"},{"line_number":167,"context_line":"      ssl        \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9aed3d3a_73e69ab5","line":164,"updated":"2016-02-26 11:12:38.000000000","message":"Right you are. This and the 80 below, and in the logs-dev vhost, are copy-pasted from vhost resources where the comment was true. I\u0027ll fix in a new patchset. Thanks for spotting!","commit_id":"4b9361344322ccd12c8873ce18d1ab3d7d1fdb95"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"0d6370be71f7b869761f053e1dad10bad99ca497","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    }"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    ::httpd::vhost { \"logs.${domain}\":"},{"line_number":164,"context_line":"      port       \u003d\u003e 443, # Is required despite not being used."},{"line_number":165,"context_line":"      docroot    \u003d\u003e \u0027/srv/static/logs\u0027,"},{"line_number":166,"context_line":"      priority   \u003d\u003e \u002750\u0027,"},{"line_number":167,"context_line":"      ssl        \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a8ffd7b_562d7444","line":164,"updated":"2015-12-03 03:03:16.000000000","message":"What do you mean by this comment? The port is used in line 6 of logs*.vhost.erb","commit_id":"4b9361344322ccd12c8873ce18d1ab3d7d1fdb95"}]}
