)]}'
{"manifests/single_node_ci.pp":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"ba77c074def9fcda490498aa048b9eaf7c85231b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*log_server_external*]"},{"line_number":91,"context_line":"#   This is the external FQDN/IP address to access the log server,"},{"line_number":92,"context_line":"#   which is equal to $log_server in most cases."},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*smtp_host*]"},{"line_number":95,"context_line":"#   The smtp hostname to use for zuul to send notification e-mails"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_13a10746","line":92,"updated":"2015-12-22 04:47:37.000000000","message":"It not clear when this is needed.","commit_id":"b7953b5ad0c22dabfd28b16b36ef9c07ad40a0bb"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"26ed684cbe18a7d45ae172b8a215051acf854eef","unresolved":false,"context_lines":[{"line_number":89,"context_line":"#"},{"line_number":90,"context_line":"# [*log_server_external*]"},{"line_number":91,"context_line":"#   This is the external FQDN/IP address to access the log server,"},{"line_number":92,"context_line":"#   which is equal to $log_server in most cases."},{"line_number":93,"context_line":"#"},{"line_number":94,"context_line":"# [*smtp_host*]"},{"line_number":95,"context_line":"#   The smtp hostname to use for zuul to send notification e-mails"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_6c509b5f","line":92,"in_reply_to":"3a7e1126_13a10746","updated":"2015-12-22 13:19:30.000000000","message":"We have 2 DNS domains for a log server: one internal and one external (points to a distinct externally exposed IP).\nThe external IP is not accessible from internal network, so in all other places we should address log server by first DNS name ($log_server). That\u0027s the motivation behind this.","commit_id":"b7953b5ad0c22dabfd28b16b36ef9c07ad40a0bb"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"ba77c074def9fcda490498aa048b9eaf7c85231b","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    gerrit_user          \u003d\u003e $gerrit_user,"},{"line_number":222,"context_line":"    known_hosts_content  \u003d\u003e $gerrit_ssh_host_key,"},{"line_number":223,"context_line":"    zuul_ssh_private_key \u003d\u003e $gerrit_user_ssh_private_key,"},{"line_number":224,"context_line":"    url_pattern          \u003d\u003e \"http://${log_server_external}/{build.parameters[LOG_PATH]}\","},{"line_number":225,"context_line":"    zuul_url             \u003d\u003e \"http://${vhost_name}/p/\","},{"line_number":226,"context_line":"    job_name_in_report   \u003d\u003e true,"},{"line_number":227,"context_line":"    status_url           \u003d\u003e \"http://${vhost_name}\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_fa3f87b1","line":224,"updated":"2015-12-22 04:47:37.000000000","message":"would using $log_server here work instead if it were defaulted to vhost_name?","commit_id":"b7953b5ad0c22dabfd28b16b36ef9c07ad40a0bb"},{"author":{"_account_id":13431,"name":"Evgeny Antyshev","email":"eantyshev@gmail.com","username":"eantyshev"},"change_message_id":"26ed684cbe18a7d45ae172b8a215051acf854eef","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    gerrit_user          \u003d\u003e $gerrit_user,"},{"line_number":222,"context_line":"    known_hosts_content  \u003d\u003e $gerrit_ssh_host_key,"},{"line_number":223,"context_line":"    zuul_ssh_private_key \u003d\u003e $gerrit_user_ssh_private_key,"},{"line_number":224,"context_line":"    url_pattern          \u003d\u003e \"http://${log_server_external}/{build.parameters[LOG_PATH]}\","},{"line_number":225,"context_line":"    zuul_url             \u003d\u003e \"http://${vhost_name}/p/\","},{"line_number":226,"context_line":"    job_name_in_report   \u003d\u003e true,"},{"line_number":227,"context_line":"    status_url           \u003d\u003e \"http://${vhost_name}\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_acd443bd","line":224,"in_reply_to":"3a7e1126_fa3f87b1","updated":"2015-12-22 13:19:30.000000000","message":"Considering what I wrote to above comment, no.","commit_id":"b7953b5ad0c22dabfd28b16b36ef9c07ad40a0bb"}]}
