)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"057c8bee4c16a4b49b44e5a772a4c034a7b15915","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Isaac Beckman \u003cisaacb@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-03 13:07:19 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass java heap size as parameter to jenkins master puppet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Passing heap size to jenkins puppet allows to tune jenkins"},{"line_number":10,"context_line":"master virtual memory consumption. This is usefull for downstream"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_c6710caa","line":7,"range":{"start_line":7,"start_character":51,"end_line":7,"end_character":57},"updated":"2016-01-03 11:51:06.000000000","message":"should be limited to 50 characters","commit_id":"513182f1cba1ee3cfe4eb85833ba47edc864f7ce"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"057c8bee4c16a4b49b44e5a772a4c034a7b15915","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Passing heap size to jenkins puppet allows to tune jenkins"},{"line_number":10,"context_line":"master virtual memory consumption. This is usefull for downstream"},{"line_number":11,"context_line":"projects where the jenkins master have relatively small amount of"},{"line_number":12,"context_line":"jobs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I745a23b0f177f868d5406639bc8c42e3acacea72"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa69d971_465e7c13","line":11,"range":{"start_line":11,"start_character":34,"end_line":11,"end_character":38},"updated":"2016-01-03 11:51:06.000000000","message":"have -\u003e has","commit_id":"513182f1cba1ee3cfe4eb85833ba47edc864f7ce"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"ea3084059adb09ddd1a70d0b093780ebd53bdb96","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass java heap size as parameter to jenkins master"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Passing heap size to jenkins puppet allows to tune jenkins"},{"line_number":10,"context_line":"master virtual memory consumption. This is usefull for downstream"},{"line_number":11,"context_line":"projects where the jenkins master have relatively small amount of"},{"line_number":12,"context_line":"jobs."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_acfe7936","line":10,"updated":"2016-01-07 17:30:18.000000000","message":"typo: usefull --\u003e useful","commit_id":"c9b3d5c0521416db89caf78d666d944d5cfc2090"}],"contrib/single_node_ci_data.yaml":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3b7d54c561ae32e0867c78c7cc5e2428f74ef3aa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# untrusted access to Jenkins."},{"line_number":11,"context_line":"# see SECURITY-170 in:"},{"line_number":12,"context_line":"# \"https://wiki.jenkins-ci.org/display/SECURITY/Jenkins+Security+Advisory+2016-05-11\""},{"line_number":13,"context_line":"#jenkins_version: present"},{"line_number":14,"context_line":"#jenkins_vhost_name: jenkins"},{"line_number":15,"context_line":"#jenkins_username: jenkins"},{"line_number":16,"context_line":"#jenkins_password:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3a71b18c_d762f3d7","line":13,"updated":"2016-12-08 18:51:28.000000000","message":"We\u0027ve been keeping this file consistent with changes to single_node_ci.pp. Please add the new arg java_args_override  here, leave it blank, but provide the recommended value in comments, noting that it exposes a potential jenkins security vulnerability.","commit_id":"58c3545523ad0e877708d4634c6d499957d315fe"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"980cb1b409d276e40a29c286a504e034781caa1c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  Insert jenkins private key here"},{"line_number":20,"context_line":"  -----END RSA PRIVATE KEY-----"},{"line_number":21,"context_line":"jenkins_ssh_public_key:  your-jenkins-public-key-no-whitespace"},{"line_number":22,"context_line":"java_args_override: |"},{"line_number":23,"context_line":"   # These are the arguments to pass to Java"},{"line_number":24,"context_line":"   # The recommended value:"},{"line_number":25,"context_line":"   # \"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx7g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.confi -Dhudson.model.ParametersAction.keepUndefinedParameters\u003dtrue\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa31d9ce_ad121755","line":22,"updated":"2017-02-14 18:24:32.000000000","message":"I think this line \"java_args_override\" should also remain commented out to ensure that it is only used when explicitly set by the user. When commented out, \u0027undef\u0027 will get used, forcing the puppet-jenkins provided default value to get used.","commit_id":"8524bc263d9a1ee6a4a5d50bc8048a86acd42e3c"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"0f48c699453f6db528491b0644f0fbebab00dcee","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  Insert jenkins private key here"},{"line_number":20,"context_line":"  -----END RSA PRIVATE KEY-----"},{"line_number":21,"context_line":"jenkins_ssh_public_key:  your-jenkins-public-key-no-whitespace"},{"line_number":22,"context_line":"java_args_override: |"},{"line_number":23,"context_line":"   # These are the arguments to pass to Java"},{"line_number":24,"context_line":"   # The recommended value:"},{"line_number":25,"context_line":"   # \"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx7g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.confi -Dhudson.model.ParametersAction.keepUndefinedParameters\u003dtrue\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa31d9ce_5f712c43","line":22,"in_reply_to":"fa31d9ce_ad121755","updated":"2017-02-15 08:13:55.000000000","message":"Done","commit_id":"8524bc263d9a1ee6a4a5d50bc8048a86acd42e3c"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"980cb1b409d276e40a29c286a504e034781caa1c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"   # These are the arguments to pass to Java"},{"line_number":24,"context_line":"   # The recommended value:"},{"line_number":25,"context_line":"   # \"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx7g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.confi -Dhudson.model.ParametersAction.keepUndefinedParameters\u003dtrue\""},{"line_number":26,"context_line":"   # Please note that using the parameter: keepUndefinedParameters\u003dtrue is not secure and exposes a potential jenkins security vulnerability"},{"line_number":27,"context_line":"jjb_git_revision: 1.6.1"},{"line_number":28,"context_line":"#jjb_git_url: https://git.openstack.org/openstack-infra/jenkins-job-builder"},{"line_number":29,"context_line":"#gerrit_server: review.openstack.org"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa31d9ce_4a10a159","line":26,"updated":"2017-02-14 18:24:32.000000000","message":"This value isn\u0027t matching the current default:\n-Xmx12g vs -Xmx7g\n\nYou have an extra \u0027i\u0027 as the last character here: \n-Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.confi","commit_id":"8524bc263d9a1ee6a4a5d50bc8048a86acd42e3c"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"0f48c699453f6db528491b0644f0fbebab00dcee","unresolved":false,"context_lines":[{"line_number":23,"context_line":"   # These are the arguments to pass to Java"},{"line_number":24,"context_line":"   # The recommended value:"},{"line_number":25,"context_line":"   # \"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx7g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.confi -Dhudson.model.ParametersAction.keepUndefinedParameters\u003dtrue\""},{"line_number":26,"context_line":"   # Please note that using the parameter: keepUndefinedParameters\u003dtrue is not secure and exposes a potential jenkins security vulnerability"},{"line_number":27,"context_line":"jjb_git_revision: 1.6.1"},{"line_number":28,"context_line":"#jjb_git_url: https://git.openstack.org/openstack-infra/jenkins-job-builder"},{"line_number":29,"context_line":"#gerrit_server: review.openstack.org"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"fa31d9ce_9f956434","line":26,"in_reply_to":"fa31d9ce_4a10a159","updated":"2017-02-15 08:13:55.000000000","message":"Done","commit_id":"8524bc263d9a1ee6a4a5d50bc8048a86acd42e3c"}],"contrib/single_node_ci_site.pp":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"ede49ffbb6e068e54b5146a056b0dbdeac4538dd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    jenkins_password            \u003d\u003e hiera(\u0027jenkins_password\u0027, \u0027XXX\u0027),"},{"line_number":39,"context_line":"    jenkins_ssh_private_key     \u003d\u003e hiera(\u0027jenkins_ssh_private_key\u0027),"},{"line_number":40,"context_line":"    jenkins_ssh_public_key      \u003d\u003e hiera(\u0027jenkins_ssh_public_key\u0027),"},{"line_number":41,"context_line":"    java_args_override          \u003d\u003e hiera(\u0027java_args_override\u0027),"},{"line_number":42,"context_line":"    gerrit_server               \u003d\u003e hiera(\u0027gerrit_server\u0027, \u0027review.openstack.org\u0027),"},{"line_number":43,"context_line":"    gerrit_user                 \u003d\u003e hiera(\u0027gerrit_user\u0027),"},{"line_number":44,"context_line":"    gerrit_user_ssh_public_key  \u003d\u003e hiera(\u0027gerrit_user_ssh_public_key\u0027),"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"fa31d9ce_ab0e5889","line":41,"updated":"2017-02-15 14:42:58.000000000","message":"default value needs to be undef, otherwise this becomes a required parameter","commit_id":"e09adef744960bd31aee78b28e8faa32717e42e6"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"9be53078fde18fc937d33aa47c475a2d5b1c9bcf","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    jenkins_password            \u003d\u003e hiera(\u0027jenkins_password\u0027, \u0027XXX\u0027),"},{"line_number":39,"context_line":"    jenkins_ssh_private_key     \u003d\u003e hiera(\u0027jenkins_ssh_private_key\u0027),"},{"line_number":40,"context_line":"    jenkins_ssh_public_key      \u003d\u003e hiera(\u0027jenkins_ssh_public_key\u0027),"},{"line_number":41,"context_line":"    java_args_override          \u003d\u003e hiera(\u0027java_args_override\u0027),"},{"line_number":42,"context_line":"    gerrit_server               \u003d\u003e hiera(\u0027gerrit_server\u0027, \u0027review.openstack.org\u0027),"},{"line_number":43,"context_line":"    gerrit_user                 \u003d\u003e hiera(\u0027gerrit_user\u0027),"},{"line_number":44,"context_line":"    gerrit_user_ssh_public_key  \u003d\u003e hiera(\u0027gerrit_user_ssh_public_key\u0027),"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"fa31d9ce_51aba3d6","line":41,"in_reply_to":"fa31d9ce_ab0e5889","updated":"2017-02-16 11:15:38.000000000","message":"Done","commit_id":"e09adef744960bd31aee78b28e8faa32717e42e6"}],"manifests/jenkins_master.pp":[{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"87a575a5240b9ef0c9cc62166cd635b25c2e8267","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $project_config_repo     \u003d \u0027\u0027,"},{"line_number":23,"context_line":"  $project_config_base     \u003d \u0027\u0027,"},{"line_number":24,"context_line":"  $log_server              \u003d undef,"},{"line_number":25,"context_line":"  $jenkins_java_args       \u003d \u0027\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf\"\u0027,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  class { \u0027::jenkins::master\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_8eb74739","line":25,"updated":"2016-02-29 15:10:06.000000000","message":"Why are the quotes needed? Also it would be accessed by a value specified in https://review.openstack.org/#/c/262787/. Then the default value is specified once instead of twice.","commit_id":"d442c8c8623c190ebd0279e8f31d4f6519d4d8aa"},{"author":{"_account_id":13047,"name":"Isaac Beckman","email":"beckmani@gmail.com","username":"isaacb"},"change_message_id":"52e015eda431cf9aaecd1c7303094dc68698fcd3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $project_config_repo     \u003d \u0027\u0027,"},{"line_number":23,"context_line":"  $project_config_base     \u003d \u0027\u0027,"},{"line_number":24,"context_line":"  $log_server              \u003d undef,"},{"line_number":25,"context_line":"  $jenkins_java_args       \u003d \u0027\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf\"\u0027,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  class { \u0027::jenkins::master\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_5a1f895a","line":25,"in_reply_to":"9aed3d3a_8eb74739","updated":"2016-05-23 11:00:07.000000000","message":"The quotes exist in the original /etc/default/jenkins\nSee:\n\n# arguments to pass to java\n#JAVA_ARGS\u003d\"-Xmx256m\"\n#JAVA_ARGS\u003d\"-Djava.net.preferIPv4Stack\u003dtrue\" # make jenkins listen on IPv4 address\n# Disable compression as zip deflation threads eat CPU time.\n# https://issues.jenkins-ci.org/browse/JENKINS-14362\nJAVA_ARGS\u003d\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf\"","commit_id":"d442c8c8623c190ebd0279e8f31d4f6519d4d8aa"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"bdbfca63fd12d5d6742ec00233ff98ab448f5cea","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $project_config_repo     \u003d \u0027\u0027,"},{"line_number":23,"context_line":"  $project_config_base     \u003d \u0027\u0027,"},{"line_number":24,"context_line":"  $log_server              \u003d undef,"},{"line_number":25,"context_line":"  $jenkins_java_args       \u003d \u0027\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf\"\u0027,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  class { \u0027::jenkins::master\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_58436d13","line":25,"in_reply_to":"bab6814e_5a1f895a","updated":"2016-08-04 12:50:37.000000000","message":"Ok, my bad. We should do this and follow-up with another change to support https://review.openstack.org/#/c/334400/3","commit_id":"d442c8c8623c190ebd0279e8f31d4f6519d4d8aa"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"7feb5f55980b0c7fc6b4f741ab0db3e7650ec87e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  $project_config_repo     \u003d \u0027\u0027,"},{"line_number":24,"context_line":"  $project_config_base     \u003d \u0027\u0027,"},{"line_number":25,"context_line":"  $log_server              \u003d undef,"},{"line_number":26,"context_line":"  $jenkins_java_args       \u003d \u0027\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf\"\u0027,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  class { \u0027::jenkins::master\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_f9066f84","line":26,"updated":"2016-12-06 21:00:42.000000000","message":"Depends-On patch was updated, should now use $jenkins_args_override \u003d undef","commit_id":"4f2283b619b6e267dc06a4bd847bb2514d850ec9"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"7feb5f55980b0c7fc6b4f741ab0db3e7650ec87e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    jenkins_ssh_private_key \u003d\u003e $jenkins_ssh_private_key,"},{"line_number":40,"context_line":"    jenkins_ssh_public_key  \u003d\u003e $jenkins_ssh_public_key,"},{"line_number":41,"context_line":"    jenkins_version         \u003d\u003e $jenkins_version,"},{"line_number":42,"context_line":"    java_args               \u003d\u003e $jenkins_java_args,"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  jenkins::plugin { \u0027build-timeout\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_190a4b8a","line":42,"updated":"2016-12-06 21:00:42.000000000","message":"java_args_override \u003d\u003e $jenkins_args_override,","commit_id":"4f2283b619b6e267dc06a4bd847bb2514d850ec9"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3b7d54c561ae32e0867c78c7cc5e2428f74ef3aa","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  $project_config_repo     \u003d \u0027\u0027,"},{"line_number":24,"context_line":"  $project_config_base     \u003d \u0027\u0027,"},{"line_number":25,"context_line":"  $log_server              \u003d undef,"},{"line_number":26,"context_line":"  $java_args_override      \u003d undef,"},{"line_number":27,"context_line":") {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  class { \u0027::jenkins::master\u0027:"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a71b18c_57a50302","line":26,"updated":"2016-12-08 18:51:28.000000000","message":"NIT: Would be nice to keep this one next to the other jenkins vars.","commit_id":"58c3545523ad0e877708d4634c6d499957d315fe"}],"manifests/single_node_ci.pp":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"00b2f2a1bc2ab8d49b1bfaf241416f63aa33980c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*jenkins_java_args*]"},{"line_number":56,"context_line":"#   These are the arguments to pass to Java"},{"line_number":57,"context_line":"#   You can use this to customize java heap size"},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# [*gerrit_server*]"},{"line_number":60,"context_line":"#   This is the host name of the gerrit server this CI system will be"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a5de9d1_75da927a","line":57,"range":{"start_line":57,"start_character":34,"end_line":57,"end_character":38},"updated":"2016-01-27 11:06:50.000000000","message":"i\u0027d rather remove this comment, or expand it. You can customize java heap size, but along with much more features...","commit_id":"ef4736886fe41353eca17d30d1fd124935a220fe"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"26f6a3929045b662764124f9a9212e9c1e67d517","unresolved":false,"context_lines":[{"line_number":161,"context_line":"  $jenkins_password              \u003d undef,"},{"line_number":162,"context_line":"  $jenkins_ssh_private_key       \u003d undef,"},{"line_number":163,"context_line":"  $jenkins_ssh_public_key        \u003d undef,"},{"line_number":164,"context_line":"  $jenkins_java_args             \u003d \u0027\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf -Dhudson.model.ParametersAction.keepUndefinedParameters\u003dtrue\"\u0027,"},{"line_number":165,"context_line":"  $jenkins_version               \u003d \u0027present\u0027,"},{"line_number":166,"context_line":"  $jjb_git_revision              \u003d \u0027master\u0027,"},{"line_number":167,"context_line":"  $jjb_git_url                   \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_e89442e3","line":164,"updated":"2016-12-04 14:43:48.000000000","message":"The default should have the most secure settings available, even it if doens\u0027t work. So please update this should just keep the original defaults here.\n\nInstead, users can customize via hiera data. Update this file with more explanation of how to set this variable in the hieradata to work around the security issues, as an alternative to using Jenkins 1.651, similar to what is already documented.  Also would be nice to include the link to the security issue directly in single_node_ci_data.yaml for reference.\n\nhttp://git.openstack.org/cgit/openstack-infra/puppet-openstackci/tree/contrib/single_node_ci_data.yaml#n7","commit_id":"08b1b2a7d21dca732093b30dc80199f0acb539b5"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"7feb5f55980b0c7fc6b4f741ab0db3e7650ec87e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"#   The public key should not have any white space. Omit the \u0027ssh-rsa\u0027 prefix"},{"line_number":57,"context_line":"#   and comment section / e-mail address suffix."},{"line_number":58,"context_line":"#"},{"line_number":59,"context_line":"# [*jenkins_java_args*]"},{"line_number":60,"context_line":"#   These are the arguments to pass to Java. Set this parameter through"},{"line_number":61,"context_line":"#   hieradata to work around the security restrictions that result from"},{"line_number":62,"context_line":"#   upgrading to version \u003e 1.651."}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_99cf3b55","line":59,"updated":"2016-12-06 21:00:42.000000000","message":"jenkins_args_override","commit_id":"4f2283b619b6e267dc06a4bd847bb2514d850ec9"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"7feb5f55980b0c7fc6b4f741ab0db3e7650ec87e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"  $jenkins_password              \u003d undef,"},{"line_number":167,"context_line":"  $jenkins_ssh_private_key       \u003d undef,"},{"line_number":168,"context_line":"  $jenkins_ssh_public_key        \u003d undef,"},{"line_number":169,"context_line":"  $jenkins_java_args             \u003d \u0027\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf\"\u0027,"},{"line_number":170,"context_line":"  $jenkins_version               \u003d \u0027present\u0027,"},{"line_number":171,"context_line":"  $jjb_git_revision              \u003d \u0027master\u0027,"},{"line_number":172,"context_line":"  $jjb_git_url                   \u003d \u0027https://git.openstack.org/openstack-infra/jenkins-job-builder\u0027,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_b9da3715","line":169,"updated":"2016-12-06 21:00:42.000000000","message":"$jenkins_args_override \u003d undef","commit_id":"4f2283b619b6e267dc06a4bd847bb2514d850ec9"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"7feb5f55980b0c7fc6b4f741ab0db3e7650ec87e","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    jenkins_password        \u003d\u003e $jenkins_password,"},{"line_number":210,"context_line":"    project_config_repo     \u003d\u003e $project_config_repo,"},{"line_number":211,"context_line":"    log_server              \u003d\u003e $log_server,"},{"line_number":212,"context_line":"    jenkins_java_args       \u003d\u003e $jenkins_java_args,"},{"line_number":213,"context_line":"    jjb_git_revision        \u003d\u003e $jjb_git_revision,"},{"line_number":214,"context_line":"    jjb_git_url             \u003d\u003e $jjb_git_url,"},{"line_number":215,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_d9d533e5","line":212,"updated":"2016-12-06 21:00:42.000000000","message":"jenkins_args_override \u003d\u003e $jenkins_args_override,","commit_id":"4f2283b619b6e267dc06a4bd847bb2514d850ec9"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"3b7d54c561ae32e0867c78c7cc5e2428f74ef3aa","unresolved":false,"context_lines":[{"line_number":61,"context_line":"#   hieradata to work around the security restrictions that result from"},{"line_number":62,"context_line":"#   upgrading to version \u003e 1.651."},{"line_number":63,"context_line":"#   The workaround for Jenkins 1.651.2+ is to pass the Java system parameter:"},{"line_number":64,"context_line":"#   \"-Dhudson.model.ParametersAction.keepUndefinedParameters\u003dtrue\""},{"line_number":65,"context_line":"#   Which is not secure."},{"line_number":66,"context_line":"#"},{"line_number":67,"context_line":"# [*jenkins_version*]"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a71b18c_17370bb1","line":64,"updated":"2016-12-08 18:51:28.000000000","message":"Actually, you need to provide the whole thing now, but good to point out the important bit.\n\n\"-Xloggc:/var/log/jenkins/gc.log -XX:+PrintGCDetails -Xmx12g -Dorg.kohsuke.stapler.compression.CompressionFilter.disabled\u003dtrue -Djava.util.logging.config.file\u003d/var/lib/jenkins/logger.conf -Dhudson.model.ParametersAction.keepUndefinedParameters\u003dtrue\"","commit_id":"58c3545523ad0e877708d4634c6d499957d315fe"}]}