)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"3b93af90f042a9233ff7824c4993cb8e61615410","unresolved":false,"context_lines":[{"line_number":15,"context_line":"use zuulv2 \u003d true instead of zuulv3 \u003d false is made so that it would be"},{"line_number":16,"context_line":"easier to remove the flag once v2 support is removed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Note that also bumping default nodepool revision to the recommended"},{"line_number":19,"context_line":"0.4.0."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2e7cd8d1c8e662b7e21fa80d4fa62846e2d44a70"},{"line_number":22,"context_line":"Story: #2001367"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_aa25d70a","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":6},"updated":"2018-01-09 20:13:11.000000000","message":"If we bump to 0.4.0, then we need to make sure zookeeper is setup and properly configured.","commit_id":"91a7e56f697404e2da413adf1f761c1eee6a5d34"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"0928e2fe9538f54fa0d6a889dd0b7e92664e2715","unresolved":false,"context_lines":[{"line_number":15,"context_line":"use zuulv2 \u003d true instead of zuulv3 \u003d false is made so that it would be"},{"line_number":16,"context_line":"easier to remove the flag once v2 support is removed."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Note that also bumping default nodepool revision to the recommended"},{"line_number":19,"context_line":"0.4.0."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2e7cd8d1c8e662b7e21fa80d4fa62846e2d44a70"},{"line_number":22,"context_line":"Story: #2001367"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9f91af0f_eab99f78","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":6},"in_reply_to":"9f91af0f_aa25d70a","updated":"2018-01-09 20:28:21.000000000","message":"Ok, I did not realize it involved zookeeper. What do you think about keeping the old value of 0.3.1?","commit_id":"91a7e56f697404e2da413adf1f761c1eee6a5d34"}],"contrib/single_node_ci_data.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"76eb232e41aa8e5d36bac2127115ad9caeb8dd57","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#smtp_host:"},{"line_number":41,"context_line":"#smtp_default_from:"},{"line_number":42,"context_line":"#smtp_default_to:"},{"line_number":43,"context_line":"zuul_revision: master  # todo: change to zuulv3 release once it is out"},{"line_number":44,"context_line":"zuulv2_revision: 2.5.1"},{"line_number":45,"context_line":"#zuul_git_source_repo: https://git.openstack.org/openstack-infra/zuul"},{"line_number":46,"context_line":"oscc_file_contents: |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f91af0f_f1af74e0","line":43,"updated":"2018-01-08 20:31:35.000000000","message":"It\u0027s currently in feature/zuulv3 rather than master. Should we start there and then switch to master once it merges?","commit_id":"9e36316b4eaa3ffbfc7c4699a7840395f9f2194a"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"76eb232e41aa8e5d36bac2127115ad9caeb8dd57","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#nodepool_jenkins_target: jenkins1"},{"line_number":55,"context_line":"#jenkins_api_key:"},{"line_number":56,"context_line":"#jenkins_credentials_id:"},{"line_number":57,"context_line":"nodepool_revision: master  # todo: change to zuulv3 release once it is out"},{"line_number":58,"context_line":"nodepoolv2_revision: 0.4.0"},{"line_number":59,"context_line":"#nodepool_git_source_repo: https://git.openstack.org/openstack-infra/nodepool"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9f91af0f_11ad38e8","line":57,"updated":"2018-01-08 20:31:35.000000000","message":"Same as for zuul above.","commit_id":"9e36316b4eaa3ffbfc7c4699a7840395f9f2194a"}],"contrib/single_node_ci_site.pp":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"5571cbaf7e6ac4c1112469de6a5430ea284cf54d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    nodepool_jenkins_target     \u003d\u003e hiera(\u0027nodepool_jenkins_target\u0027, \u0027jenkins1\u0027),"},{"line_number":61,"context_line":"    jenkins_api_key             \u003d\u003e hiera(\u0027jenkins_api_key\u0027, \u0027XXX\u0027),"},{"line_number":62,"context_line":"    jenkins_credentials_id      \u003d\u003e hiera(\u0027jenkins_credentials_id\u0027, \u0027XXX\u0027),"},{"line_number":63,"context_line":"    nodepool_revision           \u003d\u003e hiera(\u0027nodepool_revision\u0027, \u00271e31103\u0027),"},{"line_number":64,"context_line":"    nodepool_git_source_repo    \u003d\u003e hiera(\u0027nodepool_git_source_repo\u0027,"},{"line_number":65,"context_line":"      \u0027https://git.openstack.org/openstack-infra/nodepool\u0027),"},{"line_number":66,"context_line":"    jjb_git_revision            \u003d\u003e hiera(\u0027jjb_git_revision\u0027, \u00271.6.2\u0027),"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"df87a7cf_76d21637","line":63,"updated":"2017-12-01 18:02:38.000000000","message":"We recommended that folks pin to the 0.4.0 release.  Can we use that here?","commit_id":"b305584f593f8964a4c5b47a5c5441cdfd5a5648"}],"manifests/single_node_ci.pp":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"dfc53cbf9e0ecf86b6ce05122fe3290fdb9d42d6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    $nodepool_revision_ \u003d hiera(\u0027nodepoolv2_revision\u0027, \u00270.4.0\u0027)"},{"line_number":209,"context_line":"    $zuul_revision_ \u003d hiera(\u0027zuulv2_revision\u0027, \u00272.6.0\u0027)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"  class { \u0027::openstackci::jenkins_master\u0027:"},{"line_number":212,"context_line":"    vhost_name              \u003d\u003e $jenkins_vhost_name,"},{"line_number":213,"context_line":"    serveradmin             \u003d\u003e $serveradmin,"},{"line_number":214,"context_line":"    jenkins_ssh_private_key \u003d\u003e $jenkins_ssh_private_key,"},{"line_number":215,"context_line":"    jenkins_ssh_public_key  \u003d\u003e $jenkins_ssh_public_key,"},{"line_number":216,"context_line":"    jenkins_version         \u003d\u003e $jenkins_version,"},{"line_number":217,"context_line":"    manage_jenkins_jobs     \u003d\u003e true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"df87a7cf_00249bc5","line":214,"range":{"start_line":211,"start_character":0,"end_line":214,"end_character":56},"updated":"2017-12-01 20:49:56.000000000","message":"Did not properly indent to avoid too much noop diff.","commit_id":"9e36316b4eaa3ffbfc7c4699a7840395f9f2194a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9a7ebeafa3b9e7a3753c6f9bc0fd2d6357036b1c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"  if $zuulv2 {"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    if $nodepool_revision \u003d\u003d undef {"},{"line_number":208,"context_line":"      $nodepool_revision_ \u003d \u00270.3.1\u0027"},{"line_number":209,"context_line":"    } else {"},{"line_number":210,"context_line":"      $nodepool_revision_ \u003d $nodepool_revision"},{"line_number":211,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9f91af0f_103432fb","line":208,"range":{"start_line":208,"start_character":29,"end_line":208,"end_character":34},"updated":"2018-01-09 22:14:51.000000000","message":"I think we should use 0.4.0 here since the old default was master which is at least as new as 0.4.0.\n\nWe should also consider making new tags on tip of master if it has moved from 0.4.0 before merging this change (and updating to use that tag here.)","commit_id":"28c947e7511f514dd5b39dce2cd2ba5127072a82"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9a7ebeafa3b9e7a3753c6f9bc0fd2d6357036b1c","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    }"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if $zuul_revision \u003d\u003d undef {"},{"line_number":214,"context_line":"      $zuul_revision_ \u003d \u00272.5.1\u0027"},{"line_number":215,"context_line":"    } else {"},{"line_number":216,"context_line":"      $zuul_revision_ \u003d $zuul_revision"},{"line_number":217,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9f91af0f_502ddaa5","line":214,"range":{"start_line":214,"start_character":25,"end_line":214,"end_character":30},"updated":"2018-01-09 22:14:51.000000000","message":"I think we should use 2.6.0 here as the old default was master which is at least as new as 2.6.0.\n\nWe should also consider making new tags on tip of master if it has moved from 2.6.0 before merging this change (and updating to use that tag here.)","commit_id":"28c947e7511f514dd5b39dce2cd2ba5127072a82"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"95c1960dc5781a0a1761ae5f97d4eef719080be7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"#   notification e-mails."},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*zuulv2*]"},{"line_number":117,"context_line":"#   Set to true to deploy zuul v2 (incompatible with zuul v3)."},{"line_number":118,"context_line":"#"},{"line_number":119,"context_line":"# [*zuul_revision*]"},{"line_number":120,"context_line":"#   The branch name used to install zuul."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9f91af0f_e95a0481","line":117,"updated":"2018-01-10 07:36:20.000000000","message":"The default seems to be \"true\", so shouldn\u0027t this rather read \"Set to false to deploy zuul v3\"?","commit_id":"8d4eea2bee94026aaa1d2ed0fe3913ae790ca5c1"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"bf9c010862adb7c16afae7ef35766a6495a2a690","unresolved":false,"context_lines":[{"line_number":114,"context_line":"#   notification e-mails."},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*zuulv2*]"},{"line_number":117,"context_line":"#   Set to true to deploy zuul v2 (incompatible with zuul v3)."},{"line_number":118,"context_line":"#"},{"line_number":119,"context_line":"# [*zuul_revision*]"},{"line_number":120,"context_line":"#   The branch name used to install zuul."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9f91af0f_0d7f2bab","line":117,"in_reply_to":"9f91af0f_e95a0481","updated":"2018-01-10 14:49:34.000000000","message":"Yes, it may be misleading about the default. Is it worth updating in this patch?","commit_id":"8d4eea2bee94026aaa1d2ed0fe3913ae790ca5c1"}]}