)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d90375b118b0e5f1f96490cb86ff6703969683a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"update mbcrypt support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"added condtion to test if php6enmod ( apache2 mod) is enabled"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Iff5ed701212d54f00a03a76978be3122809e7bf3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_84edae27","line":9,"updated":"2016-03-22 15:38:06.000000000","message":"I don\u0027t see this condition in this patch?","commit_id":"537c4f2ea90b776312f43bcc0b59638f08b18dbf"}],"manifests/init.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d90375b118b0e5f1f96490cb86ff6703969683a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"  exec { \u0027enablemcrypt\u0027:"},{"line_number":80,"context_line":"    path    \u003d\u003e [ \u0027/bin/\u0027, \u0027/sbin/\u0027 , \u0027/usr/bin/\u0027, \u0027/usr/sbin/\u0027 ],"},{"line_number":81,"context_line":"    command \u003d\u003e \u0027php5enmod mcrypt\u0027,"},{"line_number":82,"context_line":"    notify  \u003d\u003e Service[\u0027apache2\u0027],"},{"line_number":83,"context_line":"    require \u003d\u003e ["},{"line_number":84,"context_line":"      Httpd::Vhost[$vhost_name],"},{"line_number":85,"context_line":"      Package[$php5_packages] ] ,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_041d1e0f","line":82,"updated":"2016-03-22 15:38:06.000000000","message":"nit, I can fix in a followup - it would be better for this to use Service[\u0027httpd\u0027], \u0027apache2\u0027 refers to the name parameter which is different between debian and redhat. In this case it won\u0027t break anything.","commit_id":"537c4f2ea90b776312f43bcc0b59638f08b18dbf"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"8d90375b118b0e5f1f96490cb86ff6703969683a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    notify  \u003d\u003e Service[\u0027apache2\u0027],"},{"line_number":83,"context_line":"    require \u003d\u003e ["},{"line_number":84,"context_line":"      Httpd::Vhost[$vhost_name],"},{"line_number":85,"context_line":"      Package[$php5_packages] ] ,"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  # the deploy scripts use the curl CLI"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_e49aaa62","line":85,"updated":"2016-03-22 15:38:06.000000000","message":"Since there is no refreshonly, creates, onlyif, or unless parameter, this exec will run on every puppet run. Even assuming php5enmod is an idempotent operation that will mean puppet reports changes on every run.","commit_id":"537c4f2ea90b776312f43bcc0b59638f08b18dbf"}]}