)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e7e64c78ad199e660b489f8a1852c2a5011726bd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Apache MPM events + php5 fpm"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Updated site config to change MPM from fork to event model"},{"line_number":10,"context_line":"and to start using php5-fpm (fast cgi) to get a better site"},{"line_number":11,"context_line":"performance and a better use or server resources."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_8052e811","line":9,"updated":"2016-03-29 14:12:37.000000000","message":"It looks like the Puppet httpd module is installing apache2-mpm-prefork by default (or else I can\u0027t tell how that\u0027s getting pulled into the packageset with the current manifest), but I don\u0027t see anywhere here you\u0027re coercing it to install apache2-mpm-event instead. Someone with deeper understanding of that Puppet module will probably need to weigh in on how to pick the MPM it\u0027s using.","commit_id":"c08784b58d0ca3486c43e5efc03800fbebe294f0"}],"manifests/init.pp":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e7e64c78ad199e660b489f8a1852c2a5011726bd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"      \u0027php5-curl\u0027,"},{"line_number":70,"context_line":"      \u0027php5-cli\u0027,"},{"line_number":71,"context_line":"      \u0027php5-mcrypt\u0027,"},{"line_number":72,"context_line":"      \u0027php5-mysql\u0027,"},{"line_number":73,"context_line":"    ]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  package { $php5_packages:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_e0576400","side":"PARENT","line":72,"updated":"2016-03-29 14:12:37.000000000","message":"You\u0027re replacing the mysql module used here, but the commit message doesn\u0027t explain why.","commit_id":"638c79099702c64076803025d7bba3d16030de31"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e7e64c78ad199e660b489f8a1852c2a5011726bd","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      \u0027php5-gd\u0027,"},{"line_number":73,"context_line":"      \u0027php5-json\u0027,"},{"line_number":74,"context_line":"      \u0027php5-gmp\u0027,"},{"line_number":75,"context_line":"      \u0027php5-mysqlnd\u0027,"},{"line_number":76,"context_line":"      \u0027php5-fpm\u0027,"},{"line_number":77,"context_line":"    ]"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_c05ce027","line":75,"updated":"2016-03-29 14:12:37.000000000","message":"Several of these new packages seem to be unrelated to FPM, and the commit message doesn\u0027t explain why they\u0027re being added in the same change.","commit_id":"c08784b58d0ca3486c43e5efc03800fbebe294f0"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e7e64c78ad199e660b489f8a1852c2a5011726bd","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    command \u003d\u003e \u0027/usr/sbin/php5enmod mcrypt\u0027,"},{"line_number":87,"context_line":"    timeout \u003d\u003e 0,"},{"line_number":88,"context_line":"    require \u003d\u003e ["},{"line_number":89,"context_line":"      Package[\u0027php5-fpm\u0027],"},{"line_number":90,"context_line":"    ],"},{"line_number":91,"context_line":"    notify  \u003d\u003e Service[\u0027php5-fpm\u0027],"},{"line_number":92,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_2042fc3e","line":89,"updated":"2016-03-29 14:12:37.000000000","message":"Some of our Puppet reviewers may have better suggestions, but I think also subscribing to Package[\u0027php5-fpm\u0027] will at least only run this exec after the package is installed or upgraded, rather than every time the manifest is applied.","commit_id":"c08784b58d0ca3486c43e5efc03800fbebe294f0"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e7e64c78ad199e660b489f8a1852c2a5011726bd","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  file { \u0027/etc/php5/fpm/pool.d/www.conf\u0027:"},{"line_number":95,"context_line":"    ensure  \u003d\u003e present,"},{"line_number":96,"context_line":"    content \u003d\u003e template(\u0027openstackid/www.conf.erb\u0027),"},{"line_number":97,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":98,"context_line":"    group   \u003d\u003e \u0027www-data\u0027,"},{"line_number":99,"context_line":"    mode    \u003d\u003e \u00270640\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_003ff8b4","line":96,"updated":"2016-03-29 14:12:37.000000000","message":"Why a template instead of a regular file? You don\u0027t currently seem to be doing any ERB syntax inside it. Are you planning to parameterize some of its contents later? If so, the commit message should probably mention that.","commit_id":"c08784b58d0ca3486c43e5efc03800fbebe294f0"}]}