)]}'
{"manifests/init.pp":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2202e1cafbe105af7195a68f2ad05cc2206460d7","unresolved":false,"context_lines":[{"line_number":122,"context_line":"      Package[\u0027php5-fpm\u0027],"},{"line_number":123,"context_line":"    ],"},{"line_number":124,"context_line":"    notify  \u003d\u003e Service[\u0027php5-fpm\u0027],"},{"line_number":125,"context_line":"  }"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"  file { \u0027/etc/php5/fpm/php-fpm.conf\u0027:"},{"line_number":128,"context_line":"    ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_f4949fe8","side":"PARENT","line":125,"updated":"2018-12-13 21:52:58.000000000","message":"This isn\u0027t needed at all, there\u0027s an apt::update class (see below).","commit_id":"3a1fd8b9be9d6b98e6b2bda551e0d12b6e2d9007"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2202e1cafbe105af7195a68f2ad05cc2206460d7","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        logoutput \u003d\u003e on_failure,"},{"line_number":154,"context_line":"        command   \u003d\u003e \u0027add-apt-repository -y ppa:ondrej/php \u0026\u0026 apt-get update\u0027,"},{"line_number":155,"context_line":"        require   \u003d\u003e Package[$main_packages]"},{"line_number":156,"context_line":"      }"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      $php7_requires \u003d ["},{"line_number":159,"context_line":"        Package[$main_packages],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_149a7b11","line":156,"updated":"2018-12-13 21:52:58.000000000","message":"No need to resort of shell command orchestration here. Instead you can do:\n\n  apt::ppa { \u0027ppa:ondrej/php\u0027: }","commit_id":"52ddd98a2c9a6bc9c84a715f92980915f12a4bcd"},{"author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"change_message_id":"c0a633dbcb17e0eece605c1193362e4c5d4cbb3a","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        logoutput \u003d\u003e on_failure,"},{"line_number":154,"context_line":"        command   \u003d\u003e \u0027add-apt-repository -y ppa:ondrej/php \u0026\u0026 apt-get update\u0027,"},{"line_number":155,"context_line":"        require   \u003d\u003e Package[$main_packages]"},{"line_number":156,"context_line":"      }"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      $php7_requires \u003d ["},{"line_number":159,"context_line":"        Package[$main_packages],"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_a6ca6f15","line":156,"in_reply_to":"3f79a3b5_149a7b11","updated":"2018-12-14 15:28:27.000000000","message":"thx u i will use that :)","commit_id":"52ddd98a2c9a6bc9c84a715f92980915f12a4bcd"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2202e1cafbe105af7195a68f2ad05cc2206460d7","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      $php7_requires \u003d ["},{"line_number":159,"context_line":"        Package[$main_packages],"},{"line_number":160,"context_line":"        Exec[\u0027add-php-7.2-repository\u0027],"},{"line_number":161,"context_line":"      ]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_b47e27bf","line":160,"updated":"2018-12-13 21:52:58.000000000","message":"and here put:\n\n    Apt::Ppa[\u0027ppa:ondrej/php\u0027],\n    Class[\u0027apt::update\u0027],","commit_id":"52ddd98a2c9a6bc9c84a715f92980915f12a4bcd"},{"author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"change_message_id":"c0a633dbcb17e0eece605c1193362e4c5d4cbb3a","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      $php7_requires \u003d ["},{"line_number":159,"context_line":"        Package[$main_packages],"},{"line_number":160,"context_line":"        Exec[\u0027add-php-7.2-repository\u0027],"},{"line_number":161,"context_line":"      ]"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f79a3b5_46d11bcb","line":160,"in_reply_to":"3f79a3b5_b47e27bf","updated":"2018-12-14 15:28:27.000000000","message":"thx u i will use that :)","commit_id":"52ddd98a2c9a6bc9c84a715f92980915f12a4bcd"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6c33ac63f330400ae0380a4ea82d2cd10537c6bb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# underg the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# openstackid idp(sso-openid)"},{"line_number":16,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bfdaf3ff_b7084ad9","line":13,"updated":"2019-01-15 03:23:46.000000000","message":"Looks like you accidentally changed the license grant text in this comment block.","commit_id":"84f3b52683f175d3571c1deda166a2769a8e0ff2"},{"author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"change_message_id":"d11b8107c08c26d88ce9233678e7322048baad3a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT"},{"line_number":11,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# underg the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# openstackid idp(sso-openid)"},{"line_number":16,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bfdaf3ff_63145aa1","line":13,"in_reply_to":"bfdaf3ff_b7084ad9","updated":"2019-01-15 16:52:01.000000000","message":"ok fixed cheers","commit_id":"84f3b52683f175d3571c1deda166a2769a8e0ff2"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"20594d201000ee311c1ed84cb4339693cb324575","unresolved":false,"context_lines":[{"line_number":168,"context_line":"      ]"},{"line_number":169,"context_line":"    }"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    package { $php7_packages:"},{"line_number":172,"context_line":"      ensure   \u003d\u003e present,"},{"line_number":173,"context_line":"      provider \u003d\u003e \u0027apt\u0027,"},{"line_number":174,"context_line":"      require  \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":17,"id":"bfdaf3ff_0a620caf","line":171,"updated":"2019-01-17 19:51:25.000000000","message":"Just noting a potential simplification. We already set $php_packages to the version appropriate list above so we could move the installs outside of the if else and instead just set a $php_requires variable. Note this is not necessary to do.","commit_id":"5ad10537b47ac3e2c067dd12d4007a9757afb9db"}]}
