)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"b3d2803b1aed1649cc831e3d72b72b81f08471b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixed artisan command permissions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Set proper execution permissions for artisan command"},{"line_number":10,"context_line":"(www-data)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Icdb4740621d6f9c7310d1b6bb52ce1db43652882"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_870a21cd","line":10,"updated":"2020-01-28 17:11:59.000000000","message":"Is the file already owned by www-data? I don\u0027t see where file ownership is being set for it, just file modes.","commit_id":"22433bb0efd0ca2c6c7c040bc7709e72f121258d"}],"files/functions":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c81c20e63d0cdcabac9f1136229f0a2c1dfffb96","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        fi"},{"line_number":49,"context_line":"        tar -xzvf $SOURCE_TARBALL -C $target_dir --strip-components 1 --no-same-permissions"},{"line_number":50,"context_line":"    fi"},{"line_number":51,"context_line":"    chown -R $FILE_OWNER:$FILE_GROUP $target_dir"},{"line_number":52,"context_line":"    umask 0022"},{"line_number":53,"context_line":"    # link configuration files managed by puppet"},{"line_number":54,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_27248d0d","side":"PARENT","line":51,"updated":"2020-01-28 17:23:44.000000000","message":"As you pointed out in IRC, ownership for everything in the directory is being set here, so as long as something is setting FILE_OWNER or FILE_GROUP to www-data when calling the function, this will presumably work as intended.","commit_id":"1806356c5242f66dccc840fdb7fae22f2f8226f9"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"b3d2803b1aed1649cc831e3d72b72b81f08471b2","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # populate application database"},{"line_number":82,"context_line":"    cd $target_dir"},{"line_number":83,"context_line":"    chmod 770 artisan;"},{"line_number":84,"context_line":"    echo \"running redis FLUSHDB ...\";"},{"line_number":85,"context_line":"    echo \"FLUSHDB\" | redis-cli -h 127.0.0.1 -p $REDIS_PORT -a \"$REDIS_PASSWORD\";"},{"line_number":86,"context_line":"    echo \"running redis FLUSHALL ...\";"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_c70499c7","line":83,"updated":"2020-01-28 17:11:59.000000000","message":"The semicolon at the end of this command isn\u0027t needed. In shell scripting, it\u0027s simply a way to terminate a command in lieu of ending the line, in cases where another command will be following on the same line. Still, it doesn\u0027t hurt anything and the existing lines below it are already doing the same.\n\nYou might also consider using explicit 4-digit file modes, like 0770, making it clearer that the SETGID/SETUID bits are turned off.","commit_id":"22433bb0efd0ca2c6c7c040bc7709e72f121258d"},{"author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"change_message_id":"27ee62598b03742b970edf70a21d6764618feedc","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    # populate application database"},{"line_number":82,"context_line":"    cd $target_dir"},{"line_number":83,"context_line":"    chmod 770 artisan;"},{"line_number":84,"context_line":"    echo \"running redis FLUSHDB ...\";"},{"line_number":85,"context_line":"    echo \"FLUSHDB\" | redis-cli -h 127.0.0.1 -p $REDIS_PORT -a \"$REDIS_PASSWORD\";"},{"line_number":86,"context_line":"    echo \"running redis FLUSHALL ...\";"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_a7915df9","line":83,"in_reply_to":"3fa7e38b_c70499c7","updated":"2020-01-28 17:30:07.000000000","message":"fixed","commit_id":"22433bb0efd0ca2c6c7c040bc7709e72f121258d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"b3d2803b1aed1649cc831e3d72b72b81f08471b2","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    # populate application database"},{"line_number":237,"context_line":"    cd $target_dir"},{"line_number":238,"context_line":"    chmod 770 artisan;"},{"line_number":239,"context_line":"    echo \"running redis FLUSHDB ...\";"},{"line_number":240,"context_line":"    echo \"FLUSHDB\" | redis-cli -h 127.0.0.1 -p $REDIS_PORT -a \"$REDIS_PASSWORD\";"},{"line_number":241,"context_line":"    echo \"running redis FLUSHALL ...\";"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_6707e5c9","line":238,"updated":"2020-01-28 17:11:59.000000000","message":"Same comments as above.","commit_id":"22433bb0efd0ca2c6c7c040bc7709e72f121258d"},{"author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"change_message_id":"27ee62598b03742b970edf70a21d6764618feedc","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    # populate application database"},{"line_number":237,"context_line":"    cd $target_dir"},{"line_number":238,"context_line":"    chmod 770 artisan;"},{"line_number":239,"context_line":"    echo \"running redis FLUSHDB ...\";"},{"line_number":240,"context_line":"    echo \"FLUSHDB\" | redis-cli -h 127.0.0.1 -p $REDIS_PORT -a \"$REDIS_PASSWORD\";"},{"line_number":241,"context_line":"    echo \"running redis FLUSHALL ...\";"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3fa7e38b_c79499e9","line":238,"in_reply_to":"3fa7e38b_6707e5c9","updated":"2020-01-28 17:30:07.000000000","message":"fixed","commit_id":"22433bb0efd0ca2c6c7c040bc7709e72f121258d"}]}