)]}'
{"id":"opendev%2Fpuppet-openstackid~714351","triplet_id":"opendev%2Fpuppet-openstackid~master~I22b14e30738254ebd3e847003f16a4ad3863ed8a","project":"opendev/puppet-openstackid","branch":"master","topic":"hotfix/zap_owasp_scanning_1","hashtags":[],"change_id":"I22b14e30738254ebd3e847003f16a4ad3863ed8a","subject":"Fixing results from ZAP Scanning Report","status":"MERGED","created":"2020-03-23 05:05:28.000000000","updated":"2020-03-24 22:04:38.000000000","submitted":"2020-03-24 22:04:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"714351-1585087478318-7a5aba1f","meta_rev_id":"4e31bddcf5a5634cbcc561de46432c50d1a60477","_number":714351,"virtual_id_number":714351,"owner":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-24 22:04:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-24 20:47:12.000000000","_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"all":[{"value":0,"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-24 20:47:12.000000000","_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-23 05:56:59.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"},{"updated":"2020-03-24 20:47:12.000000000","updated_by":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"reviewer":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"state":"REVIEWER"},{"updated":"2020-03-24 22:04:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8f56fb24c0fdc46a876b1642c99750dd79f4e576","author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"date":"2020-03-23 05:05:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"425f5a3d13ea1e843846c34411efa60fb660f0fa","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 05:30:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-lint https://zuul.opendev.org/t/openstack/build/77b36ebce71447c3a065c6e48daa5501 : SUCCESS in 7m 21s\n- infra-puppet-apply-4-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/ef95527a618c4bf5a3fba2c9a57cca62 : SUCCESS in 11m 06s\n- openstackci-beaker-puppet-4 https://zuul.opendev.org/t/openstack/build/6b59131a34c74685907fc479123ed414 : SUCCESS in 14m 24s\n- puppet-beaker-rspec-puppet-4-infra https://zuul.opendev.org/t/openstack/build/622ceef622ba484a854c610b637e2973 : SUCCESS in 13m 39s","accounts_in_message":[],"_revision_number":1},{"id":"c7d81f5a129e8c241216c577589a55acded0821e","author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"date":"2020-03-23 05:56:39.000000000","message":"Patch Set 1: Code-Review+1\n\nplease review","accounts_in_message":[],"_revision_number":1},{"id":"17c8336857752a1a27196c21cd087b017a09640b","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-03-24 20:28:31.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0e9d099d75628e5a16b40b65041f161140b80ea8","author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"date":"2020-03-24 20:33:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cfa7558c42469cba5d56b2641ea702c4ebea77dc","author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"date":"2020-03-24 20:34:21.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"07fdba19130faf727f65c924f56e5a3bd507ead6","author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"date":"2020-03-24 20:39:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"0f35b18800c032b7ee258ebed2aa4b63a0cddc7d","author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"date":"2020-03-24 20:40:07.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"9aa90094030e1bdcf43b60b3c04bbf695d4bceaa","author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"date":"2020-03-24 20:47:12.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nIf that\u0027s the case, we should add a CNAME at www.openstackid.org to @ and make sure the vhost is also aliasing or redirecting it accordingly (the SSL certificate for it already seems to list www.openstackid.org as a SubjectAltName so that much is already taken care of).","accounts_in_message":[],"_revision_number":3},{"id":"d19392e0566b8b333f52aaae1878c64dd3266002","author":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"date":"2020-03-24 21:08:22.000000000","message":"Patch Set 2:\n\nsure thing i will take care of the vhost config\nregards","accounts_in_message":[],"_revision_number":2},{"id":"b6b28e5cccc86c9161ba1c70130713021689d391","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 21:16:10.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-lint https://zuul.opendev.org/t/openstack/build/a5e6e52dcecb437fab62f7e36b384bbc : SUCCESS in 6m 47s\n- infra-puppet-apply-4-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/218cb7faa712400ca3eccedacb449c8f : SUCCESS in 19m 36s\n- openstackci-beaker-puppet-4 https://zuul.opendev.org/t/openstack/build/702ecf3386cb400cb733233c96a030d7 : SUCCESS in 21m 46s\n- puppet-beaker-rspec-puppet-4-infra https://zuul.opendev.org/t/openstack/build/c9c61f074aed477eb186479745758d85 : SUCCESS in 9m 25s","accounts_in_message":[],"_revision_number":3},{"id":"09ae103f4ee013a96fd8d3b04d26b7fef7afd226","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 21:16:22.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"c459b5d4f998451f4bc4c512cf77f05a43244e8c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 22:04:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"9d25e35b54025c09b5f15c1cbf2e99c44347b27c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 22:04:38.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- legacy-puppet-lint https://zuul.opendev.org/t/openstack/build/36a903c11ec04b668e5d2fc54a33317f : SUCCESS in 5m 56s\n- infra-puppet-apply-4-ubuntu-xenial https://zuul.opendev.org/t/openstack/build/6f57f90d2a3f45d5a65d85d46808dd26 : SUCCESS in 14m 26s\n- openstackci-beaker-puppet-4 https://zuul.opendev.org/t/openstack/build/66b4d629e91d4232ae542fd3c158ab88 : SUCCESS in 18m 29s\n- puppet-beaker-rspec-puppet-4-infra https://zuul.opendev.org/t/openstack/build/d5ac145afc4045e5a6afc4532a6ac765 : SUCCESS in 11m 42s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"954b03a75f41ca1b544816fa20b19cdc92f18b66","revisions":{"a7c3a754aea5a695a4c78613ce90f62237652a6b":{"kind":"REWORK","_number":1,"created":"2020-03-23 05:05:28.000000000","uploader":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"ref":"refs/changes/51/714351/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-openstackid","ref":"refs/changes/51/714351/1","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/1"}}},"commit":{"parents":[{"commit":"21c361bd965883fe5416d2b0cc4749d7d4b168e2","subject":"Updated python dependencies install","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/21c361bd965883fe5416d2b0cc4749d7d4b168e2"}]}],"author":{"name":"smarcet","email":"smarcet@gmail.com","date":"2020-03-23 05:04:27.000000000","tz":-180},"committer":{"name":"smarcet","email":"smarcet@gmail.com","date":"2020-03-23 05:04:27.000000000","tz":-180},"subject":"Fixing results from ZAP Scanning Report","message":"Fixing results from ZAP Scanning Report\n\nadded header Strict-Transport-Security Header Not Set\n\nChange-Id: I22b14e30738254ebd3e847003f16a4ad3863ed8a\nSigned-off-by: smarcet \u003csmarcet@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/a7c3a754aea5a695a4c78613ce90f62237652a6b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/a7c3a754aea5a695a4c78613ce90f62237652a6b"}]},"branch":"refs/heads/master"},"c134355f55e7892c69058147d9bb0e54bc443efd":{"kind":"REWORK","_number":2,"created":"2020-03-24 20:33:54.000000000","uploader":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"ref":"refs/changes/51/714351/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-openstackid","ref":"refs/changes/51/714351/2","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/2"}}},"commit":{"parents":[{"commit":"21c361bd965883fe5416d2b0cc4749d7d4b168e2","subject":"Updated python dependencies install","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/21c361bd965883fe5416d2b0cc4749d7d4b168e2"}]}],"author":{"name":"smarcet","email":"smarcet@gmail.com","date":"2020-03-23 05:04:27.000000000","tz":-180},"committer":{"name":"smarcet","email":"smarcet@gmail.com","date":"2020-03-24 20:33:43.000000000","tz":-180},"subject":"Fixing results from ZAP Scanning Report","message":"Fixing results from ZAP Scanning Report\n\nadded header Strict-Transport-Security Header Not Set\n\nChange-Id: I22b14e30738254ebd3e847003f16a4ad3863ed8a\nSigned-off-by: smarcet \u003csmarcet@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/c134355f55e7892c69058147d9bb0e54bc443efd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/c134355f55e7892c69058147d9bb0e54bc443efd"}]},"branch":"refs/heads/master"},"954b03a75f41ca1b544816fa20b19cdc92f18b66":{"kind":"REWORK","_number":3,"created":"2020-03-24 20:40:07.000000000","uploader":{"_account_id":9139,"name":"sebastian marcet","email":"smarcet@gmail.com","username":"smarcet"},"ref":"refs/changes/51/714351/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-openstackid","ref":"refs/changes/51/714351/3","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-openstackid refs/changes/51/714351/3"}}},"commit":{"parents":[{"commit":"21c361bd965883fe5416d2b0cc4749d7d4b168e2","subject":"Updated python dependencies install","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/21c361bd965883fe5416d2b0cc4749d7d4b168e2"}]}],"author":{"name":"smarcet","email":"smarcet@gmail.com","date":"2020-03-23 05:04:27.000000000","tz":-180},"committer":{"name":"smarcet","email":"smarcet@gmail.com","date":"2020-03-24 20:39:57.000000000","tz":-180},"subject":"Fixing results from ZAP Scanning Report","message":"Fixing results from ZAP Scanning Report\n\nadded header Strict-Transport-Security Header Not Set\n\nChange-Id: I22b14e30738254ebd3e847003f16a4ad3863ed8a\nSigned-off-by: smarcet \u003csmarcet@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/954b03a75f41ca1b544816fa20b19cdc92f18b66"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-openstackid/commit/954b03a75f41ca1b544816fa20b19cdc92f18b66"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}