)]}'
{"manifests/app.pp":[{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"a9a6ff769e23e1e64300588a23b8a9751bf775b4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  $user                   \u003d $::refstack::params::user"},{"line_number":29,"context_line":"  $group                  \u003d $::refstack::params::group"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # Ensure Git is present"},{"line_number":32,"context_line":"  if !defined(Package[\u0027git\u0027]) {"},{"line_number":33,"context_line":"    package { \u0027git\u0027:"},{"line_number":34,"context_line":"      ensure \u003d\u003e present"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dae33548_26bf0e62","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":14},"updated":"2016-02-18 11:41:22.000000000","message":"Seems it is not needed now.","commit_id":"a0169cd4bf27f0f11adcc30652cea8179701ed21"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"38b3139d4159e4d712145ab64a6b02a676cf5a2b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  $user                   \u003d $::refstack::params::user"},{"line_number":29,"context_line":"  $group                  \u003d $::refstack::params::group"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  # Ensure Git is present"},{"line_number":32,"context_line":"  if !defined(Package[\u0027git\u0027]) {"},{"line_number":33,"context_line":"    package { \u0027git\u0027:"},{"line_number":34,"context_line":"      ensure \u003d\u003e present"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dae33548_215a2e51","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":14},"in_reply_to":"dae33548_26bf0e62","updated":"2016-02-18 23:46:54.000000000","message":"Yea, good catch.","commit_id":"a0169cd4bf27f0f11adcc30652cea8179701ed21"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"a9a6ff769e23e1e64300588a23b8a9751bf775b4","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  file { \"${src_root}\":"},{"line_number":80,"context_line":"    ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":81,"context_line":"    owner   \u003d\u003e $user,"},{"line_number":82,"context_line":"    group   \u003d\u003e $group,"},{"line_number":83,"context_line":"    mode   \u003d\u003e \u00270755\u0027,"},{"line_number":84,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dae33548_264d4e9a","line":81,"updated":"2016-02-18 11:41:22.000000000","message":"nit - extra space before \u0027\u003d\u003e\u0027 this and next line","commit_id":"a0169cd4bf27f0f11adcc30652cea8179701ed21"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"8ecd62b88cc984dd10594824ca18a70c1f75be96","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":104,"context_line":"    user        \u003d\u003e $user,"},{"line_number":105,"context_line":"    group       \u003d\u003e $group,"},{"line_number":106,"context_line":"    subscribe   \u003d\u003e Exec[\u0027download-refstack\u0027]"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  # Remove tar.gz file after extracting."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1af94dfe_086eb894","line":106,"updated":"2016-03-17 09:24:18.000000000","message":"I believe you need a require \u003d\u003e File[\"$src_root\"], this exec depends on the folder to be created upfront before running","commit_id":"d215f24e6217a17101d101a9c6ece3051d2af4f1"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"a96a9c6b3c167163d8c58329eef3c3e5ad03758a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":104,"context_line":"    user        \u003d\u003e $user,"},{"line_number":105,"context_line":"    group       \u003d\u003e $group,"},{"line_number":106,"context_line":"    subscribe   \u003d\u003e Exec[\u0027download-refstack\u0027]"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  # Remove tar.gz file after extracting."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1af94dfe_511fb26b","line":106,"in_reply_to":"1af94dfe_086eb894","updated":"2016-03-17 16:31:59.000000000","message":"Done","commit_id":"d215f24e6217a17101d101a9c6ece3051d2af4f1"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"b793e8af304d4fde8437be5495c26b4856206637","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      File[\u0027/etc/refstack\u0027]"},{"line_number":86,"context_line":"    ]"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  # Download the RefStack tar.gz source distribution from pypi only if a new"},{"line_number":90,"context_line":"  # one is available."},{"line_number":91,"context_line":"  exec { \u0027download-refstack\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"da0c15f0_37bc0f6c","line":88,"updated":"2016-03-25 14:22:23.000000000","message":"Ah, okay, thanks.  We should get together with Monty and Michael Krotscheck and see if we can\u0027t develap a slightly better installation pattern at some point.","commit_id":"92ad5a7b0e5e1771115c8ebe2911bb494b43e952"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"650944485209434a62050e37b5eeb0571f333252","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      File[\u0027/etc/refstack\u0027]"},{"line_number":86,"context_line":"    ]"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  # Download the RefStack tar.gz source distribution from pypi only if a new"},{"line_number":90,"context_line":"  # one is available."},{"line_number":91,"context_line":"  exec { \u0027download-refstack\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa0719c6_8a6329b1","line":88,"updated":"2016-03-21 18:24:03.000000000","message":"It seems that everything from here to install-refstack (inclusive) could be replaced with a simple pip install like this:\n\npackage {\u0027refstack\u0027:\n  ensure \u003d\u003e latest,\n  provider \u003d\u003e pip,\n  require \u003d\u003e Class[\u0027pip\u0027]\n}\n\nAt least, that\u0027s typically how we install things from pypi.  Is there a reason that wouldn\u0027t work here?","commit_id":"92ad5a7b0e5e1771115c8ebe2911bb494b43e952"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"1264583a890779323fae39cb8bff7a2abc9b78d7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      File[\u0027/etc/refstack\u0027]"},{"line_number":86,"context_line":"    ]"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  # Download the RefStack tar.gz source distribution from pypi only if a new"},{"line_number":90,"context_line":"  # one is available."},{"line_number":91,"context_line":"  exec { \u0027download-refstack\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba0121b8_55a39b9e","line":88,"in_reply_to":"da0c15f0_37bc0f6c","updated":"2016-03-28 18:44:21.000000000","message":"Yea, not the cleanest pattern, but it should work for our needs for the time being. I feel like just a separate git branch would be good. A branch for development, and a branch for production where puppet would pull from instead of releases.","commit_id":"92ad5a7b0e5e1771115c8ebe2911bb494b43e952"},{"author":{"_account_id":9626,"name":"Paul Van Eck","email":"pvaneck@us.ibm.com","username":"pvaneck"},"change_message_id":"cb57eb5893a9694ee5b54ebdc74dec41a2b3deb9","unresolved":false,"context_lines":[{"line_number":85,"context_line":"      File[\u0027/etc/refstack\u0027]"},{"line_number":86,"context_line":"    ]"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  # Download the RefStack tar.gz source distribution from pypi only if a new"},{"line_number":90,"context_line":"  # one is available."},{"line_number":91,"context_line":"  exec { \u0027download-refstack\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"fa0719c6_2d21574e","line":88,"in_reply_to":"fa0719c6_8a6329b1","updated":"2016-03-21 18:45:57.000000000","message":"Pip currently does not install the UI code that exists in the repository. Moreover, needed top-level files for UI dependency installation (i.e. bower.json, package.json, .bowerrc) won\u0027t be available as well, and I don\u0027t believe I can move these files down a directory due to the way the javascript jenkins jobs are run.\n\nI found this way to be a workable solution.","commit_id":"92ad5a7b0e5e1771115c8ebe2911bb494b43e952"}]}