)]}'
{"id":"opendev%2Fpuppet-refstack~658926","triplet_id":"opendev%2Fpuppet-refstack~master~I8b8242b1b6d9b2bb072ace5b82a65899fe383056","project":"opendev/puppet-refstack","branch":"master","topic":"fix-vhosts","hashtags":[],"change_id":"I8b8242b1b6d9b2bb072ace5b82a65899fe383056","subject":"Rely on servername not virtualhost name resolution","status":"MERGED","created":"2019-05-13 21:40:32.000000000","updated":"2019-05-13 22:49:40.000000000","submitted":"2019-05-13 22:49:39.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"658926-1557787780214-72f24b91","meta_rev_id":"5d9953316d8355314633a2145f5d190d66b48f84","_number":658926,"virtual_id_number":658926,"owner":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":2,"date":"2019-05-13 22:49:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"all":[{"value":2,"date":"2019-05-13 21:41:03.000000000","_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-05-13 22:26:07.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-05-13 22:26:07.000000000","_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-05-13 21:41:03.000000000","updated_by":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"reviewer":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"state":"REVIEWER"},{"updated":"2019-05-13 22:26:07.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2019-05-13 22:49:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"38a7cd12c77799f30044ca2d38e97a0cbc36b46d","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2019-05-13 21:40:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"482a2ae2b6c905137ed4958f4949e2b6b9728b79","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2019-05-13 21:41:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"8a2e10357569c2da512a74fd8f1da3b2d783fa44","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 22:03:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- legacy-puppet-lint http://logs.openstack.org/26/658926/1/check/legacy-puppet-lint/a84234a/ : SUCCESS in 7m 03s\n- legacy-puppet-syntax-3 http://logs.openstack.org/26/658926/1/check/legacy-puppet-syntax-3/6010e03/ : SUCCESS in 10m 27s\n- legacy-puppet-syntax-4-centos-7 http://logs.openstack.org/26/658926/1/check/legacy-puppet-syntax-4-centos-7/f914eba/ : SUCCESS in 7m 08s\n- infra-puppet-apply-3-ubuntu-trusty http://logs.openstack.org/26/658926/1/check/infra-puppet-apply-3-ubuntu-trusty/5dfcc96/ : SUCCESS in 9m 21s\n- infra-puppet-apply-3-ubuntu-xenial http://logs.openstack.org/26/658926/1/check/infra-puppet-apply-3-ubuntu-xenial/c60ef14/ : SUCCESS in 12m 07s\n- infra-puppet-apply-4-ubuntu-xenial http://logs.openstack.org/26/658926/1/check/infra-puppet-apply-4-ubuntu-xenial/0a86e68/ : SUCCESS in 9m 22s\n- openstackci-beaker-ubuntu-trusty http://logs.openstack.org/26/658926/1/check/openstackci-beaker-ubuntu-trusty/0d91d66/ : SUCCESS in 13m 40s\n- openstackci-beaker http://logs.openstack.org/26/658926/1/check/openstackci-beaker/6a3756d/ : SUCCESS in 15m 32s\n- openstackci-beaker-puppet-4 http://logs.openstack.org/26/658926/1/check/openstackci-beaker-puppet-4/8c066a8/ : SUCCESS in 14m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f708470185cf667758113ba683259c14805e0df5","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2019-05-13 22:26:07.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"86adb5b9f65307d966b683c05f2336a822bd2c39","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 22:26:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"766481b8e9e634f8c4f780930a99f963f9242f6f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 22:49:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- legacy-puppet-lint http://logs.openstack.org/26/658926/1/gate/legacy-puppet-lint/7ac3b37/ : SUCCESS in 4m 59s\n- legacy-puppet-syntax-3 http://logs.openstack.org/26/658926/1/gate/legacy-puppet-syntax-3/15c108c/ : SUCCESS in 7m 42s\n- legacy-puppet-syntax-4-centos-7 http://logs.openstack.org/26/658926/1/gate/legacy-puppet-syntax-4-centos-7/56eeeb3/ : SUCCESS in 8m 31s\n- infra-puppet-apply-3-ubuntu-trusty http://logs.openstack.org/26/658926/1/gate/infra-puppet-apply-3-ubuntu-trusty/f5cc434/ : SUCCESS in 9m 17s\n- infra-puppet-apply-3-ubuntu-xenial http://logs.openstack.org/26/658926/1/gate/infra-puppet-apply-3-ubuntu-xenial/0aa62cb/ : SUCCESS in 10m 25s\n- openstackci-beaker-ubuntu-trusty http://logs.openstack.org/26/658926/1/gate/openstackci-beaker-ubuntu-trusty/9912526/ : SUCCESS in 13m 48s\n- infra-puppet-apply-4-ubuntu-xenial http://logs.openstack.org/26/658926/1/gate/infra-puppet-apply-4-ubuntu-xenial/0e0d0b2/ : SUCCESS in 9m 18s\n- openstackci-beaker http://logs.openstack.org/26/658926/1/gate/openstackci-beaker/dcd9be6/ : SUCCESS in 15m 26s","accounts_in_message":[],"_revision_number":1},{"id":"e908e37aca54ef7f0d645c82f4faa184060182ef","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-05-13 22:49:40.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7d2bf8ef507869d46533a0c93b00dd1c1f70bed7","revisions":{"7d2bf8ef507869d46533a0c93b00dd1c1f70bed7":{"kind":"REWORK","_number":1,"created":"2019-05-13 21:40:32.000000000","uploader":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"ref":"refs/changes/26/658926/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-refstack","ref":"refs/changes/26/658926/1","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-refstack refs/changes/26/658926/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-refstack refs/changes/26/658926/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-refstack refs/changes/26/658926/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-refstack refs/changes/26/658926/1"}}},"commit":{"parents":[{"commit":"b712a03c467b0a37ce85b1e967f57842b3604a73","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-refstack/commit/b712a03c467b0a37ce85b1e967f57842b3604a73"}]}],"author":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-05-13 21:38:43.000000000","tz":-420},"committer":{"name":"Clark Boylan","email":"clark.boylan@gmail.com","date":"2019-05-13 21:40:26.000000000","tz":-420},"subject":"Rely on servername not virtualhost name resolution","message":"Rely on servername not virtualhost name resolution\n\nWe recently broke our /etc/hosts content on our servers then restored it\nto a sane default for each server. This would have removed any special\nentries servers may have had. It appears that refstack was relying on\nsuch special entries to make the named virtualhost entries work. With\nthe new /etc/hosts content our vhosts weren\u0027t serving content.\n\nFix this by removing the named vhost entries and instead rely on\nServerName to specify where requests go.\n\nChange-Id: I8b8242b1b6d9b2bb072ace5b82a65899fe383056\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-refstack/commit/7d2bf8ef507869d46533a0c93b00dd1c1f70bed7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-refstack/commit/7d2bf8ef507869d46533a0c93b00dd1c1f70bed7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}