)]}'
{"manifests/server.pp":[{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"c291e953c3cf67fde97e4434eba00107619a8417","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    ensure      \u003d\u003e present,"},{"line_number":63,"context_line":"    command     \u003d\u003e \u0027subunit2sql-db-manage --config-file /etc/subunit2sql.conf expire --expire-age $expire_age \u003e\u003e /var/log/subunit2sql_migration.log 2\u003e\u00261 \u0026 \u0027,"},{"line_number":64,"context_line":"    minute      \u003d\u003e \u00270\u0027,"},{"line_number":65,"context_line":"    hour        \u003d\u003e \u00273\u0027,"},{"line_number":66,"context_line":"    weekday     \u003d\u003e \u00277\u0027,"},{"line_number":67,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/usr/local/bin:/usr/bin:/bin/\u0027,"},{"line_number":68,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a1a9d01_380777cb","line":65,"updated":"2015-09-29 19:31:43.000000000","message":"for a module that aims to be reused, i think it\u0027s better if you can expose cron settings to let users to configure them. Hardcoding the time is not a god idea to me, because it may conflict with another jobs running at same time","commit_id":"1f43206ef9d288aa54ee828a1c84108290f75a2d"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"b192dd3178c8f6a05a104fb204abb45e988f1a4e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    ensure      \u003d\u003e present,"},{"line_number":63,"context_line":"    command     \u003d\u003e \u0027subunit2sql-db-manage --config-file /etc/subunit2sql.conf expire --expire-age $expire_age \u003e\u003e /var/log/subunit2sql_migration.log 2\u003e\u00261 \u0026 \u0027,"},{"line_number":64,"context_line":"    minute      \u003d\u003e \u00270\u0027,"},{"line_number":65,"context_line":"    hour        \u003d\u003e \u00273\u0027,"},{"line_number":66,"context_line":"    weekday     \u003d\u003e \u00277\u0027,"},{"line_number":67,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/usr/local/bin:/usr/bin:/bin/\u0027,"},{"line_number":68,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a2fa921_866a0fed","line":65,"in_reply_to":"7a2fa921_135be62f","updated":"2015-10-08 07:35:13.000000000","message":"Hi Matthew, we use it downstream...","commit_id":"1f43206ef9d288aa54ee828a1c84108290f75a2d"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"288b723846502ac1e41f30cd5763793273253e01","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    ensure      \u003d\u003e present,"},{"line_number":63,"context_line":"    command     \u003d\u003e \u0027subunit2sql-db-manage --config-file /etc/subunit2sql.conf expire --expire-age $expire_age \u003e\u003e /var/log/subunit2sql_migration.log 2\u003e\u00261 \u0026 \u0027,"},{"line_number":64,"context_line":"    minute      \u003d\u003e \u00270\u0027,"},{"line_number":65,"context_line":"    hour        \u003d\u003e \u00273\u0027,"},{"line_number":66,"context_line":"    weekday     \u003d\u003e \u00277\u0027,"},{"line_number":67,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/usr/local/bin:/usr/bin:/bin/\u0027,"},{"line_number":68,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a2fa921_135be62f","line":65,"in_reply_to":"9a1a9d01_380777cb","updated":"2015-10-06 20:50:59.000000000","message":"So does this module aim to be reused? People keep on saying that and I\u0027m fine with that being a thing, but it\u0027s not like I\u0027ve seen anyone use this before. I\u0027ve asked others if they know of any examples. I mean I didn\u0027t write it with anything but the infra case in mind.\n\nBut sure I don\u0027t disagree, I\u0027ll respin in a sec and make the cron params configurable.","commit_id":"1f43206ef9d288aa54ee828a1c84108290f75a2d"}]}
