)]}'
{"id":"opendev%2Fpuppet-subunit2sql~233166","triplet_id":"opendev%2Fpuppet-subunit2sql~master~I746a9f0ae722802419f36f80626c3a6f4186bad6","project":"opendev/puppet-subunit2sql","branch":"master","topic":"(HEAD","hashtags":[],"change_id":"I746a9f0ae722802419f36f80626c3a6f4186bad6","subject":"Use double quotes for mysql backup","status":"MERGED","created":"2015-10-09 16:18:51.000000000","updated":"2015-11-12 16:33:07.000000000","submitted":"2015-11-12 16:33:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"424b1c1c7e0cfd4f4bb0b1d0745976f4cbd6279f","_number":233166,"virtual_id_number":233166,"owner":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"value":2,"date":"2015-11-12 16:33:06.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2015-11-12 16:23:03.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-10-10 08:12:05.000000000","_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":1,"date":"2015-11-12 16:23:03.000000000","_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-10-09 20:00:22.000000000","updated_by":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"reviewer":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"state":"REVIEWER"},{"updated":"2015-10-10 08:12:05.000000000","updated_by":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"reviewer":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"state":"REVIEWER"},{"updated":"2015-11-12 16:23:03.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2015-11-12 16:33:06.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"49999da1e2737a01ccb9cfa782521a55ef19f6e3","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2015-10-09 16:18:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dff0a1b86159aa4db3e117ee2eb5c64770cf2726","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-09 16:42:11.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-puppet-subunit2sql-puppet-lint http://logs.openstack.org/66/233166/1/check/gate-puppet-subunit2sql-puppet-lint/3cbd1fc/ : FAILURE in 24s\n- gate-puppet-subunit2sql-puppet-syntax http://logs.openstack.org/66/233166/1/check/gate-puppet-subunit2sql-puppet-syntax/8e9b71c/ : SUCCESS in 19s\n- gate-infra-puppet-apply-bare-precise http://logs.openstack.org/66/233166/1/check/gate-infra-puppet-apply-bare-precise/ac838c8/ : SUCCESS in 4m 07s\n- gate-infra-puppet-apply-bare-trusty http://logs.openstack.org/66/233166/1/check/gate-infra-puppet-apply-bare-trusty/3527572/ : SUCCESS in 2m 40s\n- gate-infra-puppet-apply-bare-centos6 http://logs.openstack.org/66/233166/1/check/gate-infra-puppet-apply-bare-centos6/1b3d4e1/ : SUCCESS in 1m 31s\n- gate-infra-puppet-apply-dsvm-centos7 http://logs.openstack.org/66/233166/1/check/gate-infra-puppet-apply-dsvm-centos7/32d7c7d/ : SUCCESS in 1m 17s\n- gate-infra-puppet-apply-dsvm-f21 http://logs.openstack.org/66/233166/1/check/gate-infra-puppet-apply-dsvm-f21/bd44484/ : SUCCESS in 1m 14s\n- gate-openstackci-beaker-centos7-dsvm http://logs.openstack.org/66/233166/1/check/gate-openstackci-beaker-centos7-dsvm/43209cf/ : SUCCESS in 3m 30s (non-voting)\n- gate-openstackci-beaker-trusty-dsvm http://logs.openstack.org/66/233166/1/check/gate-openstackci-beaker-trusty-dsvm/aa4af8d/ : SUCCESS in 5m 34s (non-voting)\n- gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-trusty-nv http://logs.openstack.org/66/233166/1/check/gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-trusty-nv/ecc4fc6/ : SUCCESS in 1m 01s (non-voting)\n- gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-centos7-nv http://logs.openstack.org/66/233166/1/check/gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-centos7-nv/0b90246/ : SUCCESS in 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"88c6bc656e2ec2a2d697c137670e36a0e3fa68c1","author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"date":"2015-10-09 20:00:15.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"8cbc0ccb2f80d9346589cfc78ca051248fe897f5","author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"date":"2015-10-09 20:00:22.000000000","message":"Patch Set 1: Code-Review-1\n\noops","accounts_in_message":[],"_revision_number":1},{"id":"2140ff72ac09b20156b61088a94d8334a0422e56","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2015-10-09 20:06:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"e5626881c3e7d8cfbc1941bb316040efb2bce038","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2015-10-09 20:06:58.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"38c1e1dec1e08622ec3353d85ed54b2158cb716a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-10-09 20:14:23.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-puppet-subunit2sql-puppet-lint http://logs.openstack.org/66/233166/2/check/gate-puppet-subunit2sql-puppet-lint/1767093/ : SUCCESS in 36s\n- gate-puppet-subunit2sql-puppet-syntax http://logs.openstack.org/66/233166/2/check/gate-puppet-subunit2sql-puppet-syntax/b8b5004/ : SUCCESS in 11s\n- gate-infra-puppet-apply-bare-precise http://logs.openstack.org/66/233166/2/check/gate-infra-puppet-apply-bare-precise/a19326f/ : SUCCESS in 4m 18s\n- gate-infra-puppet-apply-bare-trusty http://logs.openstack.org/66/233166/2/check/gate-infra-puppet-apply-bare-trusty/dc531fd/ : SUCCESS in 2m 09s\n- gate-infra-puppet-apply-bare-centos6 http://logs.openstack.org/66/233166/2/check/gate-infra-puppet-apply-bare-centos6/cea25c6/ : SUCCESS in 2m 24s\n- gate-infra-puppet-apply-dsvm-centos7 http://logs.openstack.org/66/233166/2/check/gate-infra-puppet-apply-dsvm-centos7/fd50b1c/ : SUCCESS in 1m 09s\n- gate-infra-puppet-apply-dsvm-f21 http://logs.openstack.org/66/233166/2/check/gate-infra-puppet-apply-dsvm-f21/ea514e1/ : SUCCESS in 1m 29s\n- gate-openstackci-beaker-centos7-dsvm http://logs.openstack.org/66/233166/2/check/gate-openstackci-beaker-centos7-dsvm/291bb74/ : SUCCESS in 3m 42s (non-voting)\n- gate-openstackci-beaker-trusty-dsvm http://logs.openstack.org/66/233166/2/check/gate-openstackci-beaker-trusty-dsvm/b586ad1/ : SUCCESS in 4m 51s (non-voting)\n- gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-trusty-nv http://logs.openstack.org/66/233166/2/check/gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-trusty-nv/980285f/ : SUCCESS in 47s (non-voting)\n- gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-centos7-nv http://logs.openstack.org/66/233166/2/check/gate-puppet-subunit2sql-puppet-beaker-rspec-dsvm-centos7-nv/af5b655/ : SUCCESS in 43s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"492393a49b5a3a768528c6ea6eda4402f6f2284f","author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"date":"2015-10-10 08:12:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"2be6b9458cd5e072ee80a3faeda04d8728e039a7","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2015-11-12 16:23:03.000000000","message":"Patch Set 2: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"ec3053078b18b1cd04a1ae1f83df4393a74db325","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-12 16:23:08.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"36a1984e69941a8139d149e39ac035e1faf59ba2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-12 16:33:06.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-puppet-subunit2sql-puppet-lint http://logs.openstack.org/66/233166/2/gate/gate-puppet-subunit2sql-puppet-lint/e38cf19/ : SUCCESS in 27s\n- gate-puppet-subunit2sql-puppet-syntax http://logs.openstack.org/66/233166/2/gate/gate-puppet-subunit2sql-puppet-syntax/283dd00/ : SUCCESS in 11s\n- gate-infra-puppet-apply-bare-precise http://logs.openstack.org/66/233166/2/gate/gate-infra-puppet-apply-bare-precise/dad0ca7/ : SUCCESS in 4m 00s\n- gate-infra-puppet-apply-bare-trusty http://logs.openstack.org/66/233166/2/gate/gate-infra-puppet-apply-bare-trusty/ba3c72c/ : SUCCESS in 2m 27s\n- gate-infra-puppet-apply-bare-centos6 http://logs.openstack.org/66/233166/2/gate/gate-infra-puppet-apply-bare-centos6/ae53d21/ : SUCCESS in 1m 37s\n- gate-infra-puppet-apply-dsvm-centos7 http://logs.openstack.org/66/233166/2/gate/gate-infra-puppet-apply-dsvm-centos7/7a9e8c7/ : SUCCESS in 1m 25s\n- gate-infra-puppet-apply-dsvm-f21 http://logs.openstack.org/66/233166/2/gate/gate-infra-puppet-apply-dsvm-f21/7997479/ : SUCCESS in 1m 03s","accounts_in_message":[],"_revision_number":2},{"id":"f5d297bd2ac0503a78397265536b7fa42b63a945","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-12 16:33:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1cd42a389f3924b054a034a19182d369f1317850","revisions":{"4dc6f2d68661fdd74e353ee3f9f598123102ac53":{"kind":"REWORK","_number":1,"created":"2015-10-09 16:18:51.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/66/233166/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-subunit2sql","ref":"refs/changes/66/233166/1","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/1"}}},"commit":{"parents":[{"commit":"ab6e196aa4754a1cfae66a44d0718b0209a2be06","subject":"Fix target path for regular git clone during tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-subunit2sql/commit/ab6e196aa4754a1cfae66a44d0718b0209a2be06"}]}],"author":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2015-10-09 16:10:01.000000000","tz":-240},"committer":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2015-10-09 16:15:45.000000000","tz":-240},"subject":"Use double quotes for mysql backup","message":"Use double quotes for mysql backup\n\nPreviously we were trying to run a mysql backup before we attempted\nmigrations, just in case something went wrong. However, the command\nwas failing because the $db_name variable wasn\u0027t being properly\ninterpolated. This commit fixes that by using \" around the command\ninstead of \u0027. Additionally, pipefail is set on the exec to prevent\nthis from succeeding but not working in the future.\n\nChange-Id: I746a9f0ae722802419f36f80626c3a6f4186bad6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-subunit2sql/commit/4dc6f2d68661fdd74e353ee3f9f598123102ac53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-subunit2sql/commit/4dc6f2d68661fdd74e353ee3f9f598123102ac53"}]},"branch":"refs/heads/master"},"1cd42a389f3924b054a034a19182d369f1317850":{"kind":"REWORK","_number":2,"created":"2015-10-09 20:06:58.000000000","uploader":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"ref":"refs/changes/66/233166/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/opendev/puppet-subunit2sql","ref":"refs/changes/66/233166/2","commands":{"Checkout":"git fetch https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/opendev/puppet-subunit2sql refs/changes/66/233166/2"}}},"commit":{"parents":[{"commit":"ab6e196aa4754a1cfae66a44d0718b0209a2be06","subject":"Fix target path for regular git clone during tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-subunit2sql/commit/ab6e196aa4754a1cfae66a44d0718b0209a2be06"}]}],"author":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2015-10-09 16:10:01.000000000","tz":-240},"committer":{"name":"Matthew Treinish","email":"mtreinish@kortar.org","date":"2015-10-09 20:06:36.000000000","tz":-240},"subject":"Use double quotes for mysql backup","message":"Use double quotes for mysql backup\n\nPreviously we were trying to run a mysql backup before we attempted\nmigrations, just in case something went wrong. However, the command\nwas failing because the $db_name variable wasn\u0027t being properly\ninterpolated. This commit fixes that by using \" around the command\ninstead of \u0027. Additionally, pipefail is set on the exec to prevent\nthis from succeeding but not working in the future.\n\nChange-Id: I746a9f0ae722802419f36f80626c3a6f4186bad6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-subunit2sql/commit/1cd42a389f3924b054a034a19182d369f1317850"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/opendev/puppet-subunit2sql/commit/1cd42a389f3924b054a034a19182d369f1317850"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}