)]}'
{"files/subunit-gearman-worker.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"77c2b69c90bbbc3cb791bbc2a351b9d6883be892","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            if mqtt_user:"},{"line_number":261,"context_line":"                auth \u003d {\u0027username\u0027: mqtt_user}"},{"line_number":262,"context_line":"            if mqtt_pass:"},{"line_number":263,"context_line":"                auth[\u0027password\u0027] \u003d mqtt_pass"},{"line_number":264,"context_line":"            tls \u003d None"},{"line_number":265,"context_line":"            if mqtt_ca_certs:"},{"line_number":266,"context_line":"                tls \u003d {\u0027ca_certs\u0027: mqtt_ca_certs, \u0027certfile\u0027: mqtt_certfile,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_6025ee5b","line":263,"updated":"2017-04-10 18:24:47.000000000","message":"Auth could be None here. Probably best to set auth \u003d {} above intead of auth \u003d None. Also, if username is supplied does that imply password must also be supplied and vice versa? might want to make the population of the auth dict a bit more robust around that.","commit_id":"50b0266166977534fa1a64d20c9235231c35375a"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"302b89207e17357febcd333343e233d0ecd4882e","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            if mqtt_user:"},{"line_number":261,"context_line":"                auth \u003d {\u0027username\u0027: mqtt_user}"},{"line_number":262,"context_line":"            if mqtt_pass:"},{"line_number":263,"context_line":"                auth[\u0027password\u0027] \u003d mqtt_pass"},{"line_number":264,"context_line":"            tls \u003d None"},{"line_number":265,"context_line":"            if mqtt_ca_certs:"},{"line_number":266,"context_line":"                tls \u003d {\u0027ca_certs\u0027: mqtt_ca_certs, \u0027certfile\u0027: mqtt_certfile,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_f313135b","line":263,"in_reply_to":"bff0334d_6025ee5b","updated":"2017-04-10 20:06:44.000000000","message":"So here\u0027s the fun thing it actually has to be None that\u0027s what\u0027s actually checked in the paho lib:\n\nhttps://github.com/eclipse/paho.mqtt.python/blob/master/src/paho/mqtt/publish.py#L126\n\nPassword is optional if username is present, but you need a username if you pass a password. I actually meant to indent the if mqtt_pass one more to indicate this, but looks like I screwed that up.","commit_id":"50b0266166977534fa1a64d20c9235231c35375a"}]}