)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"94c034136c5a2f7c7daca68418ac57b78655bc09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75d61cbb_ee05e866","updated":"2021-11-12 03:52:38.000000000","message":"I manually applied this to the currently running statusbot container on eavesdrop01 and the host connects again","commit_id":"067bc37ec09c9fd3b13c14135c92fe4ce1836ef4"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a9d52f9580cdd9f6858124c97242d823cf1870b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1cb14368_9481a663","updated":"2021-11-12 04:07:53.000000000","message":"I\u0027m going to merge this just so the production container is stable","commit_id":"067bc37ec09c9fd3b13c14135c92fe4ce1836ef4"}],"statusbot/bot.py":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"23ead885061c4d7672cdb23a74ed769a0a6cdbaa","unresolved":true,"context_lines":[{"line_number":560,"context_line":"    else:"},{"line_number":561,"context_line":"        base \u003d NoSASLStatusBot"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    if config.has_option(\u0027ircbot\u0027, \u0027use_ssl\u0027):"},{"line_number":564,"context_line":"        use_ssl \u003d config.getboolean(\u0027ircbot\u0027, \u0027use_ssl\u0027)"},{"line_number":565,"context_line":"    else:"},{"line_number":566,"context_line":"        use_ssl \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a017869_b5505c2c","side":"PARENT","line":563,"updated":"2021-11-12 03:59:24.000000000","message":"I also manually added \"use_ssl\u003dTrue\" to the [ircbot] section.  we shouldn\u0027t have changed the default ... but even then it wouldn\u0027t connect.","commit_id":"4c31332e23ed49fe9748d97c5a81b3097836aabc"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"12ca5ae5c8524b669cedc7de07f5296bb5a25119","unresolved":true,"context_lines":[{"line_number":560,"context_line":"    else:"},{"line_number":561,"context_line":"        base \u003d NoSASLStatusBot"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    if config.has_option(\u0027ircbot\u0027, \u0027use_ssl\u0027):"},{"line_number":564,"context_line":"        use_ssl \u003d config.getboolean(\u0027ircbot\u0027, \u0027use_ssl\u0027)"},{"line_number":565,"context_line":"    else:"},{"line_number":566,"context_line":"        use_ssl \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b4fb949_ff9e5711","side":"PARENT","line":563,"in_reply_to":"7a017869_b5505c2c","updated":"2021-11-12 10:36:36.000000000","message":"Oops, use_ssl should have been set to True in the else case.","commit_id":"4c31332e23ed49fe9748d97c5a81b3097836aabc"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"23ead885061c4d7672cdb23a74ed769a0a6cdbaa","unresolved":true,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    # SSL is set through class inheritance."},{"line_number":569,"context_line":"    if use_ssl:"},{"line_number":570,"context_line":"        class Bot(base, SSL):"},{"line_number":571,"context_line":"            pass"},{"line_number":572,"context_line":"    else:"},{"line_number":573,"context_line":"        class Bot(base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bdce24ca_13ba7e31","side":"PARENT","line":570,"updated":"2021-11-12 03:59:24.000000000","message":"Is this maybe supposed to be Bot(SSL, base) ?","commit_id":"4c31332e23ed49fe9748d97c5a81b3097836aabc"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"12ca5ae5c8524b669cedc7de07f5296bb5a25119","unresolved":true,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    # SSL is set through class inheritance."},{"line_number":569,"context_line":"    if use_ssl:"},{"line_number":570,"context_line":"        class Bot(base, SSL):"},{"line_number":571,"context_line":"            pass"},{"line_number":572,"context_line":"    else:"},{"line_number":573,"context_line":"        class Bot(base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7499183_90f091f9","side":"PARENT","line":570,"in_reply_to":"b51b9287_9e4c57ac","updated":"2021-11-12 10:36:36.000000000","message":"Arg, unfortunately, using `class Bot(SSL, base)` results in\n\n Traceback (most recent call last):\n  File \"statusbot/bot.py\", line 612, in \u003cmodule\u003e\n    main()\n  File \"statusbot/bot.py\", line 597, in main\n    _main(args.config)\n  File \"statusbot/bot.py\", line 576, in _main\n    Bot(channels, nicks, publishers, successlog,\n  File \"/lib/python3.8/site-packages/ib3/connection.py\", line 32, in __init__\n    super(SSL, self).__init__(*args, **kwargs)\n TypeError: __init__() got an unexpected keyword argument \u0027connect_factory\u0027","commit_id":"4c31332e23ed49fe9748d97c5a81b3097836aabc"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"7430d4559f70fc0c20905825bab0bdea171ee7f0","unresolved":true,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    # SSL is set through class inheritance."},{"line_number":569,"context_line":"    if use_ssl:"},{"line_number":570,"context_line":"        class Bot(base, SSL):"},{"line_number":571,"context_line":"            pass"},{"line_number":572,"context_line":"    else:"},{"line_number":573,"context_line":"        class Bot(base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b51b9287_9e4c57ac","side":"PARENT","line":570,"in_reply_to":"bdce24ca_13ba7e31","updated":"2021-11-12 07:40:28.000000000","message":"I think that that is pretty likely the issue, because the SSL mixin does some patching in its init() before calling super(), which comes late when the base class is referenced before.\nNote that even switching this would still make the resulting class (SSL, SASL, base) instead of (SASL, SSL, base) which we had before, but SASL is calling super() first, so that hopefully shouldn\u0027t matter as much.","commit_id":"4c31332e23ed49fe9748d97c5a81b3097836aabc"},{"author":{"_account_id":9311,"name":"Tristan Cacqueray","email":"tdecacqu@redhat.com","username":"tristanC"},"change_message_id":"0554e49be7b35a26babb7efc2bb113318cb48043","unresolved":true,"context_lines":[{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    # SSL is set through class inheritance."},{"line_number":569,"context_line":"    if use_ssl:"},{"line_number":570,"context_line":"        class Bot(base, SSL):"},{"line_number":571,"context_line":"            pass"},{"line_number":572,"context_line":"    else:"},{"line_number":573,"context_line":"        class Bot(base):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7780ef69_bc944088","side":"PARENT","line":570,"in_reply_to":"f7499183_90f091f9","updated":"2021-11-12 11:08:03.000000000","message":"It seems like this is happening because SASLStatusBot or NoSASLStatusBot defines a __init__ function. Though I\u0027m not sure what can be done to support non-ssl server.","commit_id":"4c31332e23ed49fe9748d97c5a81b3097836aabc"}]}