)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"49eb6b0454e7588f7b1310c4cb8aa984bc3ac006","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add order column to runs table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds an autoincrementing integer column to the runs table."},{"line_number":10,"context_line":"This is new column is needed to determine the order in which runs are"},{"line_number":11,"context_line":"added to the db. Support for this is needed by testrepository"},{"line_number":12,"context_line":"repositories since it needs to be able to determine which run is the"},{"line_number":13,"context_line":"most recent for some of it\u0027s operations. Additionally knowing the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baa201ad_77f15b00","line":10,"updated":"2014-10-06 17:59:27.000000000","message":"s/is new/new","commit_id":"5da90a81e7622d1383ad359b0fa757db545db258"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ddd2b127ae8debc186b73e17066d7dac788f06dd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add order column to runs table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds an autoincrementing integer column to the runs table."},{"line_number":10,"context_line":"This is new column is needed to determine the order in which runs are"},{"line_number":11,"context_line":"added to the db. Support for this is needed by testrepository"},{"line_number":12,"context_line":"repositories since it needs to be able to determine which run is the"},{"line_number":13,"context_line":"most recent for some of it\u0027s operations. Additionally knowing the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"baa201ad_121bbdca","line":10,"in_reply_to":"baa201ad_77f15b00","updated":"2014-10-06 19:14:16.000000000","message":"Done","commit_id":"5da90a81e7622d1383ad359b0fa757db545db258"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e6baec11251b44707abafda6817c8960bd49dd60","unresolved":false,"context_lines":[{"line_number":19,"context_line":"already adding a column was chosen because it\u0027s less difficult and"},{"line_number":20,"context_line":"should be faster. It also allows for downgrading, while changing the"},{"line_number":21,"context_line":"primary keys from a str uuid to an integer is something that can\u0027t"},{"line_number":22,"context_line":"be undone."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: If3c2251f9c62fc94f2c1716f6091b637c965e610"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baa201ad_68809cf7","line":22,"updated":"2014-10-06 20:13:30.000000000","message":"No need for this paragraph :)","commit_id":"8974cccf4c5c24d34382b2994162ba13b8760fcd"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"8337cfd2acb2348dc9acde458dfc98144e17c9d3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"already adding a column was chosen because it\u0027s less difficult and"},{"line_number":20,"context_line":"should be faster. It also allows for downgrading, while changing the"},{"line_number":21,"context_line":"primary keys from a str uuid to an integer is something that can\u0027t"},{"line_number":22,"context_line":"be undone."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: If3c2251f9c62fc94f2c1716f6091b637c965e610"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baa201ad_11d0181e","line":22,"in_reply_to":"baa201ad_68809cf7","updated":"2014-10-06 21:47:01.000000000","message":"Done","commit_id":"8974cccf4c5c24d34382b2994162ba13b8760fcd"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"2f06036689ac6f527445752fb8e5bad0fad1c3a5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add order column to runs table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds a timestamp run_order column to the runs table."},{"line_number":10,"context_line":"This new column is needed to determine the order in which runs are"},{"line_number":11,"context_line":"added to the db. Support for this is needed by testrepository"},{"line_number":12,"context_line":"repositories since it needs to be able to determine which run is the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"baa201ad_54b7ee39","line":9,"updated":"2014-10-06 22:29:20.000000000","message":"s/run_order/run_at :)","commit_id":"a8055fe5ef68a43542c10ae8d20fbc42003caa9c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ba35244fa7ab14774d68edd432d1a7cdceae98eb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add order column to runs table"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds a timestamp run_order column to the runs table."},{"line_number":10,"context_line":"This new column is needed to determine the order in which runs are"},{"line_number":11,"context_line":"added to the db. Support for this is needed by testrepository"},{"line_number":12,"context_line":"repositories since it needs to be able to determine which run is the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"baa201ad_94eb1612","line":9,"in_reply_to":"baa201ad_54b7ee39","updated":"2014-10-06 22:30:21.000000000","message":"Done","commit_id":"a8055fe5ef68a43542c10ae8d20fbc42003caa9c"}],"subunit2sql/db/models.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"49eb6b0454e7588f7b1310c4cb8aa984bc3ac006","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    passes \u003d sa.Column(sa.Integer())"},{"line_number":69,"context_line":"    run_time \u003d sa.Column(sa.Float())"},{"line_number":70,"context_line":"    artifacts \u003d sa.Column(sa.Text())"},{"line_number":71,"context_line":"    run_order \u003d sa.Column(sa.Integer, autoincrement\u003dTrue)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class TestRun(BASE, SubunitBase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_b7de636b","line":71,"updated":"2014-10-06 17:59:27.000000000","message":"Why not add a timestamp?","commit_id":"5da90a81e7622d1383ad359b0fa757db545db258"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"ddd2b127ae8debc186b73e17066d7dac788f06dd","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    passes \u003d sa.Column(sa.Integer())"},{"line_number":69,"context_line":"    run_time \u003d sa.Column(sa.Float())"},{"line_number":70,"context_line":"    artifacts \u003d sa.Column(sa.Text())"},{"line_number":71,"context_line":"    run_order \u003d sa.Column(sa.Integer, autoincrement\u003dTrue)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class TestRun(BASE, SubunitBase):"}],"source_content_type":"text/x-python","patch_set":14,"id":"baa201ad_d2cf7554","line":71,"in_reply_to":"baa201ad_b7de636b","updated":"2014-10-06 19:14:16.000000000","message":"That\u0027s a good idea, I was stuck thinking about how to add an autoincrementing non-primary key column with sa that I didn\u0027t even think about this.\n\nThe only issue is that for existing rows I don\u0027t think I\u0027ll be able to assign an a value, but I guess that\u0027s not a big deal as long as the ordering is correct.","commit_id":"5da90a81e7622d1383ad359b0fa757db545db258"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e6baec11251b44707abafda6817c8960bd49dd60","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    passes \u003d sa.Column(sa.Integer())"},{"line_number":70,"context_line":"    run_time \u003d sa.Column(sa.Float())"},{"line_number":71,"context_line":"    artifacts \u003d sa.Column(sa.Text())"},{"line_number":72,"context_line":"    run_order \u003d sa.Column(sa.DateTime,"},{"line_number":73,"context_line":"                          default\u003dlambda: datetime.datetime.now())"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_e873ac4b","line":72,"updated":"2014-10-06 20:13:30.000000000","message":"recommend calling the column run_at to denote it is a datetime column in the spirit of created_at, updated_at, deleted_at, etc :)","commit_id":"8974cccf4c5c24d34382b2994162ba13b8760fcd"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"8337cfd2acb2348dc9acde458dfc98144e17c9d3","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    passes \u003d sa.Column(sa.Integer())"},{"line_number":70,"context_line":"    run_time \u003d sa.Column(sa.Float())"},{"line_number":71,"context_line":"    artifacts \u003d sa.Column(sa.Text())"},{"line_number":72,"context_line":"    run_order \u003d sa.Column(sa.DateTime,"},{"line_number":73,"context_line":"                          default\u003dlambda: datetime.datetime.now())"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_51bc6006","line":72,"in_reply_to":"baa201ad_e873ac4b","updated":"2014-10-06 21:47:01.000000000","message":"Done","commit_id":"8974cccf4c5c24d34382b2994162ba13b8760fcd"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"e6baec11251b44707abafda6817c8960bd49dd60","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    run_time \u003d sa.Column(sa.Float())"},{"line_number":71,"context_line":"    artifacts \u003d sa.Column(sa.Text())"},{"line_number":72,"context_line":"    run_order \u003d sa.Column(sa.DateTime,"},{"line_number":73,"context_line":"                          default\u003dlambda: datetime.datetime.now())"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class TestRun(BASE, SubunitBase):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_48967840","line":73,"updated":"2014-10-06 20:13:30.000000000","message":"No need for lambda :) Just do this:\n\n default\u003ddatetime.datetime.utcnow","commit_id":"8974cccf4c5c24d34382b2994162ba13b8760fcd"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"8337cfd2acb2348dc9acde458dfc98144e17c9d3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    run_time \u003d sa.Column(sa.Float())"},{"line_number":71,"context_line":"    artifacts \u003d sa.Column(sa.Text())"},{"line_number":72,"context_line":"    run_order \u003d sa.Column(sa.DateTime,"},{"line_number":73,"context_line":"                          default\u003dlambda: datetime.datetime.now())"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class TestRun(BASE, SubunitBase):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_31c35c8a","line":73,"in_reply_to":"baa201ad_48967840","updated":"2014-10-06 21:47:01.000000000","message":"Done","commit_id":"8974cccf4c5c24d34382b2994162ba13b8760fcd"}]}
