)]}'
{"subunit2sql/db/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"71aed7ce072547beb8ae94aaa78a8ae18aadb559","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    return query.all()"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def get_all_tests(session\u003dNone):"},{"line_number":164,"context_line":"    session \u003d session or get_session()"},{"line_number":165,"context_line":"    query \u003d db_utils.model_query(models.Test)"},{"line_number":166,"context_line":"    return query.all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_0381ea49","line":163,"updated":"2014-09-02 17:56:08.000000000","message":"putting session object to global method is what you don\u0027t want to do. \n\nBecause if some method in db.api that uses this will fail cause of dropped connection. \n\nit will make the mess... cause of this code: \n\nhttps://github.com/openstack/oslo.db/blob/master/oslo/db/api.py#L197-L201","commit_id":"c88345897a1fdfe0a51d853c9041a0d8ac69b575"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"940f8dbb813ada242ea7c598bc98eb3108ed8e95","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    return query.all()"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def get_all_tests(session\u003dNone):"},{"line_number":164,"context_line":"    session \u003d session or get_session()"},{"line_number":165,"context_line":"    query \u003d db_utils.model_query(models.Test)"},{"line_number":166,"context_line":"    return query.all()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_ac794e95","line":163,"in_reply_to":"fa98f980_0381ea49","updated":"2014-09-29 19:53:55.000000000","message":"Can you elaborate a bit more on what the recommended pattern here would be?\n\nLooking at that example you linked it\u0027s not clear to me where that would come into play here. From what I can tell in the code here that DBAPI class isn\u0027t being used anywhere. \n\nBut, I\u0027m not super familiar with using oslo.db so if you have a recommendation on how to do this better please let me know.","commit_id":"c88345897a1fdfe0a51d853c9041a0d8ac69b575"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"da92006757cc7459733f581bb121555d2883f009","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def get_all_tests(session\u003dNone):"},{"line_number":164,"context_line":"    session \u003d session or get_session()"},{"line_number":165,"context_line":"    query \u003d db_utils.model_query(models.Test)"},{"line_number":166,"context_line":"    return query.all()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_ea0e21e4","line":165,"updated":"2014-10-07 21:09:12.000000000","message":"Oversight? You\u0027re not passing session here.","commit_id":"5a8fed78c28f6490146ecd627d6ae300b59a9e1b"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5a4efc5a1803e861fe334a4b2a10b23ac7ae9ef3","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def get_all_tests(session\u003dNone):"},{"line_number":164,"context_line":"    session \u003d session or get_session()"},{"line_number":165,"context_line":"    query \u003d db_utils.model_query(models.Test)"},{"line_number":166,"context_line":"    return query.all()"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baa201ad_8ad595e6","line":165,"in_reply_to":"baa201ad_ea0e21e4","updated":"2014-10-07 21:12:21.000000000","message":"Oops, good catch.","commit_id":"5a8fed78c28f6490146ecd627d6ae300b59a9e1b"}]}