)]}'
{"subunit2sql/write_subunit.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"efc6e8a81b3878a5032e7b5f86cb71b70aeaa4c0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    shell.parse_args(sys.argv)"},{"line_number":115,"context_line":"    if not CONF.run_id and not CONF.average:"},{"line_number":116,"context_line":"        print(\u0027You must specify a run_id or generate an average run stream\u0027)"},{"line_number":117,"context_line":"        return 1"},{"line_number":118,"context_line":"    if CONF.out_path:"},{"line_number":119,"context_line":"        fd \u003d open(CONF.out_path, \u0027w\u0027)"},{"line_number":120,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_de49e333","line":117,"updated":"2014-12-16 02:43:32.000000000","message":"According to this behavior, we need the following check also here:\n\n if CONF.run_id and CONF.average:\n     print(\u0027You must specify one of run_id and --average\u0027)\n     return 1\n\nor better error message.","commit_id":"9bd49b9508ca0e9e4f95d2c79200bf070a87c6d1"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"b7ccd772dd261718fc615dced136f3d825da3979","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    shell.parse_args(sys.argv)"},{"line_number":115,"context_line":"    if not CONF.run_id and not CONF.average:"},{"line_number":116,"context_line":"        print(\u0027You must specify a run_id or generate an average run stream\u0027)"},{"line_number":117,"context_line":"        return 1"},{"line_number":118,"context_line":"    if CONF.out_path:"},{"line_number":119,"context_line":"        fd \u003d open(CONF.out_path, \u0027w\u0027)"},{"line_number":120,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_de5c834f","line":117,"in_reply_to":"3a961159_de49e333","updated":"2014-12-16 03:26:46.000000000","message":"Nice catch, yes I need that check too. I\u0027ll add that check (and improve the error messages)","commit_id":"9bd49b9508ca0e9e4f95d2c79200bf070a87c6d1"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"79e810edaf38ab16d18997e27c632a270fd766a2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        fd \u003d open(CONF.out_path, \u0027w\u0027)"},{"line_number":125,"context_line":"    else:"},{"line_number":126,"context_line":"        fd \u003d sys.stdout"},{"line_number":127,"context_line":"    if not CONF.average:"},{"line_number":128,"context_line":"        sql2subunit(CONF.run_id, fd)"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        avg_sql2subunit(fd)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_a902fcb1","line":127,"updated":"2014-12-17 01:24:50.000000000","message":"Why do you use the negative condition here?\nI think a negative condition is a little bit difficult to understand the behavior. \nHow about this?\n\n  if CONF.average:\n    avg_sql2subunit(fd)\n  else:\n    sql2subunit(CONF.run_id, fd)","commit_id":"174e8ba1c3c7d20b780d2de3b63c5acde977eaf1"}]}