)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5be86634618cb537885173c8b4a9550011472b69","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix issues in migration 1ff737bef438"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit fixes a couple of issues with the migration 1ff737bef438."},{"line_number":10,"context_line":"First on certain mysql configurations the status column is to big to"},{"line_number":11,"context_line":"index, so this adds a length to the index to allow it to run on those"},{"line_number":12,"context_line":"envs. The second is that since the migration fails to run on certain"},{"line_number":13,"context_line":"envs checks need to be done to account for migrations that are only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_b7a92126","line":10,"updated":"2015-08-07 03:29:18.000000000","message":"I would not be general here. Specifically, on multi-byte utf-8 configured mysql systems, which is likely to be _all_ these days since it is the default in 5.6 and later.\n\nAlso:\n\ns/to big/too big/ #notaminusone","commit_id":"827783ff0f324da680f08a1c42104e57dbbafc3f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9a8594ad3862673669eb93e9b81c53389dbae4cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix issues in migration 1ff737bef438"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit fixes a couple of issues with the migration 1ff737bef438."},{"line_number":10,"context_line":"First on certain mysql configurations the status column is to big to"},{"line_number":11,"context_line":"index, so this adds a length to the index to allow it to run on those"},{"line_number":12,"context_line":"envs. The second is that since the migration fails to run on certain"},{"line_number":13,"context_line":"envs checks need to be done to account for migrations that are only"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_0eef851e","line":10,"in_reply_to":"1a4dcd0f_b7a92126","updated":"2015-08-07 14:37:24.000000000","message":"oh, that\u0027s a good point. I think this is worth a respin.","commit_id":"827783ff0f324da680f08a1c42104e57dbbafc3f"}],"subunit2sql/migrations/versions/1ff737bef438_add_indexes_on_common_search_fields.py":[{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"5be86634618cb537885173c8b4a9550011472b69","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # graph query patterns"},{"line_number":65,"context_line":"    if \u0027ix_test_id_status\u0027 not in test_run_indx_names:"},{"line_number":66,"context_line":"        op.create_index(\u0027ix_test_id_status\u0027, \u0027test_runs\u0027,"},{"line_number":67,"context_line":"                        [\u0027test_id\u0027, \u0027status\u0027], mysql_length\u003d30)"},{"line_number":68,"context_line":"    if \u0027ix_test_id_start_time\u0027 not in test_run_indx_names:"},{"line_number":69,"context_line":"        op.create_index(\u0027ix_test_id_start_time\u0027, \u0027test_runs\u0027, [\u0027test_id\u0027,"},{"line_number":70,"context_line":"                                                               \u0027start_time\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_9750a533","line":67,"updated":"2015-08-07 03:29:18.000000000","message":"Is mysql_length ignored on non-mysql engines, or does subunit2sql only support mysql? #notaminusone","commit_id":"827783ff0f324da680f08a1c42104e57dbbafc3f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"9a8594ad3862673669eb93e9b81c53389dbae4cd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # graph query patterns"},{"line_number":65,"context_line":"    if \u0027ix_test_id_status\u0027 not in test_run_indx_names:"},{"line_number":66,"context_line":"        op.create_index(\u0027ix_test_id_status\u0027, \u0027test_runs\u0027,"},{"line_number":67,"context_line":"                        [\u0027test_id\u0027, \u0027status\u0027], mysql_length\u003d30)"},{"line_number":68,"context_line":"    if \u0027ix_test_id_start_time\u0027 not in test_run_indx_names:"},{"line_number":69,"context_line":"        op.create_index(\u0027ix_test_id_start_time\u0027, \u0027test_runs\u0027, [\u0027test_id\u0027,"},{"line_number":70,"context_line":"                                                               \u0027start_time\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_4eb34d4d","line":67,"in_reply_to":"1a4dcd0f_9750a533","updated":"2015-08-07 14:37:24.000000000","message":"TBH, I\u0027m not sure. I want to assume it is, the docs implied that this was the case since all the extra kwargs are supposed to be dialect specific. (http://alembic.readthedocs.org/en/latest/ops.html#alembic.operations.Operations.create_index ) FWIW, we test the migrations with data on mysql and postgres and things didn\u0027t blow up here, so I\u0027m inclined to believe it just ignores this on other engines.","commit_id":"827783ff0f324da680f08a1c42104e57dbbafc3f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d9091e4fe5d5a9222f8d4cb5c5a14a75d22b0f82","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # graph query patterns"},{"line_number":65,"context_line":"    if \u0027ix_test_id_status\u0027 not in test_run_indx_names:"},{"line_number":66,"context_line":"        op.create_index(\u0027ix_test_id_status\u0027, \u0027test_runs\u0027,"},{"line_number":67,"context_line":"                        [\u0027test_id\u0027, \u0027status\u0027], mysql_length\u003d30)"},{"line_number":68,"context_line":"    if \u0027ix_test_id_start_time\u0027 not in test_run_indx_names:"},{"line_number":69,"context_line":"        op.create_index(\u0027ix_test_id_start_time\u0027, \u0027test_runs\u0027, [\u0027test_id\u0027,"},{"line_number":70,"context_line":"                                                               \u0027start_time\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_25613fd3","line":67,"updated":"2015-08-07 15:04:40.000000000","message":"According to http://docs.sqlalchemy.org/en/rel_1_0/dialects/mysql.html?highlight\u003dmysql_length the mysql_length should be a dict for indexes involving multiple columns, unless we want to limit all columns to 30.\n\nStatus can be safely truncated, but test_id should not be truncated.","commit_id":"cdc3fa974afa9f24662ef17e026d3cb810b8f1ce"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"083bfaa5a2bc7955902d16a1abc59e9fe459d5c5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # graph query patterns"},{"line_number":65,"context_line":"    if \u0027ix_test_id_status\u0027 not in test_run_indx_names:"},{"line_number":66,"context_line":"        op.create_index(\u0027ix_test_id_status\u0027, \u0027test_runs\u0027,"},{"line_number":67,"context_line":"                        [\u0027test_id\u0027, \u0027status\u0027], mysql_length\u003d30)"},{"line_number":68,"context_line":"    if \u0027ix_test_id_start_time\u0027 not in test_run_indx_names:"},{"line_number":69,"context_line":"        op.create_index(\u0027ix_test_id_start_time\u0027, \u0027test_runs\u0027, [\u0027test_id\u0027,"},{"line_number":70,"context_line":"                                                               \u0027start_time\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a4dcd0f_0518c3d1","line":67,"in_reply_to":"1a4dcd0f_25613fd3","updated":"2015-08-07 15:14:38.000000000","message":"Done","commit_id":"cdc3fa974afa9f24662ef17e026d3cb810b8f1ce"}]}