)]}'
{"subunit2sql/db/api.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3fc94e9109d323b299c8526d1d059f138de3ea97","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    return query.all()"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"def get_all_runs(start_date\u003dNone, stop_date\u003dNone, session\u003dNone):"},{"line_number":400,"context_line":"    \"\"\"Return all runs from the DB."},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    :param str: optional start_date, if provided only runs started at or after"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_2f86a865","line":399,"updated":"2015-09-15 14:56:27.000000000","message":"So I\u0027m not sure we want to put the args in front. I know it\u0027s the convention I used in the other methods to put session at the end of the signature, but but this would break backwards compat with anything that calls this method. Because if someone is using session positionally when this lands it\u0027ll no longer work.","commit_id":"4daae6c7aee8cff4bcd20096baed0716bab0e99e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a487fef9ab89de23f7d230dce0ef6725338e321c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    return query.all()"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"def get_all_runs(start_date\u003dNone, stop_date\u003dNone, session\u003dNone):"},{"line_number":400,"context_line":"    \"\"\"Return all runs from the DB."},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    :param str: optional start_date, if provided only runs started at or after"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_916eeaff","line":399,"in_reply_to":"ba15a1d1_2f86a865","updated":"2015-09-15 19:23:41.000000000","message":"How about renaming this method to\n\n def get_all_runs_with_dates(start_date\u003dNone, stop_date\u003dNone, session\u003dNone):\n\nand implementing the existing get_all_runs like\n\n def get_all_runs(session\u003dNone):\n     get_all_runs_with_dates(None, None, session)\n\nfor avoiding backwards incompatible changes?","commit_id":"4daae6c7aee8cff4bcd20096baed0716bab0e99e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"3fc94e9109d323b299c8526d1d059f138de3ea97","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    query \u003d db_utils.model_query(models.Run, session\u003dsession)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    # Process date bounds"},{"line_number":417,"context_line":"    if isinstance(start_date, str):"},{"line_number":418,"context_line":"        start_date \u003d datetime.datetime.strptime(start_date, \u0027%b %d %Y\u0027)"},{"line_number":419,"context_line":"    if isinstance(stop_date, str):"},{"line_number":420,"context_line":"        stop_date \u003d datetime.datetime.strptime(stop_date, \u0027%b %d %Y\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_6f5100d8","line":417,"updated":"2015-09-15 14:56:27.000000000","message":"I recognize this code :) I think we  should extract this into a helper function, because I expect that we\u0027ll be adding similar functionality to other methods.","commit_id":"4daae6c7aee8cff4bcd20096baed0716bab0e99e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c1059a262be4b3c407dd8c70e026d9aff536a1b7","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if isinstance(stop_date, str):"},{"line_number":58,"context_line":"        stop_date \u003d datetime.datetime.strptime(stop_date, \u0027%b %d %Y\u0027)"},{"line_number":59,"context_line":"    if start_date:"},{"line_number":60,"context_line":"        query.filter(models.Run.run_at \u003c\u003d start_date)"},{"line_number":61,"context_line":"    if stop_date:"},{"line_number":62,"context_line":"        query.filter(models.Run.run_at \u003e\u003d stop_date)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_97b497d1","line":60,"updated":"2015-09-15 21:31:28.000000000","message":"I think this needs to be query \u003d query.filter(...","commit_id":"43f47ccfc86904bbf657ab2bbfcf8c5ed228dc2f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c1059a262be4b3c407dd8c70e026d9aff536a1b7","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    if start_date:"},{"line_number":60,"context_line":"        query.filter(models.Run.run_at \u003c\u003d start_date)"},{"line_number":61,"context_line":"    if stop_date:"},{"line_number":62,"context_line":"        query.filter(models.Run.run_at \u003e\u003d stop_date)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def create_test(test_id, run_count\u003d0, success\u003d0, failure\u003d0, run_time\u003d0.0,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_b7b75bd7","line":62,"updated":"2015-09-15 21:31:28.000000000","message":"ditto","commit_id":"43f47ccfc86904bbf657ab2bbfcf8c5ed228dc2f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"c1059a262be4b3c407dd8c70e026d9aff536a1b7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    if stop_date:"},{"line_number":62,"context_line":"        query.filter(models.Run.run_at \u003e\u003d stop_date)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def create_test(test_id, run_count\u003d0, success\u003d0, failure\u003d0, run_time\u003d0.0,"},{"line_number":66,"context_line":"                session\u003dNone):"},{"line_number":67,"context_line":"    \"\"\"Create a new test record in the database."}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_57ceff5a","line":64,"updated":"2015-09-15 21:31:28.000000000","message":"I think that you need to return query here, otherwise I\u0027m not sure the filter function will apply","commit_id":"43f47ccfc86904bbf657ab2bbfcf8c5ed228dc2f"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"638906e2d5a0796013311c3865cefad239d80368","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    if isinstance(stop_date, str):"},{"line_number":58,"context_line":"        stop_date \u003d datetime.datetime.strptime(stop_date, \u0027%b %d %Y\u0027)"},{"line_number":59,"context_line":"    if start_date:"},{"line_number":60,"context_line":"        query.filter(models.Run.run_at \u003c\u003d start_date)"},{"line_number":61,"context_line":"    if stop_date:"},{"line_number":62,"context_line":"        query.filter(models.Run.run_at \u003e\u003d stop_date)"},{"line_number":63,"context_line":"    return query"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba15a1d1_1252d5dd","line":60,"updated":"2015-09-15 21:50:13.000000000","message":"I still think this needs to be query \u003d query.filter()","commit_id":"b81d890986e86703101ff7eaf5cf07edfc00c487"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"a6b2f6ddd26839d6c9d19aa9dec7c7ec74fa0752","unresolved":false,"context_lines":[{"line_number":972,"context_line":"            models.RunMetadata.key \u003d\u003d key)"},{"line_number":973,"context_line":""},{"line_number":974,"context_line":"    run_pass_query \u003d _filter_runs_by_date(run_pass_query, start_date, stop_date)"},{"line_number":975,"context_line":"    run_fail_query \u003d _filter_runs_by_date(run_fail_query, start_date, stop_date)"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    run_passes \u003d run_pass_query.values(models.RunMetadata.value)"},{"line_number":978,"context_line":"    run_fails \u003d run_fail_query.values(models.RunMetadata.value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_0d55da1b","line":975,"updated":"2015-09-15 22:32:35.000000000","message":"The above 2 lines are over 79 chars.\nwe need to fix here for passing pep8 check.","commit_id":"535cb13d53815c013ae0692a33b95fb562fc3aad"}]}