)]}'
{"subunit2sql/db/api.py":[{"author":{"_account_id":18359,"name":"Moises Trovó","email":"mtrovo@thoughtworks.com","username":"mtrovo"},"change_message_id":"60ca2df6cc8f56e42d0e84f278bb12cde2529a92","unresolved":false,"context_lines":[{"line_number":440,"context_line":"    return count_query.all()"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"def get_all_runs_by_date(start_date\u003dNone, stop_date\u003dNone, page\u003dNone,"},{"line_number":443,"context_line":"                         session\u003dNone):"},{"line_number":444,"context_line":"    \"\"\"Return all runs in a time interval from the DB."},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    :param str: optional start_date, if provided only runs started at or after"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_9700bb67","line":443,"updated":"2015-09-17 15:30:36.000000000","message":"it would be better to pass page_size as an argument with default value of PER_PAGE, so if there\u0027s a need to change the page size it\u0027s already supported","commit_id":"1286f3c0644c48ecf524fe6db450082c5f7e8b6f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d6e962b0d3184f2d6b29c8c6f6d445df278511dc","unresolved":false,"context_lines":[{"line_number":440,"context_line":"    return count_query.all()"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"def get_all_runs_by_date(start_date\u003dNone, stop_date\u003dNone, page\u003dNone,"},{"line_number":443,"context_line":"                         session\u003dNone):"},{"line_number":444,"context_line":"    \"\"\"Return all runs in a time interval from the DB."},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    :param str: optional start_date, if provided only runs started at or after"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_c948ccce","line":443,"in_reply_to":"ba15a1d1_9700bb67","updated":"2015-09-17 23:46:27.000000000","message":"Sure I can do that, I just thought I\u0027d start with a minimal API change.","commit_id":"1286f3c0644c48ecf524fe6db450082c5f7e8b6f"},{"author":{"_account_id":18359,"name":"Moises Trovó","email":"mtrovo@thoughtworks.com","username":"mtrovo"},"change_message_id":"60ca2df6cc8f56e42d0e84f278bb12cde2529a92","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        count_query \u003d query.values("},{"line_number":466,"context_line":"            sqlalchemy.func.count(\u0027*\u0027).select_from(models.Run))"},{"line_number":467,"context_line":"        count_query \u003d _filter_runs_by_date(count_query, start_date, stop_date)"},{"line_number":468,"context_line":"        count \u003d count_query.all()"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        # Apply pagingation filter to the query"},{"line_number":471,"context_line":"        query \u003d _get_page(query, page, PER_PAGE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_f7757731","line":468,"updated":"2015-09-17 15:30:36.000000000","message":"Why is this block needed? it seems that count and count_query is not used anywhere else","commit_id":"1286f3c0644c48ecf524fe6db450082c5f7e8b6f"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"d6e962b0d3184f2d6b29c8c6f6d445df278511dc","unresolved":false,"context_lines":[{"line_number":465,"context_line":"        count_query \u003d query.values("},{"line_number":466,"context_line":"            sqlalchemy.func.count(\u0027*\u0027).select_from(models.Run))"},{"line_number":467,"context_line":"        count_query \u003d _filter_runs_by_date(count_query, start_date, stop_date)"},{"line_number":468,"context_line":"        count \u003d count_query.all()"},{"line_number":469,"context_line":""},{"line_number":470,"context_line":"        # Apply pagingation filter to the query"},{"line_number":471,"context_line":"        query \u003d _get_page(query, page, PER_PAGE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_490b5c7d","line":468,"in_reply_to":"ba15a1d1_f7757731","updated":"2015-09-17 23:46:27.000000000","message":"It\u0027s not needed, good catch.","commit_id":"1286f3c0644c48ecf524fe6db450082c5f7e8b6f"}]}