)]}'
{"subunit2sql/db/api.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d269ce95071f6f06a58aadf0ef05841dbefdf02f","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    :param str test_id: The test\u0027s test_id (the test_id column in the test"},{"line_number":618,"context_line":"                        table) which to get all test runs for"},{"line_number":619,"context_line":"    :param session: optional session object if one isn\u0027t provided a new session"},{"line_number":620,"context_line":"                    will be acquired for the duration of this operation"},{"line_number":621,"context_line":"    :param datetime.datetime start_date: The date to use as the start date for"},{"line_number":622,"context_line":"                                         results"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_6aad91e8","line":619,"updated":"2015-10-14 06:01:43.000000000","message":"nit: s/optional/Optional/\n\nand why don\u0027t you put this session docstring at the end like the above argument?","commit_id":"4d472710a6e63f5dff6f9ea897bb1b23d16a1331"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4d997bb80561bcbd010c70e5b0e40653675aa679","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    :param str test_id: The test\u0027s test_id (the test_id column in the test"},{"line_number":618,"context_line":"                        table) which to get all test runs for"},{"line_number":619,"context_line":"    :param session: optional session object if one isn\u0027t provided a new session"},{"line_number":620,"context_line":"                    will be acquired for the duration of this operation"},{"line_number":621,"context_line":"    :param datetime.datetime start_date: The date to use as the start date for"},{"line_number":622,"context_line":"                                         results"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_af15609c","line":619,"in_reply_to":"5a2ca52d_6aad91e8","updated":"2015-10-16 23:36:53.000000000","message":"because I was sloppy in my copy and paste from another function","commit_id":"4d472710a6e63f5dff6f9ea897bb1b23d16a1331"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e6812a5f4b343ee701fbeca8b8602d3a9af2ed2f","unresolved":false,"context_lines":[{"line_number":616,"context_line":""},{"line_number":617,"context_line":"    :param str test_id: The test\u0027s test_id (the test_id column in the test"},{"line_number":618,"context_line":"                        table) which to get all test runs for"},{"line_number":619,"context_line":"    :param session: optional session object if one isn\u0027t provided a new session"},{"line_number":620,"context_line":"                    will be acquired for the duration of this operation"},{"line_number":621,"context_line":"    :param datetime.datetime start_date: The date to use as the start date for"},{"line_number":622,"context_line":"                                         results"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_6fadc387","line":619,"in_reply_to":"5a2ca52d_af15609c","updated":"2015-10-19 00:53:14.000000000","message":"Ok, this is nit thing.\nAnd we can fix them later.","commit_id":"4d472710a6e63f5dff6f9ea897bb1b23d16a1331"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d269ce95071f6f06a58aadf0ef05841dbefdf02f","unresolved":false,"context_lines":[{"line_number":637,"context_line":"            models.TestRun.start_time \u003e\u003d start_date)"},{"line_number":638,"context_line":"    if stop_date:"},{"line_number":639,"context_line":"        test_runs_query \u003d test_runs_query.filter("},{"line_number":640,"context_line":"            models.TestRun.start_time \u003c\u003d stop_date)"},{"line_number":641,"context_line":"    test_runs \u003d test_runs_query.all()"},{"line_number":642,"context_line":"    return test_runs"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_ea63e1af","line":640,"updated":"2015-10-14 06:01:43.000000000","message":"models.TestRun contains stop_time also.\n\nIs it fine to compare start_time here?\nI accept both of start_time and stop_time for that according to the above docstring for stop_date, I just like to confirm this.","commit_id":"4d472710a6e63f5dff6f9ea897bb1b23d16a1331"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"4d997bb80561bcbd010c70e5b0e40653675aa679","unresolved":false,"context_lines":[{"line_number":637,"context_line":"            models.TestRun.start_time \u003e\u003d start_date)"},{"line_number":638,"context_line":"    if stop_date:"},{"line_number":639,"context_line":"        test_runs_query \u003d test_runs_query.filter("},{"line_number":640,"context_line":"            models.TestRun.start_time \u003c\u003d stop_date)"},{"line_number":641,"context_line":"    test_runs \u003d test_runs_query.all()"},{"line_number":642,"context_line":"    return test_runs"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_ef1fd8b4","line":640,"in_reply_to":"5a2ca52d_ea63e1af","updated":"2015-10-16 23:36:53.000000000","message":"Yeah so for date filtering, I\u0027ve only been using only start_date.I figure since we\u0027re looking for results in a certain window we should either use all the start_times or all the end times for a test run.\n\nOtherwise we\u0027d be filtering test_runs that started after start_time and finished before stop_time, which seems more confusing to me. But I don\u0027t really have a strong opinion on this.","commit_id":"4d472710a6e63f5dff6f9ea897bb1b23d16a1331"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"e6812a5f4b343ee701fbeca8b8602d3a9af2ed2f","unresolved":false,"context_lines":[{"line_number":637,"context_line":"            models.TestRun.start_time \u003e\u003d start_date)"},{"line_number":638,"context_line":"    if stop_date:"},{"line_number":639,"context_line":"        test_runs_query \u003d test_runs_query.filter("},{"line_number":640,"context_line":"            models.TestRun.start_time \u003c\u003d stop_date)"},{"line_number":641,"context_line":"    test_runs \u003d test_runs_query.all()"},{"line_number":642,"context_line":"    return test_runs"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_efaf937b","line":640,"in_reply_to":"5a2ca52d_ef1fd8b4","updated":"2015-10-19 00:53:14.000000000","message":"I also don\u0027t have strong opinion on this, so nice to go forward with current implementation.","commit_id":"4d472710a6e63f5dff6f9ea897bb1b23d16a1331"}]}