)]}'
{"setup.cfg":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"01d7cf4fc2f7657da50e18a76be247e69907674e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    subunit2sql.shell \u003d subunit2sql.shell:list_opts"},{"line_number":34,"context_line":"    subunit2sql.write_subunit \u003d subunit2sql.write_subunit:list_opts"},{"line_number":35,"context_line":"subunit2sql.attachments \u003d"},{"line_number":36,"context_line":"    sql \u003d subunit2sql.db:api"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[build_sphinx]"},{"line_number":39,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"fa80f949_2b42f968","line":36,"updated":"2015-11-06 00:44:14.000000000","message":"I don\u0027t really understand why this is an entry point. I understand you want a plugin interface, but \u0027handle attachments\u0027 is awfully specific. What about just an extra-handlers thing...","commit_id":"2b0ed6619e889a9df92833f1ef4aeda04b0ae46b"}],"subunit2sql/shell.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"01d7cf4fc2f7657da50e18a76be247e69907674e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"               help\u003d\u0027The regex to use to extract the comma separated list of \u0027"},{"line_number":45,"context_line":"                    \u0027test attributes from the test_id\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027attachment_driver\u0027, default\u003d\u0027sql\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027plugin name used to store attachments\u0027)"},{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"_version_ \u003d version.VersionInfo(\u0027subunit2sql\u0027).version_string()"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_7628e886","line":47,"updated":"2015-11-06 00:44:14.000000000","message":"I don\u0027t think we want to make attachment storing be a plugin. I think what you want is the ability to have a plugin handle a stream - which is entirely different.","commit_id":"2b0ed6619e889a9df92833f1ef4aeda04b0ae46b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"01d7cf4fc2f7657da50e18a76be247e69907674e","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"def process_results(results):"},{"line_number":116,"context_line":"    attachdriver \u003d driver.DriverManager("},{"line_number":117,"context_line":"        \u0027subunit2sql.attachments\u0027, CONF.attachment_driver)"},{"line_number":118,"context_line":"    session \u003d api.get_session()"},{"line_number":119,"context_line":"    run_time \u003d results.pop(\u0027run_time\u0027)"},{"line_number":120,"context_line":"    totals \u003d get_run_totals(results)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_163abccc","line":117,"updated":"2015-11-06 00:44:14.000000000","message":"So this should just be picking up extra stream handlers.","commit_id":"2b0ed6619e889a9df92833f1ef4aeda04b0ae46b"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"01d7cf4fc2f7657da50e18a76be247e69907674e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        if results[test][\u0027attachments\u0027]:"},{"line_number":157,"context_line":"            attachdriver.driver.add_test_run_attachments("},{"line_number":158,"context_line":"                results[test][\u0027attachments\u0027], test_run.id,"},{"line_number":159,"context_line":"                attachdriver.driver.get_session())"},{"line_number":160,"context_line":"    session.close()"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_16415c38","line":159,"updated":"2015-11-06 00:44:14.000000000","message":"And this bit here shouldn\u0027t be needed - because all the work can be handled in the stream processing.","commit_id":"2b0ed6619e889a9df92833f1ef4aeda04b0ae46b"}]}