)]}'
{"subunit2sql/tests/test_shell.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"acbab3cdb4a6942e06ff5e5974d8fe300822847b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    @mock.patch(\u0027subunit2sql.shell.process_results\u0027)"},{"line_number":164,"context_line":"    def test_main_multiple_files(self, process_results_mock,"},{"line_number":165,"context_line":"                                 read_subunit_mock):"},{"line_number":166,"context_line":"        tfile1 \u003d tempfile.NamedTemporaryFile()"},{"line_number":167,"context_line":"        tfile2 \u003d tempfile.NamedTemporaryFile()"},{"line_number":168,"context_line":"        tfile1.write(\u0027test me later 1\u0027)"},{"line_number":169,"context_line":"        tfile2.write(\u0027test me later 2\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_be1940d9","line":166,"updated":"2015-11-10 22:45:24.000000000","message":"do we want to add an addcleanup(tfile.close) here? I mean it should be implicit when the method exits but anytime I see a file create in a test I always wonder about the cleanup story.\n\nMy other thought would be to use an in memory type instead of an actual file if possible, but both of these are just nits.","commit_id":"876fb3d44354c898cd01ad07b2c74716408bf2ad"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"6ce33f00146fa402dfbaf5c7c8dd856f17d445a6","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    @mock.patch(\u0027subunit2sql.shell.process_results\u0027)"},{"line_number":164,"context_line":"    def test_main_multiple_files(self, process_results_mock,"},{"line_number":165,"context_line":"                                 read_subunit_mock):"},{"line_number":166,"context_line":"        tfile1 \u003d tempfile.NamedTemporaryFile()"},{"line_number":167,"context_line":"        tfile2 \u003d tempfile.NamedTemporaryFile()"},{"line_number":168,"context_line":"        tfile1.write(\u0027test me later 1\u0027)"},{"line_number":169,"context_line":"        tfile2.write(\u0027test me later 2\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_3e89d0c9","line":166,"in_reply_to":"da85f559_be1940d9","updated":"2015-11-10 22:52:47.000000000","message":"No, oslotest\u0027s base creates a nested temp directory fixture which is entirely wiped, so cleanups of any individual things that respect the tempdir are unnecessary.\n\nAn in-memory type would not work, because main() specifically wants to open the file, and that is what we\u0027re testing.","commit_id":"876fb3d44354c898cd01ad07b2c74716408bf2ad"}]}