)]}'
{"subunit2sql/db/api.py":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"408143682aad8186d352e25f9c9df510b0a5abc2","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"    return attachments"},{"line_number":1523,"context_line":""},{"line_number":1524,"context_line":"def get_recent_failed_runs_by_status_and_run_metadata(key, value, num_runs\u003d10,"},{"line_number":1525,"context_line":"                                                      start_date\u003dNone, "},{"line_number":1526,"context_line":"                                                      session\u003dNone):"},{"line_number":1527,"context_line":"    \"\"\"Get a list of recent failed runs for a given run metadata pair"},{"line_number":1528,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_f19b7170","line":1525,"updated":"2016-04-13 21:46:57.000000000","message":"trailing space","commit_id":"08d770db0f9dd3896cb7d932a322ab5869d6406d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b2e79344d611ace41c1e589180f1ac655256ea24","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"    return attachments"},{"line_number":1523,"context_line":""},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"def get_recent_failed_runs_by_run_metadata(key, value, num_runs\u003d10,"},{"line_number":1526,"context_line":"                                           start_date\u003dNone, session\u003dNone):"},{"line_number":1527,"context_line":"    \"\"\"Get a list of recent failed runs for a given run metadata pair"},{"line_number":1528,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_42e7a83f","line":1525,"range":{"start_line":1525,"start_character":30,"end_line":1525,"end_character":42},"updated":"2016-04-15 02:27:57.000000000","message":"The similar method is get_recent_runs_by_key_value_metadata.\nHow about get_recent_failed_runs_by_key_value_metadata for consistency?\nOr is it too long?","commit_id":"a26a6f0cfb9da455bf692df3ec2be49a04748d1e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c39dd4713c514a409a34ca09b042eabd5cc6ba19","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"    return attachments"},{"line_number":1523,"context_line":""},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"def get_recent_failed_runs_by_run_metadata(key, value, num_runs\u003d10,"},{"line_number":1526,"context_line":"                                           start_date\u003dNone, session\u003dNone):"},{"line_number":1527,"context_line":"    \"\"\"Get a list of recent failed runs for a given run metadata pair"},{"line_number":1528,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_98c43a93","line":1525,"range":{"start_line":1525,"start_character":30,"end_line":1525,"end_character":42},"in_reply_to":"1a122d0e_3dd6b8c5","updated":"2016-04-15 19:44:50.000000000","message":"That is not so strong opinion.\nOpenStack is always inconsistent on APIs, and sometimes we try fixing them due to backwards incompatible concerns.\n\nI just wanted to confirm this name is intentional to avoid future concerns.","commit_id":"a26a6f0cfb9da455bf692df3ec2be49a04748d1e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5e996a1e4cc6c7e735cb2f65890ad0405f45f495","unresolved":false,"context_lines":[{"line_number":1522,"context_line":"    return attachments"},{"line_number":1523,"context_line":""},{"line_number":1524,"context_line":""},{"line_number":1525,"context_line":"def get_recent_failed_runs_by_run_metadata(key, value, num_runs\u003d10,"},{"line_number":1526,"context_line":"                                           start_date\u003dNone, session\u003dNone):"},{"line_number":1527,"context_line":"    \"\"\"Get a list of recent failed runs for a given run metadata pair"},{"line_number":1528,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_3dd6b8c5","line":1525,"range":{"start_line":1525,"start_character":30,"end_line":1525,"end_character":42},"in_reply_to":"5a18252c_42e7a83f","updated":"2016-04-15 19:26:50.000000000","message":"It is kinda lengthy at 45 characters. We also flip flop here (there is not any real consistency) there are some methods that use *by_run_metadata* and others that use *by_key_value* so I\u0027m not sure it matters too much, but if you really feel strongly about it I can rename it and the dependent patch: https://review.openstack.org/#/c/305496","commit_id":"a26a6f0cfb9da455bf692df3ec2be49a04748d1e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b2e79344d611ace41c1e589180f1ac655256ea24","unresolved":false,"context_lines":[{"line_number":1526,"context_line":"                                           start_date\u003dNone, session\u003dNone):"},{"line_number":1527,"context_line":"    \"\"\"Get a list of recent failed runs for a given run metadata pair"},{"line_number":1528,"context_line":""},{"line_number":1529,"context_line":"    :param str key: the run_metadata key to get failed runs"},{"line_number":1530,"context_line":"    :param str value: The run_metadata value to get failed runs"},{"line_number":1531,"context_line":"    :param int num_runs: The number of results to fetch, defaults to 10"},{"line_number":1532,"context_line":"    :param datetime start_date: the optional starting dates to get runs from."}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_f6de7edb","line":1529,"range":{"start_line":1529,"start_character":20,"end_line":1529,"end_character":21},"updated":"2016-04-15 02:27:57.000000000","message":"super nit: s/the/The/","commit_id":"a26a6f0cfb9da455bf692df3ec2be49a04748d1e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b2e79344d611ace41c1e589180f1ac655256ea24","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"    :param str key: the run_metadata key to get failed runs"},{"line_number":1530,"context_line":"    :param str value: The run_metadata value to get failed runs"},{"line_number":1531,"context_line":"    :param int num_runs: The number of results to fetch, defaults to 10"},{"line_number":1532,"context_line":"    :param datetime start_date: the optional starting dates to get runs from."},{"line_number":1533,"context_line":"                                Nothing older than this date will be returned"},{"line_number":1534,"context_line":"    :param session: optional session object if one isn\u0027t provided a new session"},{"line_number":1535,"context_line":"                    will be acquired for the duration of this operation"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_d6d9c2f4","line":1532,"range":{"start_line":1532,"start_character":32,"end_line":1532,"end_character":35},"updated":"2016-04-15 02:27:57.000000000","message":"ditto\n\nAnd why do we need to this start_date param?\nThe similar methos(like get_recent_successful_runs, get_recetn_failed_runs, get_recent_runs_by_key_value_metadata) don\u0027t have this param.\nThey just controls the result with num_runs.\n\nIs only num_runs enough for this case?","commit_id":"a26a6f0cfb9da455bf692df3ec2be49a04748d1e"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"5e996a1e4cc6c7e735cb2f65890ad0405f45f495","unresolved":false,"context_lines":[{"line_number":1529,"context_line":"    :param str key: the run_metadata key to get failed runs"},{"line_number":1530,"context_line":"    :param str value: The run_metadata value to get failed runs"},{"line_number":1531,"context_line":"    :param int num_runs: The number of results to fetch, defaults to 10"},{"line_number":1532,"context_line":"    :param datetime start_date: the optional starting dates to get runs from."},{"line_number":1533,"context_line":"                                Nothing older than this date will be returned"},{"line_number":1534,"context_line":"    :param session: optional session object if one isn\u0027t provided a new session"},{"line_number":1535,"context_line":"                    will be acquired for the duration of this operation"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_7dff9034","line":1532,"range":{"start_line":1532,"start_character":32,"end_line":1532,"end_character":35},"in_reply_to":"5a18252c_d6d9c2f4","updated":"2016-04-15 19:26:50.000000000","message":"It\u0027s not for the use case in the dependent patch: \n\nhttps://review.openstack.org/#/c/305496\n\nwe need to have a start date so we don\u0027t have to compare the whole list against the already queried results. It probably would be useful to add this param to other get_recent_*_runs methods. BUt that would be a follow up patch.","commit_id":"a26a6f0cfb9da455bf692df3ec2be49a04748d1e"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"b2e79344d611ace41c1e589180f1ac655256ea24","unresolved":false,"context_lines":[{"line_number":1531,"context_line":"    :param int num_runs: The number of results to fetch, defaults to 10"},{"line_number":1532,"context_line":"    :param datetime start_date: the optional starting dates to get runs from."},{"line_number":1533,"context_line":"                                Nothing older than this date will be returned"},{"line_number":1534,"context_line":"    :param session: optional session object if one isn\u0027t provided a new session"},{"line_number":1535,"context_line":"                    will be acquired for the duration of this operation"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":"    :return list: The list of recent failed Run objects"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_569bf217","line":1534,"range":{"start_line":1534,"start_character":20,"end_line":1534,"end_character":28},"updated":"2016-04-15 02:27:57.000000000","message":"ditto: s/optional/Optional/","commit_id":"a26a6f0cfb9da455bf692df3ec2be49a04748d1e"}]}