)]}'
{"subunit2sql/tests/db/test_api.py":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"ce6f5d12888e097a2ac36d7bd11b6a38b4833c45","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"        test_b \u003d api.create_test(\u0027fake_test1\u0027)"},{"line_number":1017,"context_line":"        test_c \u003d api.create_test(\u0027fake_test2\u0027)"},{"line_number":1018,"context_line":"        res \u003d api.get_ids_for_all_tests()"},{"line_number":1019,"context_line":"        self.assertEqual((test_a.id,), next(res))"},{"line_number":1020,"context_line":"        self.assertEqual((test_b.id,), next(res))"},{"line_number":1021,"context_line":"        self.assertEqual((test_c.id,), next(res))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_28e1bb2a","line":1021,"range":{"start_line":1019,"start_character":0,"end_line":1021,"end_character":49},"updated":"2016-05-17 05:47:56.000000000","message":"Can we keep this order (test_a -\u003e test_b -\u003e test_c), always?\n(I\u0027m doubting about it.)","commit_id":"b731858fe9bd4c24ae6663c2d440b537e4571fb5"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"cd98baeec53e65cc9572696f70cde1ad1867fc84","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"        test_c \u003d api.create_test(\u0027fake_test2\u0027)"},{"line_number":1018,"context_line":"        res \u003d api.get_ids_for_all_tests()"},{"line_number":1019,"context_line":"        for test_id in res:"},{"line_number":1020,"context_line":"            self.assertIn(test_id[0], [test_a.id, test_b.id, test_c.id])"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4ec36738","line":1020,"range":{"start_line":1020,"start_character":12,"end_line":1020,"end_character":72},"updated":"2016-05-17 08:30:10.000000000","message":"hmm, We should check whether we could get \u0027all tests\u0027 for this api here. So I think this is not enough. For example, we get 3 \"test_a\"s, it will pass this test.","commit_id":"7a06219ff1d095eb5879776a824deaebac44e89c"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"7df1c7ee53bb1c041cf2a6a9d09a760279206b78","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"        test_c \u003d api.create_test(\u0027fake_test2\u0027)"},{"line_number":1018,"context_line":"        res \u003d api.get_ids_for_all_tests()"},{"line_number":1019,"context_line":"        for test_id in res:"},{"line_number":1020,"context_line":"            self.assertIn(test_id[0], [test_a.id, test_b.id, test_c.id])"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_a94d913f","line":1020,"range":{"start_line":1020,"start_character":12,"end_line":1020,"end_character":72},"in_reply_to":"dab17558_4ec36738","updated":"2016-05-17 14:40:24.000000000","message":"The for loop will get \"all tests\" from the result, and check each test(test_a, test_b, test_c) id in the expect list.","commit_id":"7a06219ff1d095eb5879776a824deaebac44e89c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"6b7959a8a86588d7e48b3ac5965dfc8bff700769","unresolved":false,"context_lines":[{"line_number":1017,"context_line":"        test_c \u003d api.create_test(\u0027fake_test2\u0027)"},{"line_number":1018,"context_line":"        res \u003d api.get_ids_for_all_tests()"},{"line_number":1019,"context_line":"        for test_id in res:"},{"line_number":1020,"context_line":"            self.assertIn(test_id[0], [test_a.id, test_b.id, test_c.id])"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_b3ede290","line":1020,"range":{"start_line":1020,"start_character":12,"end_line":1020,"end_character":72},"in_reply_to":"dab17558_a94d913f","updated":"2016-05-18 02:56:46.000000000","message":"No, I mean we need to test this get_ids_for_all_tests() api whether really return an all list. So if get_ids_for_all_tests() returns [test_a, test_a, test_a], this test will succeed. Do I miss something?","commit_id":"7a06219ff1d095eb5879776a824deaebac44e89c"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"0e03cc8b8c52467be515f1e3fce8e48d9e3bfc72","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"        test_a \u003d api.create_test(\u0027fake_test\u0027)"},{"line_number":1016,"context_line":"        test_b \u003d api.create_test(\u0027fake_test1\u0027)"},{"line_number":1017,"context_line":"        test_c \u003d api.create_test(\u0027fake_test2\u0027)"},{"line_number":1018,"context_line":"        res \u003d api.get_ids_for_all_tests()"},{"line_number":1019,"context_line":"        self.assertIn((test_a.id,), res)"},{"line_number":1020,"context_line":"        self.assertIn((test_b.id,), res)"},{"line_number":1021,"context_line":"        self.assertIn((test_c.id,), res)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_25ab3376","line":1018,"updated":"2016-05-18 19:49:15.000000000","message":"So I\u0027m not a fan of this unit test, it depends on the iterator ordering being consistent. (which should be fixed given these tests are backed by a real RDBMS) The only reason these work is because you\u0027re matching the order of the iterator returns. If for example you did test_c first it would traverse to the end and the subsequent assertIn\u0027s would fail. I don\u0027t like tying the test to a specific ordering (granted this dislike comes from random seeds in python which using a rdbms for ordering shouldn\u0027t be affected by) I we just wrap res in a list:\n\n  res \u003d list(api.get_ids_for_all_tests())\n\nor even better do something like:\n\n  import types\n\n  res \u003d api.get_ids_for_all_tests()\n  self.assertIsInstance(res, types.GeneratorType)\n  res \u003d list(res)","commit_id":"b857ba3bc03966a6c23a01bc316a7d4215e6f469"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"96de83d2af811dd184ec7ba81d34dbb662405feb","unresolved":false,"context_lines":[{"line_number":1015,"context_line":"        test_a \u003d api.create_test(\u0027fake_test\u0027)"},{"line_number":1016,"context_line":"        test_b \u003d api.create_test(\u0027fake_test1\u0027)"},{"line_number":1017,"context_line":"        test_c \u003d api.create_test(\u0027fake_test2\u0027)"},{"line_number":1018,"context_line":"        res \u003d api.get_ids_for_all_tests()"},{"line_number":1019,"context_line":"        self.assertIn((test_a.id,), res)"},{"line_number":1020,"context_line":"        self.assertIn((test_b.id,), res)"},{"line_number":1021,"context_line":"        self.assertIn((test_c.id,), res)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_313c0ae2","line":1018,"in_reply_to":"bab6814e_25ab3376","updated":"2016-05-19 02:40:49.000000000","message":"Done, thanks for the comments","commit_id":"b857ba3bc03966a6c23a01bc316a7d4215e6f469"}]}