)]}'
{"doc/source/reference/data_model.rst":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"046b164399647209464f38db2d5bb62a93c65d6b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"* **artifacts**: An optional link to where the logs or any other artifacts from"},{"line_number":31,"context_line":"  the run are stored."},{"line_number":32,"context_line":"* **run_at**: The time at which the run was stored in the DB."},{"line_number":33,"context_line":"* **non_subunit_name**: If set to non-None, non subunit content encountered in the stream will be converted into file packets labelled with this name."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Tests"},{"line_number":36,"context_line":"-----"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f515b1d_4c20c5f7","line":33,"updated":"2017-09-29 17:03:48.000000000","message":"I don\u0027t think this is part of the data model is it? You\u0027re not adding a column to the runs table. I think this probably belongs in the docs for the subunit2sql command","commit_id":"2fdf764fbaea27c36a417c3215e69d02ce0b8c87"}],"doc/source/user/usage.rst":[{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"c16e9fd52beb7d51d2ab0a84dc8336bd1c442699","unresolved":false,"context_lines":[{"line_number":50,"context_line":"to the database as key value pairs associated with the run being added."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"If you want to use a subunit stream with non-subunit data mixed in you can do"},{"line_number":53,"context_line":"this with the optional argument --non-subunit-name. This will treat all the"},{"line_number":54,"context_line":"non-subunit data as a file attachment with the specified name."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":".. _sql2subunit:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3f4b6375_4890b44a","line":53,"updated":"2017-10-26 03:20:45.000000000","message":"heh, here as well..","commit_id":"6f4fb59a60a7ad0c2d5f3f00a97b595068458f87"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"1581682f95ee9fb537fbb1092b48bec401896392","unresolved":false,"context_lines":[{"line_number":50,"context_line":"to the database as key value pairs associated with the run being added."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"If you want to use a subunit stream with non-subunit data mixed in you can do"},{"line_number":53,"context_line":"this with the optional argument --non-subunit-name. This will treat all the"},{"line_number":54,"context_line":"non-subunit data as a file attachment with the specified name."},{"line_number":55,"context_line":""},{"line_number":56,"context_line":".. _sql2subunit:"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bf8cb3f7_85a2e499","line":53,"in_reply_to":"3f4b6375_4890b44a","updated":"2017-12-21 17:19:00.000000000","message":"Missed this comment.. Done. :)","commit_id":"6f4fb59a60a7ad0c2d5f3f00a97b595068458f87"}],"subunit2sql/shell.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"46a82220d6c9b0e255c331b9178efef621870c4a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"             default_config_files\u003ddefault_config_files)"},{"line_number":89,"context_line":"    check_version()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"def check_version():"},{"line_number":92,"context_line":"    v \u003d version.VersionInfo(\u0027subunit2sql\u0027).semantic_version().version_tuple()"},{"line_number":93,"context_line":"    if CONF.non_subunit_name and  v \u003c\u003d (1, 8, 0):"},{"line_number":94,"context_line":"        raise exceptions.IncompatibleArgument("}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_00e04ccc","line":91,"updated":"2017-09-29 20:53:36.000000000","message":"I don\u0027t understand what this function is for. If the version is \u003c 1.8.0 the option won\u0027t exist it was not defined in the past....","commit_id":"4d6bf891c422660d0c6f90d9e57be3d330474d2c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"a60dab48a7ed2e734132334405aaf669b1ac28eb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                help\u003d\"When True the wall time of a run will be used for the \""},{"line_number":61,"context_line":"                     \"run_time column in the runs table. By default the sum of\""},{"line_number":62,"context_line":"                     \" the test executions are used instead.\"),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027non-subunit-name\u0027, default\u003dNone,"},{"line_number":64,"context_line":"               dest\u003d\u0027non_subunit_name\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027Allows non-subunit content and stores it under this\u0027"},{"line_number":66,"context_line":"               \u0027 name\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_a9bf4ea8","line":63,"updated":"2017-10-25 05:02:42.000000000","message":"I think it\u0027s better making this option to \u0027non_subunit_name\u0027(changing \u0027-\u0027 to \u0027_\u0027), or allowing both. I actually like connecting words with \u0027-\u0027 not \u0027_\u0027 in options. But I think we should keep the consistency to avoid user\u0027s confusions.","commit_id":"ad8e6ce26afe84de710c5c78e9401c57e7855a46"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"b6d3d2a569cb493473aa235a1d6f13584a698d2f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                help\u003d\"When True the wall time of a run will be used for the \""},{"line_number":61,"context_line":"                     \"run_time column in the runs table. By default the sum of\""},{"line_number":62,"context_line":"                     \" the test executions are used instead.\"),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027non-subunit-name\u0027, default\u003dNone,"},{"line_number":64,"context_line":"               dest\u003d\u0027non_subunit_name\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027Allows non-subunit content and stores it under this\u0027"},{"line_number":66,"context_line":"               \u0027 name\u0027),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f4b6375_bb29c28a","line":63,"in_reply_to":"3f4b6375_a9bf4ea8","updated":"2017-10-25 14:40:51.000000000","message":"Done","commit_id":"ad8e6ce26afe84de710c5c78e9401c57e7855a46"}],"subunit2sql/tests/test_read_subunit.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"046b164399647209464f38db2d5bb62a93c65d6b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        self.assertEqual(ntargets1, ntargets2)"},{"line_number":217,"context_line":"        self.assertEqual(targets, [\u0027foo\u0027])"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test_non_subunit_name(self):"},{"line_number":220,"context_line":"        non_subunit_name \u003d \u0027fake_non_subunit\u0027"},{"line_number":221,"context_line":"        fake_subunit \u003d subunit.ReadSubunit(mock.MagicMock(),"},{"line_number":222,"context_line":"                                           non_subunit_name\u003dnon_subunit_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_4cfc453d","line":219,"updated":"2017-09-29 17:03:48.000000000","message":"Can we add a unit test on raising the exception if non_subunit_name is set to ensure we\u0027re maintaining backwards compatibility.","commit_id":"2fdf764fbaea27c36a417c3215e69d02ce0b8c87"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"f4608accd29e6dc42b5e028bd2cff5d2575090cf","unresolved":false,"context_lines":[{"line_number":216,"context_line":"        self.assertEqual(ntargets1, ntargets2)"},{"line_number":217,"context_line":"        self.assertEqual(targets, [\u0027foo\u0027])"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test_non_subunit_name(self):"},{"line_number":220,"context_line":"        non_subunit_name \u003d \u0027fake_non_subunit\u0027"},{"line_number":221,"context_line":"        fake_subunit \u003d subunit.ReadSubunit(mock.MagicMock(),"},{"line_number":222,"context_line":"                                           non_subunit_name\u003dnon_subunit_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_20ea28d7","line":219,"in_reply_to":"7f515b1d_4cfc453d","updated":"2017-09-29 20:39:21.000000000","message":"I hope I addressed this with the use of the pbr.version.VersionInfo :/\n\nI noticed the use_wall_time[1] and maybe some other CLI commands were added without this test too, should we add more version checks? \n\nhttps://github.com/openstack-infra/subunit2sql/commit/08da4131ed6131e414cd7f49516c840354b3f3cc","commit_id":"2fdf764fbaea27c36a417c3215e69d02ce0b8c87"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"46a82220d6c9b0e255c331b9178efef621870c4a","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        fake_subunit \u003d subunit.ReadSubunit(mock.MagicMock(),"},{"line_number":222,"context_line":"                                           non_subunit_name\u003dnon_subunit_name)"},{"line_number":223,"context_line":"        self.assertEqual(fake_subunit.stream.non_subunit_name,"},{"line_number":224,"context_line":"                         non_subunit_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_60c94057","line":224,"updated":"2017-09-29 20:53:36.000000000","message":"All I was asking for on rev1 was for a test exactly like this but instead of setting non_subunit_name to a string set it to None and pass in binary data to ReadSubunit(). That way we can do assertRaises.","commit_id":"4d6bf891c422660d0c6f90d9e57be3d330474d2c"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"58c4b90b94a54c38588e393b31ad5f377823337d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        fake_subunit \u003d subunit.ReadSubunit(mock.MagicMock(),"},{"line_number":222,"context_line":"                                           non_subunit_name\u003dnon_subunit_name)"},{"line_number":223,"context_line":"        self.assertEqual(fake_subunit.stream.non_subunit_name,"},{"line_number":224,"context_line":"                         non_subunit_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_0065ec45","line":224,"in_reply_to":"7f515b1d_60c94057","updated":"2017-09-29 21:06:08.000000000","message":"I was trying to write a test like that before, but I found it difficult to produce a subunit stream with non-binary content.","commit_id":"4d6bf891c422660d0c6f90d9e57be3d330474d2c"}],"subunit2sql/tests/test_shell.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"46a82220d6c9b0e255c331b9178efef621870c4a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                          shell.increment_counts, fake_test, fake_result)"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    @mock.patch(\u0027pbr.version.VersionInfo.semantic_version\u0027)"},{"line_number":142,"context_line":"    def test_check_version_non_subunit_name(self, version, version_mock):"},{"line_number":143,"context_line":"        cfg.CONF.set_override(name\u003d\u0027non_subunit_name\u0027, override\u003d\u0027fake\u0027)"},{"line_number":144,"context_line":"        version_mock.return_value.version_tuple.return_value \u003d (1, 8, 1)"},{"line_number":145,"context_line":"        shell.check_version()"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f515b1d_e0bd30b7","line":142,"updated":"2017-09-29 20:53:36.000000000","message":"I think you might have been reading a bit too much into my review on comment on rev 1. We don\u0027t really need to test the version like this I\u0027m actually not sure what value we\u0027re getting from this test.","commit_id":"4d6bf891c422660d0c6f90d9e57be3d330474d2c"}]}