)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"2f2f39a6e21242730210fedc77f9f6f1b1019b60","unresolved":false,"context_lines":[{"line_number":14,"context_line":"object so that the value can be inserted into the database without"},{"line_number":15,"context_line":"a TypeError."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Since the attachment column is a LargeBinary, all content"},{"line_number":18,"context_line":"should be encoded before inserting to the database."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ice6cfff36b95698df00033861f9d9602170093f4"},{"line_number":21,"context_line":"Story: 2002657"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9fdfeff1_11837655","line":18,"range":{"start_line":17,"start_character":46,"end_line":18,"end_character":17},"updated":"2019-01-22 17:31:10.000000000","message":"This was the wall I was hitting. This link helped me understand what was going on with SQLAlchemy more https://stackoverflow.com/questions/39112238/sqlalchemy-insert-string-argument-without-an-encoding\n\n\"BLOBs require binary data, so we need bytes in Python 3 and str in Python 2, since Python 2 strings are sequences of bytes.\"","commit_id":"934ff9300fac84be249231f9d6380aed6364a8be"}],"subunit2sql/read_subunit.py":[{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"6752c274724807464812ce6037f94f947b69adcc","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        attach_dict \u003d {}"},{"line_number":74,"context_line":"        for name, detail in test[\u0027details\u0027].items():"},{"line_number":75,"context_line":"            name \u003d name.split(\u0027:\u0027)[0]"},{"line_number":76,"context_line":"            attach_dict[name] \u003d \u0027\u0027.join(detail.iter_bytes())"},{"line_number":77,"context_line":"        return attach_dict"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def parse_outcome(self, test):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_65ac5234","line":76,"updated":"2019-01-10 16:45:14.000000000","message":"This doesn\u0027t seem right to me. If the iter_bytes() iterator returns bytes objects (ie binary) how does this work because \u0027\u0027.join() will only work if strings are used.","commit_id":"cb2434e0cb5dbdc94f6aa2c851ffb1ba171a34d3"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"3d87d343dd9a17c89fbffa9c65022637dd46a563","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        attach_dict \u003d {}"},{"line_number":74,"context_line":"        for name, detail in test[\u0027details\u0027].items():"},{"line_number":75,"context_line":"            name \u003d name.split(\u0027:\u0027)[0]"},{"line_number":76,"context_line":"            attach_dict[name] \u003d \u0027\u0027.join(detail.iter_bytes())"},{"line_number":77,"context_line":"        return attach_dict"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def parse_outcome(self, test):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfd5e7cf_08d0fb4f","line":76,"in_reply_to":"dfd5e7cf_65ac5234","updated":"2019-01-10 17:02:16.000000000","message":"I don\u0027t have a use case available to me for using bytes but let me try to create a scenario where I call addDetails[1] with binary content and I can expand the current unit test with some binary content.\n\n[1] https://testtools.readthedocs.io/en/latest/api.html#testtools.TestCase.addDetail","commit_id":"cb2434e0cb5dbdc94f6aa2c851ffb1ba171a34d3"}]}