)]}'
{"modules/iptables/manifests/params.pp":[{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"e9dd488d55f560906155aeb394e18a18c4499a7c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"class iptables::params {"},{"line_number":6,"context_line":"  case $::osfamily {"},{"line_number":7,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":8,"context_line":"      if $::operatingsystem \u003d\u003d RedHat and $::operatingsystemrelease \u003e\u003d 7 or"},{"line_number":9,"context_line":"        $::operatingsystem \u003d\u003d Fedora and $::operatingsystemrelease \u003e\u003d 15 {"},{"line_number":10,"context_line":"        $package_name \u003d \u0027iptables-services\u0027"},{"line_number":11,"context_line":"        $service_has_restart \u003d true"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"baada198_fbafb2dd","line":8,"updated":"2014-07-28 22:43:50.000000000","message":"I greatly prefer cascading case statements for this kind of logic. Particularly in params.pp","commit_id":"b2e51bddb60b06c51482920842cb240e35328b84"}],"modules/openstack_project/files/nodepool/scripts/multinode_setup.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"10a0b45b7351377cf45ab40a47973db68556905b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"# limitations under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"for ip in `cat /etc/nodepool/primary_node /etc/nodepool/sub_nodes`; do"},{"line_number":20,"context_line":"    sudo /usr/sbin/iptables -I openstack-INPUT 1 -s $ip -j ACCEPT"},{"line_number":21,"context_line":"done"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"echo \"\" \u003e\u003e /home/jenkins/.ssh/authorized_keys"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baada198_a7db6d4d","line":20,"updated":"2014-07-15 08:46:54.000000000","message":"/usr/sbin/iptables isn\u0027t a thing on ubuntu trusty. Looks like it is /sbin/iptables.","commit_id":"b80048316f8df90968b6f5be372eb7a68513d64a"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"7c2aeb767037e0caa59f71887940a0dd773a2c13","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash -l"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (C) 2014 OpenStack Foundation"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":2,"id":"baada198_efa7b7a5","line":1,"updated":"2014-07-23 00:53:18.000000000","message":"I don\u0027t think this is consistent with the way it has been done before; which is to add it to PATH; e.g. https://review.openstack.org/#/c/91655/\n\nI think it\u0027s better to follow this rather than use a login shell that might have other side effects","commit_id":"ff6579b3d1e44c89ec1805891d7a6d8ade53758f"}]}