)]}'
{"manifests/site.pp":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e35be5fc4f55aeea7e36e6a346157ed5f1c5850c","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    site_mysql_password          \u003d\u003e hiera(\u0027groups_dev_site_mysql_password\u0027, \u0027XXX\u0027),"},{"line_number":224,"context_line":"    conf_cron_key                \u003d\u003e hiera(\u0027groups_dev_conf_cron_key\u0027, \u0027XXX\u0027),"},{"line_number":225,"context_line":"    site_ssl_cert_file_contents  \u003d\u003e hiera(\u0027groups_dev_site_ssl_cert_file_contents\u0027, undef),"},{"line_number":226,"context_line":"    site_ssl_key_file_contents   \u003d\u003e hiera(\u0027groups_dev_site_ssl_key_file_contents\u0027, undef),"},{"line_number":227,"context_line":"    site_ssl_chain_file_contents \u003d\u003e hiera(\u0027groups_dev_$site_ssl_chain_file_contents\u0027, undef),"},{"line_number":228,"context_line":"  }"},{"line_number":229,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_ecbf10ce","line":226,"updated":"2014-11-25 16:33:40.000000000","message":"I\u0027ve added these two in hiera now, as well as similarly-named purchased cert and related blobs for groups.openstack.org too.","commit_id":"9cf4f9a798cb150fb996f2fbf0cdb8feea2fb8ea"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"86e4cd5e44c3c1fb6b8fd38020254e7b62e0c4bf","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    conf_cron_key                \u003d\u003e hiera(\u0027groups_dev_conf_cron_key\u0027, \u0027XXX\u0027),"},{"line_number":225,"context_line":"    site_ssl_cert_file_contents  \u003d\u003e hiera(\u0027groups_dev_site_ssl_cert_file_contents\u0027, undef),"},{"line_number":226,"context_line":"    site_ssl_key_file_contents   \u003d\u003e hiera(\u0027groups_dev_site_ssl_key_file_contents\u0027, undef),"},{"line_number":227,"context_line":"    site_ssl_chain_file_contents \u003d\u003e hiera(\u0027groups_dev_$site_ssl_chain_file_contents\u0027, undef),"},{"line_number":228,"context_line":"  }"},{"line_number":229,"context_line":"}"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_ceeadaab","line":227,"updated":"2014-11-20 11:21:12.000000000","message":"I really like the site_ prefixing here.","commit_id":"9cf4f9a798cb150fb996f2fbf0cdb8feea2fb8ea"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e35be5fc4f55aeea7e36e6a346157ed5f1c5850c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    conf_cron_key                \u003d\u003e hiera(\u0027groups_dev_conf_cron_key\u0027, \u0027XXX\u0027),"},{"line_number":225,"context_line":"    site_ssl_cert_file_contents  \u003d\u003e hiera(\u0027groups_dev_site_ssl_cert_file_contents\u0027, undef),"},{"line_number":226,"context_line":"    site_ssl_key_file_contents   \u003d\u003e hiera(\u0027groups_dev_site_ssl_key_file_contents\u0027, undef),"},{"line_number":227,"context_line":"    site_ssl_chain_file_contents \u003d\u003e hiera(\u0027groups_dev_$site_ssl_chain_file_contents\u0027, undef),"},{"line_number":228,"context_line":"  }"},{"line_number":229,"context_line":"}"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_0cb37c0a","line":227,"updated":"2014-11-25 16:33:40.000000000","message":"This line is unnecessary since a self-signed cert won\u0027t have a chain file. Also it has a typo anyway (\"$site\" should be just \"site\").","commit_id":"9cf4f9a798cb150fb996f2fbf0cdb8feea2fb8ea"}],"modules/drupal/manifests/init.pp":[{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"86e4cd5e44c3c1fb6b8fd38020254e7b62e0c4bf","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  # ssl certificates"},{"line_number":90,"context_line":"  if $site_ssl_enabled \u003d\u003d true {"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    include apache::ssl"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # site x509 certificate"},{"line_number":95,"context_line":"    if $site_ssl_cert_file_contents !\u003d \u0027\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_aee74ee3","line":92,"updated":"2014-11-20 11:21:12.000000000","message":"It might be better to validate_string() on the three variables here, so you get a hard/early failure if the ssl certs are not provided.","commit_id":"9cf4f9a798cb150fb996f2fbf0cdb8feea2fb8ea"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e35be5fc4f55aeea7e36e6a346157ed5f1c5850c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  # ssl certificates"},{"line_number":90,"context_line":"  if $site_ssl_enabled \u003d\u003d true {"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    include apache::ssl"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # site x509 certificate"},{"line_number":95,"context_line":"    if $site_ssl_cert_file_contents !\u003d \u0027\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_4c8bc4c2","line":92,"in_reply_to":"5a890539_6ec72613","updated":"2014-11-25 16:33:40.000000000","message":"Technically it\u0027s if we\u0027re using self-signed certs that there won\u0027t be a chain provided (it\u0027s just a key and a corresponding cert which has been signed by that key rather than by a public CA).","commit_id":"9cf4f9a798cb150fb996f2fbf0cdb8feea2fb8ea"},{"author":{"_account_id":6633,"name":"Marton Kiss","email":"marton.kiss@canonical.com","username":"marton-kiss"},"change_message_id":"03601659175b085d3a4c225b569b6056dd6586d9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"  # ssl certificates"},{"line_number":90,"context_line":"  if $site_ssl_enabled \u003d\u003d true {"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    include apache::ssl"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    # site x509 certificate"},{"line_number":95,"context_line":"    if $site_ssl_cert_file_contents !\u003d \u0027\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_6ec72613","line":92,"in_reply_to":"5a890539_aee74ee3","updated":"2014-11-20 11:26:32.000000000","message":"Spencer, in our use-case we will use SSL always, the current one is just a temporary situation until we migrate both sites. If we are using public CA provided certs, it can skip the additional ssl_chain, so we need to check just the existence of site cert and the key.","commit_id":"9cf4f9a798cb150fb996f2fbf0cdb8feea2fb8ea"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2609b0f381b3254c5b7aa01c51a8bb47c21a4124","unresolved":false,"context_lines":[{"line_number":113,"context_line":"      }"},{"line_number":114,"context_line":"    }"},{"line_number":115,"context_line":"  }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"  # setup apache and virtualhosts, enable mod rewrite"},{"line_number":118,"context_line":"  file { $site_vhost_root:"},{"line_number":119,"context_line":"    ensure \u003d\u003e directory,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a890539_426f0d2b","line":116,"updated":"2014-11-25 17:11:49.000000000","message":"You should still have a resource for the chain file too, since it\u0027s referenced in the vhost template and production groups.openstack.org will need it.","commit_id":"7c22aac7f62e8fb6be6ebf053a5b15b6e77bfd28"}],"modules/drupal/templates/drupal.vhost.erb":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2609b0f381b3254c5b7aa01c51a8bb47c21a4124","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  SSLCertificateFile      \u003c%\u003d @site_ssl_cert_file %\u003e"},{"line_number":18,"context_line":"  SSLCertificateKeyFile   \u003c%\u003d @site_ssl_key_file %\u003e"},{"line_number":19,"context_line":"\u003c% if @site_ssl_chain_file_contents !\u003d \u0027\u0027 %\u003e"},{"line_number":20,"context_line":"  SSLCertificateChainFile /etc/ssl/certs/\u003c%\u003d @site_name %\u003e_CA.pem"},{"line_number":21,"context_line":"\u003c% end %\u003e"},{"line_number":22,"context_line":"\u003c% end %\u003e"},{"line_number":23,"context_line":"  ServerName \u003c%\u003d @srvname %\u003e"}],"source_content_type":"application/x-erb","patch_set":3,"id":"5a890539_e2a639c0","line":20,"updated":"2014-11-25 17:11:49.000000000","message":"This should be handled similarly to the other two files.","commit_id":"7c22aac7f62e8fb6be6ebf053a5b15b6e77bfd28"}],"modules/openstack_project/manifests/groups_dev.pp":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e35be5fc4f55aeea7e36e6a346157ed5f1c5850c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  $conf_cron_key \u003d \u0027\u0027,"},{"line_number":22,"context_line":"  $sysadmins \u003d [],"},{"line_number":23,"context_line":"  $site_ssl_cert_file_contents \u003d undef,"},{"line_number":24,"context_line":"  $site_ssl_key_file_contents \u003d undef,"},{"line_number":25,"context_line":"  $site_ssl_chain_file_contents \u003d undef,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a890539_8c04cc18","line":24,"updated":"2014-11-25 16:33:40.000000000","message":"It would probably be nice to default these to /etc/ssl/certs/ssl-cert-snakeoil.pem and /etc/ssl/private/ssl-cert-snakeoil.key like we do in review_dev.pp. This makes it use the self-signed cert present on the server by default, if one is not provided via hiera.","commit_id":"9cf4f9a798cb150fb996f2fbf0cdb8feea2fb8ea"}]}
