)]}'
{"modules/openstack_project/manifests/gerrit.pp":[{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"c3192a05c1d095bdb0592cf09886d071e2cdafa7","unresolved":false,"context_lines":[{"line_number":289,"context_line":"    ensure \u003d\u003e present,"},{"line_number":290,"context_line":"  }"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"  vcsrepo { \u0027/opt/jquery-visibility\u0027:"},{"line_number":293,"context_line":"    ensure   \u003d\u003e latest,"},{"line_number":294,"context_line":"    provider \u003d\u003e git,"},{"line_number":295,"context_line":"    revision \u003d\u003e \u0027master\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3acd31a7_ef786c2d","line":292,"updated":"2015-05-04 16:59:22.000000000","message":"why create a new dir for jquery files?  why not put it in existing /usr/share/javascript/jquery location?","commit_id":"8bbb786ee7b80c0a10efe544e307037c76a19a3a"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"c3192a05c1d095bdb0592cf09886d071e2cdafa7","unresolved":false,"context_lines":[{"line_number":297,"context_line":"  }"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"  exec { \u0027install-jquery-visibility\u0027:"},{"line_number":300,"context_line":"    command     \u003d\u003e \u0027yui-compressor -o /home/gerrit2/review_site/static/jquery-visibility.min.js /opt/jquery-visibility/jquery-visibility.js\u0027,"},{"line_number":301,"context_line":"    path        \u003d\u003e \u0027bin:/usr/bin\u0027,"},{"line_number":302,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":303,"context_line":"    subscribe   \u003d\u003e Vcsrepo[\u0027/opt/jquery-visibility\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3acd31a7_ef698c26","line":300,"updated":"2015-05-04 16:59:22.000000000","message":"Not sure if we want to re-evaluate minifying jquery-visibility.  The minified version of jquery.js is not provided in the trusty package and we made a conscious decision to _not_ minify it when we fixed it in change  I18056ca5288.  I believe the reason was because experts, like krotscheck, said that there is no benefit to minifying.","commit_id":"8bbb786ee7b80c0a10efe544e307037c76a19a3a"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"802e54196ddf849849bbba24303a678e5839b9d4","unresolved":false,"context_lines":[{"line_number":297,"context_line":"  }"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"  exec { \u0027install-jquery-visibility\u0027:"},{"line_number":300,"context_line":"    command     \u003d\u003e \u0027yui-compressor -o /home/gerrit2/review_site/static/jquery-visibility.min.js /opt/jquery-visibility/jquery-visibility.js\u0027,"},{"line_number":301,"context_line":"    path        \u003d\u003e \u0027bin:/usr/bin\u0027,"},{"line_number":302,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":303,"context_line":"    subscribe   \u003d\u003e Vcsrepo[\u0027/opt/jquery-visibility\u0027],"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3acd31a7_84fe76ac","line":300,"in_reply_to":"3acd31a7_ef698c26","updated":"2015-05-04 20:02:18.000000000","message":"Yes, we should not minify here since we have decided that is not the convention. If we want to resurrect that discussion I think thats fine but IMO that should happen seperately.","commit_id":"8bbb786ee7b80c0a10efe544e307037c76a19a3a"},{"author":{"_account_id":6987,"name":"Khai Do","email":"zaro0508@gmail.com","username":"zaro0508"},"change_message_id":"c3192a05c1d095bdb0592cf09886d071e2cdafa7","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":303,"context_line":"    subscribe   \u003d\u003e Vcsrepo[\u0027/opt/jquery-visibility\u0027],"},{"line_number":304,"context_line":"    require     \u003d\u003e [Package[\u0027yui-compressor\u0027],"},{"line_number":305,"context_line":"                    Vcsrepo[\u0027/opt/jquery-visibility\u0027]],"},{"line_number":306,"context_line":"  }"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"  file { \u0027/home/gerrit2/review_site/static/hideci.js\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3acd31a7_2fe1c4fe","line":305,"updated":"2015-05-04 16:59:22.000000000","message":"Probably need to require on File[\u0027/home/gerrit2/review_site/static\u0027] ?","commit_id":"8bbb786ee7b80c0a10efe544e307037c76a19a3a"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"373ade121afea0caa7bdcfec9494eab13581dd6a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    source \u003d\u003e \u0027/opt/jquery-visibility/jquery-visibility.js\u0027,"},{"line_number":298,"context_line":"    subscribe \u003d\u003e Vcsrepo[\u0027/opt/jquery-visibility\u0027],"},{"line_number":299,"context_line":"    require \u003d\u003e [ File[\u0027/home/gerrit2/review_site/static\u0027],"},{"line_number":300,"context_line":"                 Class[\u0027::gerrit\u0027] ]"},{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  file { \u0027/home/gerrit2/review_site/static/hideci.js\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3acd31a7_0bf93fc7","line":300,"updated":"2015-05-05 12:28:51.000000000","message":"This needs a \n\n  notify \u003d\u003e Exec[\u0027reload_gerrit_header\u0027],\n\nOtherwise gerrit can\u0027t serve it up.","commit_id":"31919b6db583f3ac26a38d734d40ceb14d2c89fb"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"8a54b8bf4b432022ddbce855448fb398c42f86cb","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    source \u003d\u003e \u0027/opt/jquery-visibility/jquery-visibility.js\u0027,"},{"line_number":298,"context_line":"    subscribe \u003d\u003e Vcsrepo[\u0027/opt/jquery-visibility\u0027],"},{"line_number":299,"context_line":"    require \u003d\u003e [ File[\u0027/home/gerrit2/review_site/static\u0027],"},{"line_number":300,"context_line":"                 Class[\u0027::gerrit\u0027] ]"},{"line_number":301,"context_line":"  }"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"  file { \u0027/home/gerrit2/review_site/static/hideci.js\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3acd31a7_cbd6a7f0","line":300,"in_reply_to":"3acd31a7_0bf93fc7","updated":"2015-05-05 12:34:28.000000000","message":"Done","commit_id":"31919b6db583f3ac26a38d734d40ceb14d2c89fb"}]}
