)]}'
{"modules/jenkins/files/cgroups/upstart_cgconfig":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"32e960950b4e04f78209e9458ac2e057809c3d2a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"\texport TMPDIR\u003d/run"},{"line_number":6,"context_line":"\tTEMPCONF\u003d`tempfile`"},{"line_number":7,"context_line":"\t# the cgroup-lite job takes care of the default mount now"},{"line_number":8,"context_line":"\tsed \u0027/^mount {/,/}/d\u0027 /etc/cgconfig.conf \u003e \"$TEMPCONF\""},{"line_number":9,"context_line":"\t/usr/sbin/cgconfigparser -l \"$TEMPCONF\""},{"line_number":10,"context_line":"\trm \"$TEMPCONF\""},{"line_number":11,"context_line":"end script"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAM3%2F%2FVDU%3D","line":8,"updated":"2013-01-28 20:06:18.000000000","message":"I would prefer that the template for cgconfig.conf simply not include the mounts on quantal and above.","commit_id":"d76bcc321b9c4b5c8099785f6f1494ad57d3355a"}],"modules/jenkins/manifests/cgroups.pp":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"32e960950b4e04f78209e9458ac2e057809c3d2a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  service { \u0027cgconfig\u0027:"},{"line_number":54,"context_line":"    ensure    \u003d\u003e running,"},{"line_number":55,"context_line":"    enable    \u003d\u003e true,"},{"line_number":56,"context_line":"    require   \u003d\u003e Package[\u0027cgroups\u0027],"},{"line_number":57,"context_line":"    subscribe \u003d\u003e File[\u0027/etc/cgconfig.conf\u0027],"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"AAAAM3%2F%2FVDE%3D","line":56,"updated":"2013-01-28 20:06:18.000000000","message":"You will also want to require the appropriate upstart config as defined above. I think that requires that are not defined are ignored in puppet. So you may not need a conditional.","commit_id":"d76bcc321b9c4b5c8099785f6f1494ad57d3355a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"32e960950b4e04f78209e9458ac2e057809c3d2a","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  service { \u0027cgred\u0027:"},{"line_number":61,"context_line":"    ensure    \u003d\u003e running,"},{"line_number":62,"context_line":"    enable    \u003d\u003e true,"},{"line_number":63,"context_line":"    require   \u003d\u003e Package[\u0027cgroups\u0027],"},{"line_number":64,"context_line":"    subscribe \u003d\u003e File[\u0027/etc/cgrules.conf\u0027],"},{"line_number":65,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"AAAAM3%2F%2FVC8%3D","line":62,"updated":"2013-01-28 20:06:18.000000000","message":"Same comment as above.","commit_id":"d76bcc321b9c4b5c8099785f6f1494ad57d3355a"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ff440768e627392b34bb29e5f7813372fdb984de","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      target \u003d\u003e \u0027/lib/init/upstart-job\u0027,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  } else {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    file { \u0027/etc/init/cgconfig.conf\u0027:"},{"line_number":64,"context_line":"      ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"AAAAM3%2F%2FUZs%3D","line":61,"updated":"2013-01-29 04:52:50.000000000","message":"I think this should be an else if so that the upstart configs are not ensured present on RHEL.","commit_id":"1be575734d05728b0c608731e1eeafa0115cb0e5"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e940caaf14bc4e9ccc05af541faa1a2f274e4070","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      target \u003d\u003e \u0027/lib/init/upstart-job\u0027,"},{"line_number":59,"context_line":"    }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  } else {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    file { \u0027/etc/init/cgconfig.conf\u0027:"},{"line_number":64,"context_line":"      ensure  \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"AAAAM3%2F%2FUYU%3D","line":61,"in_reply_to":"AAAAM3%2F%2FUZs%3D","updated":"2013-01-29 05:18:40.000000000","message":"Fixing. I\u0027ll nest the OS rev. conditional inside the OS one instead.","commit_id":"1be575734d05728b0c608731e1eeafa0115cb0e5"}],"modules/jenkins/templates/cgconfig.erb":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ff440768e627392b34bb29e5f7813372fdb984de","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        blkio   \u003d /cgroup/blkio;"},{"line_number":12,"context_line":"}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u003c% elsif ( operatingsystemrelease \u003c \u002712.10\u0027 ) or ( operatingsystem !\u003d \u0027Ubuntu\u0027 ) then %\u003e"},{"line_number":15,"context_line":"mount {"},{"line_number":16,"context_line":"        cpu \u003d /sys/fs/cgroup/cpu;"},{"line_number":17,"context_line":"        cpuacct \u003d /sys/fs/cgroup/cpuacct;"}],"source_content_type":"application/x-erb","patch_set":4,"id":"AAAAM3%2F%2FUZw%3D","line":14,"updated":"2013-01-29 04:52:50.000000000","message":"Shouldn\u0027t this be an \u0027and ( operatingsystem \u003d\u003d \u0027Ubuntu\u0027)\u0027 ?","commit_id":"1be575734d05728b0c608731e1eeafa0115cb0e5"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e940caaf14bc4e9ccc05af541faa1a2f274e4070","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        blkio   \u003d /cgroup/blkio;"},{"line_number":12,"context_line":"}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u003c% elsif ( operatingsystemrelease \u003c \u002712.10\u0027 ) or ( operatingsystem !\u003d \u0027Ubuntu\u0027 ) then %\u003e"},{"line_number":15,"context_line":"mount {"},{"line_number":16,"context_line":"        cpu \u003d /sys/fs/cgroup/cpu;"},{"line_number":17,"context_line":"        cpuacct \u003d /sys/fs/cgroup/cpuacct;"}],"source_content_type":"application/x-erb","patch_set":4,"id":"AAAAM3%2F%2FUYg%3D","line":14,"in_reply_to":"AAAAM3%2F%2FUZw%3D","updated":"2013-01-29 05:18:40.000000000","message":"Nope, \"if a or not b\" is the inverse of \"if not a and b\". We want this section present if the operating system is not Ubuntu, unless the Ubuntu version is less than 12.10.","commit_id":"1be575734d05728b0c608731e1eeafa0115cb0e5"}]}