)]}'
{"manifests/site.pp":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"4c0be05ee876636c120276a242e121bd5eb7a7ee","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    sysadmins                       \u003d\u003e hiera(\u0027sysadmins\u0027),"},{"line_number":40,"context_line":"    swift_username                  \u003d\u003e hiera(\u0027openstackwatch_swift_username\u0027),"},{"line_number":41,"context_line":"    swift_password                  \u003d\u003e hiera(\u0027openstackwatch_swift_password\u0027),"},{"line_number":42,"context_line":"    swift_auth_url                  \u003d\u003e hiera(\u0027openstackwatch_swift_auth_url\u0027),"},{"line_number":43,"context_line":"  }"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"AAAAOH%2F%2F7qg%3D","line":42,"updated":"2013-03-20 14:27:24.000000000","message":"I think this third one can just be set in openstack_project::gerrit since it doesn\u0027t need to be secret.","commit_id":"e5117bfa634e3a02d5e7169a805ae0c70244041f"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"25e52ddffcf0992fac25d6f627e3c5ce00ad0321","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    contactstore_pubkey             \u003d\u003e hiera(\u0027gerrit_contactstore_pubkey\u0027),"},{"line_number":39,"context_line":"    sysadmins                       \u003d\u003e hiera(\u0027sysadmins\u0027),"},{"line_number":40,"context_line":"    swift_username                  \u003d\u003e hiera(\u0027openstackwatch_swift_username\u0027),"},{"line_number":41,"context_line":"    swift_password                  \u003d\u003e hiera(\u0027openstackwatch_swift_password\u0027),"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"AAAAOH%2F%2F5bE%3D","line":41,"updated":"2013-03-21 19:32:56.000000000","message":"It probably makes sense to reuse hiera(\u0027swift_store_user\u0027) and hiera(\u0027swift_store_key\u0027) here, since we already have them allocated for the glancetest class anyway.","commit_id":"b0aa3bd669ff0c596fd000faf1aec79bcf67db30"}],"modules/jeepyb/manifests/openstackwatch.pp":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"4c0be05ee876636c120276a242e121bd5eb7a7ee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  $swift_username \u003d \u0027\u0027,"},{"line_number":5,"context_line":"  $swift_password \u003d \u0027\u0027,"},{"line_number":6,"context_line":"  $swift_auth_url \u003d \u0027\u0027,"},{"line_number":7,"context_line":"  $auth_version \u003d \u00271.0\u0027,"},{"line_number":8,"context_line":"  $projects \u003d [],"},{"line_number":9,"context_line":"  $mode \u003d \u0027multiple\u0027,"},{"line_number":10,"context_line":"  $container \u003d \u0027rss\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"AAAAOH%2F%2F7qc%3D","line":7,"updated":"2013-03-20 14:27:24.000000000","message":"Since the auth_version value is going to be dependent on the provider being used, there\u0027s probably no good default to include here. Both the version and the URL should be set as string literals in openstack_project::gerrit instead where jeepyb::openstackwatch is being instantiated.","commit_id":"e5117bfa634e3a02d5e7169a805ae0c70244041f"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"25e52ddffcf0992fac25d6f627e3c5ce00ad0321","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    require    \u003d\u003e Group[\u0027openstackwatch\u0027],"},{"line_number":29,"context_line":"  }"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  if len($swift_password) \u003e 0 {"},{"line_number":32,"context_line":"    cron { \u0027openstackwatch\u0027:"},{"line_number":33,"context_line":"      ensure  \u003d\u003e present,"},{"line_number":34,"context_line":"      command \u003d\u003e \u0027/usr/local/bin/openstackwatch /home/openstackwatch/openstackwatch.ini\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"AAAAOH%2F%2F5ao%3D","line":31,"updated":"2013-03-21 19:32:56.000000000","message":"This is probably okay, but in most places we\u0027re using something more like...\n\n    if $swift_password !\u003d \u0027\u0027 {","commit_id":"b0aa3bd669ff0c596fd000faf1aec79bcf67db30"}],"modules/openstack_project/manifests/gerrit.pp":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"7c4297af7cadf57b983327f79d87ba23567f533b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"  $war \u003d \u0027\u0027,"},{"line_number":36,"context_line":"  $contactstore \u003d false,"},{"line_number":37,"context_line":"  $contactstore_appsec \u003d \u0027\u0027,"},{"line_number":38,"context_line":"  $contactstore_pubkey \u003d \u0027\u0027,"},{"line_number":39,"context_line":"  $contactstore_url \u003d \u0027\u0027,"},{"line_number":40,"context_line":"  $script_user \u003d \u0027update\u0027,"},{"line_number":41,"context_line":"  $script_key_file \u003d \u0027/home/gerrit2/.ssh/id_rsa\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"AAAAOH%2F%2F7kU%3D","line":38,"updated":"2013-03-20 15:17:49.000000000","message":"I believe you also need to add $swift_username and $swift_password set \u003d to \u0027\u0027 somewhere up here...","commit_id":"e8b74c156dc17b15e0cb1a978966137e1400db8c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"7c4297af7cadf57b983327f79d87ba23567f533b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    feed           \u003d\u003e \u0027openstackwatch.xml\u0027,"},{"line_number":75,"context_line":"    json_url       \u003d\u003e \u0027https://review.openstack.org/query?q\u003dstatus:open\u0027,"},{"line_number":76,"context_line":"    swift_auth_url \u003d\u003e \u0027https://swift_auth_url_goes_here\u0027,"},{"line_number":77,"context_line":"    auth_version   \u003d\u003e \u00271.0\u0027,"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  class { \u0027::gerrit\u0027:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"AAAAOH%2F%2F7kM%3D","line":77,"updated":"2013-03-20 15:17:49.000000000","message":"...and similarly pass swift_username \u003d\u003e $swift_username here and do the same for swift_password as well.","commit_id":"e8b74c156dc17b15e0cb1a978966137e1400db8c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"25e52ddffcf0992fac25d6f627e3c5ce00ad0321","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    json_url       \u003d\u003e \u0027https://review.openstack.org/query?q\u003dstatus:open\u0027,"},{"line_number":78,"context_line":"    swift_username \u003d\u003e $swift_username,"},{"line_number":79,"context_line":"    swift_password \u003d\u003e $swift_password,"},{"line_number":80,"context_line":"    swift_auth_url \u003d\u003e \u0027https://swift_auth_url_goes_here\u0027,"},{"line_number":81,"context_line":"    auth_version   \u003d\u003e \u00271.0\u0027,"},{"line_number":82,"context_line":"  }"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"AAAAOH%2F%2F5aI%3D","line":80,"updated":"2013-03-21 19:32:56.000000000","message":"It looks like the recommended URL from the sample config is what we want anyway, so use...\n\n      swift_auth_url \u003d\u003e \u0027https://auth.api.rackspacecloud.com/v1.0\u0027,","commit_id":"b0aa3bd669ff0c596fd000faf1aec79bcf67db30"}]}