)]}'
{"modules/openstack_project/files/logs/htmlify-screen-log.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ff1ea904145d0f3fa3f4e1bcd177bad42d3eee94","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def passthrough_filter(fname, minsev):"},{"line_number":110,"context_line":"    sev \u003d \"None\""},{"line_number":111,"context_line":"    for line in fileinput.FileInput(fname, openhook\u003dfileinput.hook_compressed):"},{"line_number":112,"context_line":"        newsev \u003d sev_of_line(line)"},{"line_number":113,"context_line":"        if newsev is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FcDY%3D","line":110,"updated":"2013-09-26 16:48:39.000000000","message":"Can we set sev to None here instead of \"None\" to be consistent with line 148?","commit_id":"bf37f12a17726e71d2dc1ccef6f1eceac7236a15"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7216f6fb1ff96f10a0c33d97a69aca72452bea26","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"def passthrough_filter(fname, minsev):"},{"line_number":110,"context_line":"    sev \u003d \"None\""},{"line_number":111,"context_line":"    for line in fileinput.FileInput(fname, openhook\u003dfileinput.hook_compressed):"},{"line_number":112,"context_line":"        newsev \u003d sev_of_line(line)"},{"line_number":113,"context_line":"        if newsev is not None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FcCE%3D","line":110,"in_reply_to":"AAAAS3%2F%2FcDY%3D","updated":"2013-09-26 16:53:24.000000000","message":"yes, I think so. Let me fix.","commit_id":"bf37f12a17726e71d2dc1ccef6f1eceac7236a15"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ff1ea904145d0f3fa3f4e1bcd177bad42d3eee94","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            sev \u003d newsev"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if skip_line_by_sev(sev, minsev):"},{"line_number":117,"context_line":"            continue"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        yield line"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FcDo%3D","line":117,"updated":"2013-09-26 16:48:39.000000000","message":"I think this if needs to fall under the if above it as in html_filter(). If we don\u0027t do this then sev may contain the old value and we can improperly skip lines.","commit_id":"bf37f12a17726e71d2dc1ccef6f1eceac7236a15"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f849340e07d42003e88b15b2c991214b978afb7b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            sev \u003d newsev"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if skip_line_by_sev(sev, minsev):"},{"line_number":117,"context_line":"            continue"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        yield line"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2Fb9Y%3D","line":117,"in_reply_to":"AAAAS3%2F%2FcCg%3D","updated":"2013-09-26 17:11:10.000000000","message":"Right, sev\u0027s scope is the function not the loop. Say on the first iteration it sets sev to DEBUG then on the second newsev is None we will continue to use DEBUG as the sev.","commit_id":"bf37f12a17726e71d2dc1ccef6f1eceac7236a15"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7216f6fb1ff96f10a0c33d97a69aca72452bea26","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            sev \u003d newsev"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        if skip_line_by_sev(sev, minsev):"},{"line_number":117,"context_line":"            continue"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        yield line"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FcCg%3D","line":117,"in_reply_to":"AAAAS3%2F%2FcDo%3D","updated":"2013-09-26 16:53:24.000000000","message":"the sev scope in the function is getting set above, so this should be fine.","commit_id":"bf37f12a17726e71d2dc1ccef6f1eceac7236a15"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e585bdb6882caac24bbebc8f6df663594f5794bd","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        sev \u003d sev_of_line(newline, sev)"},{"line_number":160,"context_line":"        if skip_line_by_sev(sev, minsev):"},{"line_number":161,"context_line":"                continue"},{"line_number":162,"context_line":"        newline \u003d color_by_sev(newline)"},{"line_number":163,"context_line":"        newline \u003d link_timestamp(newline)"},{"line_number":164,"context_line":"        yield newline"},{"line_number":165,"context_line":"    yield _html_close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAS3%2F%2FbM8%3D","line":162,"updated":"2013-09-26 22:16:00.000000000","message":"This is running the regex on every line twice; you should probably change color_by_sev to take the sev argument too.","commit_id":"fc75537358ac9329bc952bef3149f8f587b95499"}]}