)]}'
{"launch/dns.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"317bfe9c220ace248dd35b7d74465eacc7fb77ef","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    try:"},{"line_number":37,"context_line":"        servers \u003d cloud.nova_client.servers.list()"},{"line_number":38,"context_line":"    except ImportError:"},{"line_number":39,"context_line":"        # novaclient is no longer used by shade in recent versions"},{"line_number":40,"context_line":"        servers \u003d cloud.list_servers()"},{"line_number":41,"context_line":"    for raw_server in servers:"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_9ad09b21","line":38,"updated":"2018-03-22 22:47:30.000000000","message":"Couple of things. Reading current shade code there is still support for the legacy clients in shade.openstackcloud. So I\u0027m curious how this failed in the first place. Perhaps novaclient wasn\u0027t installed.\n\nMy main concern is that reading the support for the legacy clients leads me to believe that if there is an ImportError then os-client-config catches that and reraises OpenStackConfigException instead. I\u0027m curious if you have the traceback handy for when this failed so that we can be sure we are catching the correct thing.","commit_id":"e243c79f2885b2f60827604a3ff2320b89c42d20"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"317bfe9c220ace248dd35b7d74465eacc7fb77ef","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        servers \u003d cloud.nova_client.servers.list()"},{"line_number":38,"context_line":"    except ImportError:"},{"line_number":39,"context_line":"        # novaclient is no longer used by shade in recent versions"},{"line_number":40,"context_line":"        servers \u003d cloud.list_servers()"},{"line_number":41,"context_line":"    for raw_server in servers:"},{"line_number":42,"context_line":"        if raw_server.id \u003d\u003d server.id:"},{"line_number":43,"context_line":"            href \u003d get_href(raw_server)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_faac37a0","line":40,"updated":"2018-03-22 22:47:30.000000000","message":"Further reading of shade code implies that cloud.list_servers has been around since the very initial commit including library code. I think we may just be able to switch to using cloud.list_servers without any method checking.","commit_id":"e243c79f2885b2f60827604a3ff2320b89c42d20"}]}