)]}'
{"docker/gitea/Dockerfile":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1f10012df936116445e8c11d78c132abed76d30d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    git \u0026\u0026 \\"},{"line_number":68,"context_line":"  echo \"git:$(dd if\u003d/dev/urandom bs\u003d24 count\u003d1 status\u003dnone | base64)\" | chpasswd"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"COPY --from\u003dbuild-env /go/src/code.gitea.io/gitea/docker /"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"###################################"},{"line_number":73,"context_line":"# The gitea image"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3f79a3b5_dd491b87","line":70,"updated":"2018-12-19 22:54:05.000000000","message":"Done: Copy the /etc config files and entrypoint script","commit_id":"1d19d16cb8c897ebab73428fdfecb3ca6075fa6e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c25f956355b459fed61e33f40b4ffeca104f57b8","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    git \u0026\u0026 \\"},{"line_number":68,"context_line":"  echo \"git:$(dd if\u003d/dev/urandom bs\u003d24 count\u003d1 status\u003dnone | base64)\" | chpasswd"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"COPY --from\u003dbuild-env /go/src/code.gitea.io/gitea/docker /"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"###################################"},{"line_number":73,"context_line":"# The gitea image"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3f79a3b5_1da6b356","line":70,"updated":"2018-12-19 22:47:36.000000000","message":"Might be worth a comment to describe what this is copying? The actual binary seems to be copied below.","commit_id":"1d19d16cb8c897ebab73428fdfecb3ca6075fa6e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1f10012df936116445e8c11d78c132abed76d30d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"ENV USER git"},{"line_number":83,"context_line":"ENV GITEA_CUSTOM /data/gitea"},{"line_number":84,"context_line":"VOLUME [\"/data\"]"},{"line_number":85,"context_line":"ENTRYPOINT [\"/usr/bin/entrypoint\"]"},{"line_number":86,"context_line":"CMD [\"/app/gitea/gitea\"]"},{"line_number":87,"context_line":"USER 1000:1000"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3f79a3b5_7d28079d","line":85,"updated":"2018-12-19 22:54:05.000000000","message":"The copy above (see Clark\u0027s question).","commit_id":"1d19d16cb8c897ebab73428fdfecb3ca6075fa6e"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7b2ccb0a9daaa74c2007958969ed58cbcae7634f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"ENV USER git"},{"line_number":83,"context_line":"ENV GITEA_CUSTOM /data/gitea"},{"line_number":84,"context_line":"VOLUME [\"/data\"]"},{"line_number":85,"context_line":"ENTRYPOINT [\"/usr/bin/entrypoint\"]"},{"line_number":86,"context_line":"CMD [\"/app/gitea/gitea\"]"},{"line_number":87,"context_line":"USER 1000:1000"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3f79a3b5_bd73ffe5","line":85,"updated":"2018-12-19 22:52:02.000000000","message":"What installs /usr/bin/entrypoint? it seems to be only in the openssh image below.","commit_id":"1d19d16cb8c897ebab73428fdfecb3ca6075fa6e"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"1f10012df936116445e8c11d78c132abed76d30d","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"###################################"},{"line_number":90,"context_line":"# The openssh server image"},{"line_number":91,"context_line":"FROM base as gitea-openssh"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"RUN DEBIAN_FRONTEND\u003dnoninteractive apt-get -y -o Dpkg::Options::\u003d\"--force-confold\" \\"},{"line_number":94,"context_line":"  install openssh-server \\"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3f79a3b5_9d2de3ae","line":91,"updated":"2018-12-19 22:54:05.000000000","message":"Clark, yes it does -- our entrypoint script runs the service setup file for openssh to generate host keys.\nMonty, the sshd-entrypoint.sh file is from the current working directory, not a previous image stage.","commit_id":"1d19d16cb8c897ebab73428fdfecb3ca6075fa6e"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"c25f956355b459fed61e33f40b4ffeca104f57b8","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"###################################"},{"line_number":90,"context_line":"# The openssh server image"},{"line_number":91,"context_line":"FROM base as gitea-openssh"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"RUN DEBIAN_FRONTEND\u003dnoninteractive apt-get -y -o Dpkg::Options::\u003d\"--force-confold\" \\"},{"line_number":94,"context_line":"  install openssh-server \\"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3f79a3b5_9d5f234b","line":91,"updated":"2018-12-19 22:47:36.000000000","message":"Does this image depend on /go/src/code.gitea.io/gitea/docker\u0027s content? If not maybe we want to move that COPY into the gitea image instead.","commit_id":"1d19d16cb8c897ebab73428fdfecb3ca6075fa6e"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7b2ccb0a9daaa74c2007958969ed58cbcae7634f","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"###################################"},{"line_number":90,"context_line":"# The openssh server image"},{"line_number":91,"context_line":"FROM base as gitea-openssh"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"RUN DEBIAN_FRONTEND\u003dnoninteractive apt-get -y -o Dpkg::Options::\u003d\"--force-confold\" \\"},{"line_number":94,"context_line":"  install openssh-server \\"}],"source_content_type":"text/x-dockerfile","patch_set":5,"id":"3f79a3b5_5d3e6be2","line":91,"in_reply_to":"3f79a3b5_9d5f234b","updated":"2018-12-19 22:52:02.000000000","message":"Instead of making it depend on gitea-openssh, why not just have it be FROM debian:testing and do copy --from\u003dbuild-env to get the sshd-entrypoint.sh file?","commit_id":"1d19d16cb8c897ebab73428fdfecb3ca6075fa6e"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ac14fc78447789981d9459aea4dd9e164b88a7dd","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    git \\"},{"line_number":55,"context_line":"    openssh-client \\"},{"line_number":56,"context_line":"    tzdata \\"},{"line_number":57,"context_line":"  \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN addgroup \\"},{"line_number":60,"context_line":"    --system --gid 1000 \\"}],"source_content_type":"text/x-dockerfile","patch_set":7,"id":"3f79a3b5_2fc9f621","line":57,"range":{"start_line":57,"start_character":5,"end_line":57,"end_character":32},"updated":"2018-12-19 23:43:54.000000000","message":"I think you also want to run:\n\n  \u0026\u0026 apt-get clean\n\nto get rid of the downloaded debs.","commit_id":"e527726fc164ea8bb04352713044dbd5a9aeeecc"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ac14fc78447789981d9459aea4dd9e164b88a7dd","unresolved":false,"context_lines":[{"line_number":78,"context_line":"COPY --from\u003dbuild-env /go/src/code.gitea.io/gitea/gitea /app/gitea/gitea"},{"line_number":79,"context_line":"RUN ln -s /app/gitea/gitea /usr/local/bin/gitea"},{"line_number":80,"context_line":"RUN apt-get update \u0026\u0026 apt-get -y install pandoc \\"},{"line_number":81,"context_line":"  \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"EXPOSE 3000"},{"line_number":84,"context_line":"ENV USER git"}],"source_content_type":"text/x-dockerfile","patch_set":7,"id":"3f79a3b5_afd426ba","line":81,"range":{"start_line":81,"start_character":3,"end_line":81,"end_character":32},"updated":"2018-12-19 23:43:54.000000000","message":"Same thing","commit_id":"e527726fc164ea8bb04352713044dbd5a9aeeecc"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ac14fc78447789981d9459aea4dd9e164b88a7dd","unresolved":false,"context_lines":[{"line_number":95,"context_line":"RUN apt-get update \\"},{"line_number":96,"context_line":"  \u0026\u0026 DEBIAN_FRONTEND\u003dnoninteractive apt-get -y -o Dpkg::Options::\u003d\"--force-confold\" \\"},{"line_number":97,"context_line":"    install openssh-server \\"},{"line_number":98,"context_line":"  \u0026\u0026 rm -rf /var/lib/apt/lists/*"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"COPY sshd-entrypoint.sh /usr/bin/entrypoint"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-dockerfile","patch_set":7,"id":"3f79a3b5_4fe792af","line":98,"range":{"start_line":98,"start_character":2,"end_line":98,"end_character":32},"updated":"2018-12-19 23:43:54.000000000","message":"Same thing.","commit_id":"e527726fc164ea8bb04352713044dbd5a9aeeecc"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e010d55bf65b1ea96512e8f8af14f4965ad60113","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    --uid 1000 \\"},{"line_number":68,"context_line":"    --gid 1000 \\"},{"line_number":69,"context_line":"    git \u0026\u0026 \\"},{"line_number":70,"context_line":"  echo \"git:$(dd if\u003d/dev/urandom bs\u003d24 count\u003d1 status\u003dnone | base64)\" | chpasswd"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Copy the /etc config files and entrypoint script"},{"line_number":73,"context_line":"COPY --from\u003dbuild-env /go/src/code.gitea.io/gitea/docker /"}],"source_content_type":"text/x-dockerfile","patch_set":11,"id":"bfdaf3ff_d993075c","line":70,"updated":"2019-01-10 21:29:13.000000000","message":"Copied from upstream; I agree that sounds better, let\u0027s try it.","commit_id":"3ce494ababec3c83f30434924f193c097f7e75dd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"eb303ffe67c5ed17274beac35fcbb495686cbeef","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    --uid 1000 \\"},{"line_number":68,"context_line":"    --gid 1000 \\"},{"line_number":69,"context_line":"    git \u0026\u0026 \\"},{"line_number":70,"context_line":"  echo \"git:$(dd if\u003d/dev/urandom bs\u003d24 count\u003d1 status\u003dnone | base64)\" | chpasswd"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# Copy the /etc config files and entrypoint script"},{"line_number":73,"context_line":"COPY --from\u003dbuild-env /go/src/code.gitea.io/gitea/docker /"}],"source_content_type":"text/x-dockerfile","patch_set":11,"id":"bfdaf3ff_395ed3e6","line":70,"updated":"2019-01-10 21:22:53.000000000","message":"Why does this user need a passwd? Shouldn\u0027t we set it to! and disable it entirely?","commit_id":"3ce494ababec3c83f30434924f193c097f7e75dd"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"eb303ffe67c5ed17274beac35fcbb495686cbeef","unresolved":false,"context_lines":[{"line_number":108,"context_line":"EXPOSE 22"},{"line_number":109,"context_line":"VOLUME [\"/data\"]"},{"line_number":110,"context_line":"ENTRYPOINT [\"/usr/bin/entrypoint\"]"},{"line_number":111,"context_line":"CMD [\"/usr/sbin/sshd\", \"-D\"]"}],"source_content_type":"text/x-dockerfile","patch_set":11,"id":"bfdaf3ff_5904f7c6","line":111,"updated":"2019-01-10 21:22:53.000000000","message":"Related to the passwd above do we need to edit the ssh config to disable passwd login? iirc debuntu allow this by default for non root users.","commit_id":"3ce494ababec3c83f30434924f193c097f7e75dd"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e010d55bf65b1ea96512e8f8af14f4965ad60113","unresolved":false,"context_lines":[{"line_number":108,"context_line":"EXPOSE 22"},{"line_number":109,"context_line":"VOLUME [\"/data\"]"},{"line_number":110,"context_line":"ENTRYPOINT [\"/usr/bin/entrypoint\"]"},{"line_number":111,"context_line":"CMD [\"/usr/sbin/sshd\", \"-D\"]"}],"source_content_type":"text/x-dockerfile","patch_set":11,"id":"bfdaf3ff_f9904b51","line":111,"updated":"2019-01-10 21:29:13.000000000","message":"We\u0027re good on that point -- here\u0027s the sshd_config that is placed in the image: https://github.com/go-gitea/gitea/blob/master/docker/etc/ssh/sshd_config","commit_id":"3ce494ababec3c83f30434924f193c097f7e75dd"}],"playbooks/zuul/build-image-upload.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"eb303ffe67c5ed17274beac35fcbb495686cbeef","unresolved":false,"context_lines":[{"line_number":8,"context_line":"          no_log: true"},{"line_number":9,"context_line":"        - name: Upload to dockerhub"},{"line_number":10,"context_line":"          command: \"docker push {{ item.repository }}\""},{"line_number":11,"context_line":"          loop: \"{{ images }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfdaf3ff_79321baa","line":11,"updated":"2019-01-10 21:22:53.000000000","message":"Does the upload step need no_log: true too? I guess it depends on whether or not it will dump auth details on failure.","commit_id":"3ce494ababec3c83f30434924f193c097f7e75dd"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"e010d55bf65b1ea96512e8f8af14f4965ad60113","unresolved":false,"context_lines":[{"line_number":8,"context_line":"          no_log: true"},{"line_number":9,"context_line":"        - name: Upload to dockerhub"},{"line_number":10,"context_line":"          command: \"docker push {{ item.repository }}\""},{"line_number":11,"context_line":"          loop: \"{{ images }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfdaf3ff_999d7f68","line":11,"updated":"2019-01-10 21:29:13.000000000","message":"I don\u0027t think so.  Loci doesn\u0027t have it: http://git.openstack.org/cgit/openstack/loci/tree/playbooks/push.yaml","commit_id":"3ce494ababec3c83f30434924f193c097f7e75dd"}]}