)]}'
{".zuul.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0b962ce6e1e92df22fe2f3b3ac14000f45fd6acd","unresolved":false,"context_lines":[{"line_number":639,"context_line":"      playbook_name: zuul_reconfigure.yaml"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"- project:"},{"line_number":642,"context_line":"#    templates:"},{"line_number":643,"context_line":"#      - system-config-zuul-role-integration"},{"line_number":644,"context_line":"#      - infra-puppet-apply-jobs"},{"line_number":645,"context_line":"#      - infra-logstash-filter-jobs"},{"line_number":646,"context_line":"#      - publish-tox-docs-infra"},{"line_number":647,"context_line":"    check:"},{"line_number":648,"context_line":"      jobs:"},{"line_number":649,"context_line":"#        - opendev-buildset-registry"},{"line_number":650,"context_line":"        - tox-linters"},{"line_number":651,"context_line":"#        - legacy-system-config-puppet-syntax-3"},{"line_number":652,"context_line":"#        - puppet-beaker-rspec-infra-system-config"},{"line_number":653,"context_line":"#        - puppet-beaker-rspec-puppet-4-infra-system-config"},{"line_number":654,"context_line":"#        - system-config-run-base"},{"line_number":655,"context_line":"#        - system-config-run-base-ansible-devel:"},{"line_number":656,"context_line":"#            voting: false"},{"line_number":657,"context_line":"#        - system-config-run-dns"},{"line_number":658,"context_line":"#        - system-config-run-eavesdrop"},{"line_number":659,"context_line":"#        - system-config-run-nodepool"},{"line_number":660,"context_line":"#        - system-config-run-docker"},{"line_number":661,"context_line":"        - system-config-run-mirror"},{"line_number":662,"context_line":"#        - system-config-run-docker-registry"},{"line_number":663,"context_line":"#        - system-config-run-gitea:"},{"line_number":664,"context_line":"#            dependencies:"},{"line_number":665,"context_line":"#              - name: system-config-build-image-gitea"},{"line_number":666,"context_line":"#                soft: true"},{"line_number":667,"context_line":"#        - system-config-run-zuul-preview"},{"line_number":668,"context_line":"#        - system-config-run-letsencrypt"},{"line_number":669,"context_line":"#        - system-config-build-image-jinja-init"},{"line_number":670,"context_line":"#        - system-config-build-image-gitea-init"},{"line_number":671,"context_line":"#        - system-config-build-image-gitea"},{"line_number":672,"context_line":"#        - system-config-build-image-gerrit"},{"line_number":673,"context_line":"#        - system-config-build-image-python-base"},{"line_number":674,"context_line":"#        - system-config-build-image-python-builder"},{"line_number":675,"context_line":"    gate:"},{"line_number":676,"context_line":"      jobs:"},{"line_number":677,"context_line":"        - opendev-buildset-registry"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"dfbec78f_e874426a","line":674,"range":{"start_line":642,"start_character":0,"end_line":674,"end_character":25},"updated":"2019-05-14 08:11:01.000000000","message":"this needs updating before the change can merge... Noticing it since you removed WIP.","commit_id":"90e4dd6d93c7f7985c3e634764159c9a50508352"}],"playbooks/base.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ee07ab451f7c1bf5e1c3a316e88c5ac96cc84774","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        - kdc03.openstack.org"},{"line_number":120,"context_line":"        - kdc04.openstack.org"},{"line_number":121,"context_line":"    - role: openafs-client"},{"line_number":122,"context_line":"    - role: mirror"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_1f1389b7","line":122,"updated":"2019-05-20 21:37:43.000000000","message":"This may need to be split out into its own playbook now that the base.yaml splitting has merged.","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7b5759bb605be31351272fbc1c11e91e416a8d79","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        - kdc03.openstack.org"},{"line_number":120,"context_line":"        - kdc04.openstack.org"},{"line_number":121,"context_line":"    - role: openafs-client"},{"line_number":122,"context_line":"    - role: mirror"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_7faba51c","line":122,"in_reply_to":"bfb3d3c7_1f1389b7","updated":"2019-05-20 21:45:59.000000000","message":"Yes, I think that\u0027s right.","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c00d21cbfc8144b26e94b14e6d29d027517654e2","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        - kdc03.openstack.org"},{"line_number":120,"context_line":"        - kdc04.openstack.org"},{"line_number":121,"context_line":"    - role: openafs-client"},{"line_number":122,"context_line":"    - role: mirror"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_65f0f6ca","line":122,"in_reply_to":"bfb3d3c7_7faba51c","updated":"2019-05-21 00:01:48.000000000","message":"Done","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"}],"playbooks/group_vars/mirror_opendev.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ee07ab451f7c1bf5e1c3a316e88c5ac96cc84774","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - 80"},{"line_number":3,"context_line":"  - 8080"},{"line_number":4,"context_line":"  - 8081"},{"line_number":5,"context_line":"  - 8082"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_9f1e99b8","line":5,"updated":"2019-05-20 21:37:43.000000000","message":"443?","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c00d21cbfc8144b26e94b14e6d29d027517654e2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  - 80"},{"line_number":3,"context_line":"  - 8080"},{"line_number":4,"context_line":"  - 8081"},{"line_number":5,"context_line":"  - 8082"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_85edeaf0","line":5,"in_reply_to":"bfb3d3c7_9f1e99b8","updated":"2019-05-21 00:01:48.000000000","message":"Done","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"}],"playbooks/roles/mirror/tasks/main.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"0b962ce6e1e92df22fe2f3b3ac14000f45fd6acd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check AFS mounted"},{"line_number":2,"context_line":"  stat:"},{"line_number":3,"context_line":"    path: \"/afs/openstack.org/mirror\""},{"line_number":4,"context_line":"  register: afs_mirror"},{"line_number":5,"context_line":"- name: Sanity check AFS"},{"line_number":6,"context_line":"  assert:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"dfbec78f_a86aca7d","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":25},"updated":"2019-05-14 08:11:01.000000000","message":"openstack.org or opendev.org?","commit_id":"90e4dd6d93c7f7985c3e634764159c9a50508352"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d10225d832715d852e558c85c18ff0b629f9eace","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- name: Check AFS mounted"},{"line_number":2,"context_line":"  stat:"},{"line_number":3,"context_line":"    path: \"/afs/openstack.org/mirror\""},{"line_number":4,"context_line":"  register: afs_mirror"},{"line_number":5,"context_line":"- name: Sanity check AFS"},{"line_number":6,"context_line":"  assert:"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"dfbec78f_c8ea9ed6","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":25},"in_reply_to":"dfbec78f_a86aca7d","updated":"2019-05-14 08:19:25.000000000","message":"This is the AFS path on disk; it will remain as openstack.org unless we go to the effort of migrating all the AFS volumes to a new location","commit_id":"90e4dd6d93c7f7985c3e634764159c9a50508352"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ee07ab451f7c1bf5e1c3a316e88c5ac96cc84774","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  command: a2dissite 000-default.conf"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"- name: Enable mirror virtual host"},{"line_number":128,"context_line":"  command: a2ensite mirror"},{"line_number":129,"context_line":"  notify:"},{"line_number":130,"context_line":"    - restart apache2"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_dfd731bf","line":128,"updated":"2019-05-20 21:37:43.000000000","message":"Because this is done via command, will we end up notifying the restart of apache every time ansible runs? If so I think this will result in a small/short apache outage every 45 minutes or so.\n\nAs an alternative (if necessary) can \"Create mirror virtual host\" above write to sites-enabled and if the file updates then the handler would run?","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c00d21cbfc8144b26e94b14e6d29d027517654e2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  command: a2dissite 000-default.conf"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"- name: Enable mirror virtual host"},{"line_number":128,"context_line":"  command: a2ensite mirror"},{"line_number":129,"context_line":"  notify:"},{"line_number":130,"context_line":"    - restart apache2"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_458ff229","line":128,"in_reply_to":"bfb3d3c7_3f1a0d7d","updated":"2019-05-21 00:01:48.000000000","message":"I took the creates/removes approach, and did similar with the default site above.","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7b5759bb605be31351272fbc1c11e91e416a8d79","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  command: a2dissite 000-default.conf"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"- name: Enable mirror virtual host"},{"line_number":128,"context_line":"  command: a2ensite mirror"},{"line_number":129,"context_line":"  notify:"},{"line_number":130,"context_line":"    - restart apache2"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":29,"id":"bfb3d3c7_3f1a0d7d","line":128,"in_reply_to":"bfb3d3c7_dfd731bf","updated":"2019-05-20 21:45:59.000000000","message":"Yeah - I think that\u0027s a better plan. Alternately, we could add\n\n  creates: /etc/apache.d/site-enabled/mirror.conf\n\nand ansible won\u0027t run a2ensite - but since we\u0027d be mentioning the file anyway, might as well just write the file directly.","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"}],"playbooks/roles/mirror/templates/mirror.vhost.j2":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"ee07ab451f7c1bf5e1c3a316e88c5ac96cc84774","unresolved":false,"context_lines":[{"line_number":290,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"# Docker registry v1 proxy."},{"line_number":293,"context_line":"\u003cVirtualHost *:8081\u003e"},{"line_number":294,"context_line":"    ServerName {{ apache_server_name }}:8081"},{"line_number":295,"context_line":"    ServerAlias {{ apache_server_alias }}:8081"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"bfb3d3c7_3f952de5","line":293,"updated":"2019-05-20 21:37:43.000000000","message":"As a note we may be able to delete this vhost. We\u0027ve pushed people to use teh v2 proxy instead largely because modern docker doesn\u0027t support v1.","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"7b5759bb605be31351272fbc1c11e91e416a8d79","unresolved":false,"context_lines":[{"line_number":290,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"# Docker registry v1 proxy."},{"line_number":293,"context_line":"\u003cVirtualHost *:8081\u003e"},{"line_number":294,"context_line":"    ServerName {{ apache_server_name }}:8081"},{"line_number":295,"context_line":"    ServerAlias {{ apache_server_alias }}:8081"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"bfb3d3c7_7f596558","line":293,"in_reply_to":"bfb3d3c7_3f952de5","updated":"2019-05-20 21:45:59.000000000","message":"We\u0027re only putting the v1 host into mirror info. Change to add v2:\n\nhttps://review.opendev.org/#/c/580871/\n\nstalled out - then I we started talking about ways to provide the mirrors behind an api that makes sense.\n\nI\u0027d like to get rid of v1, because ew ... but I think we may want to think about it a bit more.","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c00d21cbfc8144b26e94b14e6d29d027517654e2","unresolved":false,"context_lines":[{"line_number":290,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"# Docker registry v1 proxy."},{"line_number":293,"context_line":"\u003cVirtualHost *:8081\u003e"},{"line_number":294,"context_line":"    ServerName {{ apache_server_name }}:8081"},{"line_number":295,"context_line":"    ServerAlias {{ apache_server_alias }}:8081"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":29,"id":"bfb3d3c7_a57d8e1d","line":293,"in_reply_to":"bfb3d3c7_7f596558","updated":"2019-05-21 00:01:48.000000000","message":"Ok, will leave as-is for now","commit_id":"7e1517104e8962837afb3b5e2e4a8369bef6e3eb"}]}