)]}'
{"playbooks/roles/mirror-update/tasks/main.yaml":[{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"95edfbad8c5bac3e4d637712dc0417f10125fbd3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# because jinja treats the content as utf-8, and ends up mangling"},{"line_number":9,"context_line":"# \"real\" binary data like a keytab.  See issues like:"},{"line_number":10,"context_line":"#  https://github.com/ansible/ansible/issues/20150"},{"line_number":11,"context_line":"- name: Install afsadmin keytab"},{"line_number":12,"context_line":"  shell: \u0027echo {{ mirror_update_keytab_afsadmin }} | base64 -d \u003e /etc/afsadmin.keytab\u0027"},{"line_number":13,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_fc135f5a","line":10,"updated":"2019-07-01 22:05:28.000000000","message":"I guess we\u0027ve just been \"lucky\" since that\u0027s how we\u0027ve been doing it so far:\n  https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/create-afs-token/tasks/main.yaml#L8\n\nShould that be fixed?","commit_id":"eb49cd5a06bc62efed215ceff551c5c3762c690b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12a7723ca668b95f2bb78a8dfb27d47ea1d40acd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# because jinja treats the content as utf-8, and ends up mangling"},{"line_number":9,"context_line":"# \"real\" binary data like a keytab.  See issues like:"},{"line_number":10,"context_line":"#  https://github.com/ansible/ansible/issues/20150"},{"line_number":11,"context_line":"- name: Install afsadmin keytab"},{"line_number":12,"context_line":"  shell: \u0027echo {{ mirror_update_keytab_afsadmin }} | base64 -d \u003e /etc/afsadmin.keytab\u0027"},{"line_number":13,"context_line":"  args:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_bc45e7b5","line":10,"in_reply_to":"9fb8cfa7_fc135f5a","updated":"2019-07-01 23:49:17.000000000","message":"Maybe for 100% correctness ... but it\u0027s also possible from the keytab format that maybe it doesn\u0027t trigger the unicode issues at all.","commit_id":"eb49cd5a06bc62efed215ceff551c5c3762c690b"}],"playbooks/service-mirror-update.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e1283b2fbe91fafa5711e87962190bf96c00b3e","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        - kdc03.openstack.org"},{"line_number":9,"context_line":"        - kdc04.openstack.org"},{"line_number":10,"context_line":"    - role: openafs-client"},{"line_number":11,"context_line":"    - role: mirror-update"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_5c286b31","line":11,"updated":"2019-07-01 22:51:39.000000000","message":"Making sure I understand the testing plan here. We will install everything but with a fake keytab that won\u0027t authenticate. This will test the deployment of the mirror update node but not the functionality of afs volume updates?","commit_id":"eb49cd5a06bc62efed215ceff551c5c3762c690b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12a7723ca668b95f2bb78a8dfb27d47ea1d40acd","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        - kdc03.openstack.org"},{"line_number":9,"context_line":"        - kdc04.openstack.org"},{"line_number":10,"context_line":"    - role: openafs-client"},{"line_number":11,"context_line":"    - role: mirror-update"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9fb8cfa7_9c1823d3","line":11,"in_reply_to":"9fb8cfa7_5c286b31","updated":"2019-07-01 23:49:17.000000000","message":"Yes, that\u0027s it ... it seemed to heavyweight to actually copy things to a test volume or something.  I was mostly concerned the scripts ended up in the right place, and the secrets were written out correctly","commit_id":"eb49cd5a06bc62efed215ceff551c5c3762c690b"}],"testinfra/test_mirror-update.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e1283b2fbe91fafa5711e87962190bf96c00b3e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        assert f.exists"},{"line_number":48,"context_line":"        assert f.sha256sum \u003d\u003d KEYTAB_SHA256"},{"line_number":49,"context_line":"        assert f.mode \u003d\u003d 0o400"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_3c25775c","line":50,"updated":"2019-07-01 22:51:39.000000000","message":"Maybe also check the cron entries on the host?","commit_id":"eb49cd5a06bc62efed215ceff551c5c3762c690b"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12a7723ca668b95f2bb78a8dfb27d47ea1d40acd","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        assert f.exists"},{"line_number":48,"context_line":"        assert f.sha256sum \u003d\u003d KEYTAB_SHA256"},{"line_number":49,"context_line":"        assert f.mode \u003d\u003d 0o400"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9fb8cfa7_5c0e2b8c","line":50,"in_reply_to":"9fb8cfa7_3c25775c","updated":"2019-07-01 23:49:17.000000000","message":"happy to see this expanded :)","commit_id":"eb49cd5a06bc62efed215ceff551c5c3762c690b"}]}