)]}'
{"docker/gerrit/2.13/Dockerfile":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cdb6745fbe078d3a4e8896c13b8e67389702f082","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Install plugins"},{"line_number":41,"context_line":"RUN mkdir /var/gerrit/plugins \u0026\u0026 \\"},{"line_number":42,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/javamelody-v2.13.3.e4233d6.jar -O /var/gerrit/plugins/javamelody.jar \u0026\u0026 \\"},{"line_number":43,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/its-storyboard/its-storyboard-805f9ac.jar -O /var/gerrit/plugins/its-storyboard.jar"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# The following is what puppet-gerrit does in addition to installing the war"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_13671a28","line":42,"range":{"start_line":42,"start_character":7,"end_line":42,"end_character":11},"updated":"2019-07-23 18:01:56.000000000","message":"https would be a good idea here.","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d57ec8d25255544d862c44191a8d7c615b2e1e1b","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Install plugins"},{"line_number":41,"context_line":"RUN mkdir /var/gerrit/plugins \u0026\u0026 \\"},{"line_number":42,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/javamelody-v2.13.3.e4233d6.jar -O /var/gerrit/plugins/javamelody.jar \u0026\u0026 \\"},{"line_number":43,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/its-storyboard/its-storyboard-805f9ac.jar -O /var/gerrit/plugins/its-storyboard.jar"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# The following is what puppet-gerrit does in addition to installing the war"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_595ff30d","line":42,"range":{"start_line":42,"start_character":7,"end_line":42,"end_character":11},"in_reply_to":"7faddb67_13671a28","updated":"2019-07-23 19:00:58.000000000","message":"Done","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cdb6745fbe078d3a4e8896c13b8e67389702f082","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Install plugins"},{"line_number":41,"context_line":"RUN mkdir /var/gerrit/plugins \u0026\u0026 \\"},{"line_number":42,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/javamelody-v2.13.3.e4233d6.jar -O /var/gerrit/plugins/javamelody.jar \u0026\u0026 \\"},{"line_number":43,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/its-storyboard/its-storyboard-805f9ac.jar -O /var/gerrit/plugins/its-storyboard.jar"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# The following is what puppet-gerrit does in addition to installing the war"},{"line_number":46,"context_line":"# and the plugins. It\u0027s not clear it\u0027s needed, and it\u0027s not done in the 2.15"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_d370a2df","line":43,"range":{"start_line":43,"start_character":7,"end_line":43,"end_character":11},"updated":"2019-07-23 18:01:56.000000000","message":"https would be a good idea here.","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d57ec8d25255544d862c44191a8d7c615b2e1e1b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"# Install plugins"},{"line_number":41,"context_line":"RUN mkdir /var/gerrit/plugins \u0026\u0026 \\"},{"line_number":42,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/javamelody/javamelody-v2.13.3.e4233d6.jar -O /var/gerrit/plugins/javamelody.jar \u0026\u0026 \\"},{"line_number":43,"context_line":"  wget http://tarballs.openstack.org/ci/gerrit/plugins/its-storyboard/its-storyboard-805f9ac.jar -O /var/gerrit/plugins/its-storyboard.jar"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# The following is what puppet-gerrit does in addition to installing the war"},{"line_number":46,"context_line":"# and the plugins. It\u0027s not clear it\u0027s needed, and it\u0027s not done in the 2.15"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_f999ffcf","line":43,"range":{"start_line":43,"start_character":7,"end_line":43,"end_character":11},"in_reply_to":"7faddb67_d370a2df","updated":"2019-07-23 19:00:58.000000000","message":"Done","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cdb6745fbe078d3a4e8896c13b8e67389702f082","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"# The following is what puppet-gerrit does in addition to installing the war"},{"line_number":46,"context_line":"# and the plugins. It\u0027s not clear it\u0027s needed, and it\u0027s not done in the 2.15"},{"line_number":47,"context_line":"# dockerfile."},{"line_number":48,"context_line":"RUN mkdir /var/gerrit/lib \u0026\u0026 \\"},{"line_number":49,"context_line":"  unzip -jo /var/gerrit/bin/gerrit.war WEB-INF/plugins/* -d /var/gerrit/plugins \u0026\u0026 \\"},{"line_number":50,"context_line":"  wget https://repo1.maven.org/maven2/org/bouncycastle/bcprov-jdk15on/1.52/bcprov-jdk15on-1.52.jar -O /var/gerrit/lib/bcprov-1.52.jar \u0026\u0026 \\"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_b3440676","line":47,"updated":"2019-07-23 18:01:56.000000000","message":"Bouncy castle isn\u0027t used by gerrit by default iirc. So if you want to use their security libs instead (was necessary to support the gpg signed cla stuff too iirc) you had to side load them. Possible that changed with newer gerrit?\n\nAs for the mysql connector bits that was because we wanted to use distro mysql-connector and not what gerrit shipped I think.","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cdb6745fbe078d3a4e8896c13b8e67389702f082","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Allow incoming traffic"},{"line_number":55,"context_line":"EXPOSE 29418 8080"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"VOLUME /var/gerrit/git /var/gerrit/index /var/gerrit/cache /var/gerrit/db /etc/gerrit /var/log/gerrit"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN ln -s /var/log/gerrit /var/gerrit/logs \u0026\u0026 \\"},{"line_number":60,"context_line":"  ln -s /etc/gerrit /var/gerrit/config"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_7e3f35b5","line":57,"updated":"2019-07-23 18:01:56.000000000","message":"Maybe we should stick to /var/gerrit/etc? that would be more consistent with what we have today on the existing gerrit.\n\nAlso how does this interact with docker-compose and bind mounts? Does a VOLUME directive force these to be proper volumes or can we use bind mounts to satisfy them? The dockerfile docs weren\u0027t super clear on this but I think we have to specify the mount at run time so we should be able to make that a bind mount if we want?","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d57ec8d25255544d862c44191a8d7c615b2e1e1b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"# Allow incoming traffic"},{"line_number":55,"context_line":"EXPOSE 29418 8080"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"VOLUME /var/gerrit/git /var/gerrit/index /var/gerrit/cache /var/gerrit/db /etc/gerrit /var/log/gerrit"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"RUN ln -s /var/log/gerrit /var/gerrit/logs \u0026\u0026 \\"},{"line_number":60,"context_line":"  ln -s /etc/gerrit /var/gerrit/config"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_def669fa","line":57,"in_reply_to":"7faddb67_7e3f35b5","updated":"2019-07-23 19:00:58.000000000","message":"Yes - we should be able to specify these as bind mounts at start time.\n\nAnd yes, we should stick to /var/gerrit/etc I think. I have no idea how gerrit finds its config file otherwise.","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"cdb6745fbe078d3a4e8896c13b8e67389702f082","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  ln -s /etc/gerrit /var/gerrit/config"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--\"]"},{"line_number":63,"context_line":"CMD [\"/usr/bin/java\", \"-jar\", \"/var/gerrit/bin/gerrit.war\"]"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_9e6551e4","line":63,"updated":"2019-07-23 18:01:56.000000000","message":"Gerrit\u0027s init script does a lot more than just this. In particular it configures ulimits, sets the review site dir, and a run id. Do we need to do any of that here too?","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"d57ec8d25255544d862c44191a8d7c615b2e1e1b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  ln -s /etc/gerrit /var/gerrit/config"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"ENTRYPOINT [\"/usr/bin/dumb-init\", \"--\"]"},{"line_number":63,"context_line":"CMD [\"/usr/bin/java\", \"-jar\", \"/var/gerrit/bin/gerrit.war\"]"}],"source_content_type":"text/x-dockerfile","patch_set":13,"id":"7faddb67_7e0c1542","line":63,"in_reply_to":"7faddb67_9e6551e4","updated":"2019-07-23 19:00:58.000000000","message":"ulimit would be something we pass on the docker run command line - or as an option in the docker-compose file. Site dir we can bake in.\n\nThe other stuff is to handle pulling settings out of gerrit.config and passing them to the java command line. I think we can safely just update how we do those few things.\n\nI don\u0027t think we need run-id in docker.","commit_id":"15e6e19d98facb1b3d2100251e0b8038f5991d43"}]}